<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:11pt;color:#0078D7;margin:5pt;" align="Left">
[AMD Official Use Only - Internal Distribution Only]<br>
</p>
<br>
<div>
<div style=""><font face="segoe ui, segoe ui web (west european), segoe ui, -apple-system, blinkmacsystemfont, roboto, helvetica neue, sans-serif"><span style="font-size: 14.6667px;">thanks comments.</span></font></div>
<div style=""><font face="segoe ui, segoe ui web (west european), segoe ui, -apple-system, blinkmacsystemfont, roboto, helvetica neue, sans-serif"><span style="font-size: 14.6667px;"><br>
</span></font></div>
<div style=""><font face="segoe ui, segoe ui web (west european), segoe ui, -apple-system, blinkmacsystemfont, roboto, helvetica neue, sans-serif"><span style="font-size: 14.6667px;">I will refine these patches, then send out review later.</span></font></div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<span style="font-family: "segoe ui", "segoe ui web (west european)", "segoe ui", -apple-system, blinkmacsystemfont, roboto, "helvetica neue", sans-serif; font-size: 11pt; color: rgb(50, 49, 48); background-color: rgba(0, 0, 0, 0);">Best Regards,</span></div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<span style="font-family: "segoe ui", "segoe ui web (west european)", "segoe ui", -apple-system, blinkmacsystemfont, roboto, "helvetica neue", sans-serif; font-size: 11pt; color: rgb(50, 49, 48); background-color: rgba(0, 0, 0, 0);">Kevin</span></div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Christian König <ckoenig.leichtzumerken@gmail.com><br>
<b>Sent:</b> Thursday, January 28, 2021 3:46 PM<br>
<b>To:</b> Wang, Kevin(Yang) <Kevin1.Wang@amd.com>; dri-devel@lists.freedesktop.org <dri-devel@lists.freedesktop.org>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Cc:</b> Huang, Ray <Ray.Huang@amd.com>; Koenig, Christian <Christian.Koenig@amd.com><br>
<b>Subject:</b> Re: [RFC PATCH 0/3] add ttm trace event support</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="PlainText">Not a bad start, but that needs quite some more work.<br>
<br>
First of all please rebase on top of current drm-misc-next, a whole <br>
bunch of the stuff you want to trace here was already removed or is <br>
about to be removed.<br>
<br>
Then concentrate on the necessary trace points, for example <br>
ttm:ttm_bo_device_init/release are overkill.<br>
<br>
On the other hand I'm missing important events like pool shrink, tt <br>
swapout/swapin (ttm_bo_swapout can be dropped) and especially BO init.<br>
<br>
I would separate the patches into one for each trace point. Not a must <br>
have, but it could make it easier to review and we can discuss for each <br>
one separately.<br>
<br>
Thanks,<br>
Christian.<br>
<br>
Am 28.01.21 um 08:13 schrieb Kevin Wang:<br>
> the kernel ftrace can better help analyze the kernel running status.<br>
> add some trace events to support TTM.<br>
><br>
> add trace events list:<br>
><br>
> ttm:ttm_bo_add_mem_to_lru<br>
> ttm:ttm_bo_del_from_lru<br>
> ttm:ttm_bo_move_mem<br>
> ttm:ttm_bo_wait<br>
> ttm:ttm_bo_evict<br>
> ttm:ttm_bo_swapout<br>
> ttm:ttm_bo_device_init<br>
> ttm:ttm_bo_device_release<br>
> ttm:ttm_bo_init_reserved<br>
> ttm:ttm_bo_validate<br>
> ttm:ttm_bo_release<br>
> ttm:ttm_bo_mmap<br>
> ttm:ttm_bo_vm_fault<br>
> ttm:ttm_bo_vm_access<br>
> ttm:ttm_shrink<br>
> ttm:ttm_mem_global_reserve<br>
> ttm:ttm_mem_global_free<br>
><br>
> Kevin Wang (3):<br>
> drm/ttm: add ttm bo trace event support<br>
> drm/ttm: add ttm vm bo trace event support<br>
> drm/ttm: add ttm mem trace event support<br>
><br>
> drivers/gpu/drm/ttm/ttm_bo.c | 23 ++<br>
> drivers/gpu/drm/ttm/ttm_bo_vm.c | 12 +-<br>
> drivers/gpu/drm/ttm/ttm_memory.c | 7 +<br>
> drivers/gpu/drm/ttm/ttm_module.c | 3 +<br>
> drivers/gpu/drm/ttm/ttm_trace.h | 469 +++++++++++++++++++++++++++++++<br>
> 5 files changed, 512 insertions(+), 2 deletions(-)<br>
> create mode 100644 drivers/gpu/drm/ttm/ttm_trace.h<br>
><br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>