<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>
<body>
<div style="font-family: "segoe ui westeuropean", "segoe ui", helvetica, arial, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Well that's unfortunately a NAK.</div>
<div style="font-family: "segoe ui westeuropean", "segoe ui", helvetica, arial, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: "segoe ui westeuropean", "segoe ui", helvetica, arial, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
We currently can't communicate by DMA-buf if USWC is possible or not.</div>
<div style="font-family: "segoe ui westeuropean", "segoe ui", helvetica, arial, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: "segoe ui westeuropean", "segoe ui", helvetica, arial, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
For the short term we could add something like a special handling for A+A configurations here. E.g. check if the imported BO is also an andgpu BO and set the flag if it is also set on the exported BO.</div>
<div style="font-family: "segoe ui westeuropean", "segoe ui", helvetica, arial, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: "segoe ui westeuropean", "segoe ui", helvetica, arial, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Regards,</div>
<div style="font-family: "segoe ui westeuropean", "segoe ui", helvetica, arial, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Christian.</div>
<div><br>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>Von:</b> Sharma, Shashank <Shashank.Sharma@amd.com><br>
<b>Gesendet:</b> Samstag, 13. Februar 2021 17:37<br>
<b>An:</b> amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Cc:</b> Sharma, Shashank <Shashank.Sharma@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com><br>
<b>Betreff:</b> [PATCH 1/2] drm/amdgpu: Set GTT_USWC flag to enable freesync</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">This patch sets 'AMDGPU_GEM_CREATE_CPU_GTT_USWC' as input<br>
parameter flag, during object creation of an imported DMA<br>
buffer.<br>
<br>
In absence of this flag:<br>
1. Function amdgpu_display_supported_domains() doesn't add<br>
AMDGPU_GEM_DOMAIN_GTT as supported domain.<br>
2. Due to which, Function amdgpu_display_user_framebuffer_create()<br>
refuses to create framebuffer for imported DMA buffers.<br>
3. Due to which, AddFB() IOCTL fails.<br>
4. Due to which, amdgpu_present_check_flip() check fails in DDX<br>
5. Due to which DDX driver doesn't allow flips (goes to blitting)<br>
6. Due to which setting Freesync/VRR property fails for PRIME buffers.<br>
<br>
So, this patch finally enables Freesync with PRIME buffer offloading.<br>
<br>
Cc: Koenig Christian <christian.koenig@amd.com><br>
Cc: Deucher Alexander <alexander.deucher@amd.com><br>
Signed-off-by: Shashank Sharma <shashank.sharma@amd.com><br>
---<br>
drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 4 ++--<br>
1 file changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c<br>
index 47e0b48dc26f..db62f3c9d6a5 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c<br>
@@ -448,8 +448,8 @@ amdgpu_dma_buf_create_obj(struct drm_device *dev, struct dma_buf *dma_buf)<br>
bp.resv = resv;<br>
dma_resv_lock(resv, NULL);<br>
ret = amdgpu_gem_object_create(adev, dma_buf->size, PAGE_SIZE,<br>
- AMDGPU_GEM_DOMAIN_CPU,<br>
- 0, ttm_bo_type_sg, resv, &gobj);<br>
+ AMDGPU_GEM_DOMAIN_CPU, AMDGPU_GEM_CREATE_CPU_GTT_USWC,<br>
+ ttm_bo_type_sg, resv, &gobj);<br>
if (ret)<br>
goto error;<br>
<br>
-- <br>
2.25.1<br>
<br>
</div>
</span></font></div>
</body>
</html>