<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style> </head> <body dir="ltr"> <p style="font-family:Arial;font-size:11pt;color:#0078D7;margin:5pt;" align="Left"> [AMD Official Use Only - Internal Distribution Only]<br> </p> <br> <div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <span style="font-family: "segoe ui", "segoe ui web (west european)", "segoe ui", -apple-system, blinkmacsystemfont, roboto, "helvetica neue", sans-serif; font-size: 11pt; color: rgb(32, 31, 30); background-color: rgba(0, 0, 0, 0);">Hi Jiapeng,</span></div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <br> </div> <div id="appendonsend"></div> <div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)"> <span style="color: rgb(32, 31, 30); font-family: "segoe ui", "segoe ui web (west european)", "segoe ui", -apple-system, blinkmacsystemfont, roboto, "helvetica neue", sans-serif; font-size: 11pt; background-color: rgba(0, 0, 0, 0); display: inline !important;"> /* 0 - Fine grained DPM, 1 - Discrete DPM */</span><br> <span style="color: rgb(32, 31, 30); font-family: "segoe ui", "segoe ui web (west european)", "segoe ui", -apple-system, blinkmacsystemfont, roboto, "helvetica neue", sans-serif; font-size: 11pt; background-color: rgba(0, 0, 0, 0); display: inline !important;">- return dpm_desc->SnapToDiscrete == 0 ? true : false;</span><br style="color:rgb(32, 31, 30);font-family:"Segoe UI", "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif;font-size:14.6667px;background-color:rgb(255, 255, 255)"> <span style="color: rgb(32, 31, 30); font-family: "segoe ui", "segoe ui web (west european)", "segoe ui", -apple-system, blinkmacsystemfont, roboto, "helvetica neue", sans-serif; font-size: 11pt; background-color: rgba(0, 0, 0, 0); display: inline !important;">+ return !(dpm_desc->SnapToDiscrete == 0);</span><br> </div> <div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)"> <span style="color:rgb(32, 31, 30);font-family:"Segoe UI", "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif;font-size:14.6667px;background-color:rgb(255, 255, 255);display:inline !important"><br> </span></div> <div style=""><font color="#201f1e"><span style="font-size: 11pt; font-family: "segoe ui", "segoe ui web (west european)", "segoe ui", -apple-system, blinkmacsystemfont, roboto, "helvetica neue", sans-serif; color: rgb(32, 31, 30); background-color: rgba(0, 0, 0, 0);">the code logic is wrong, the '<span style="background-color:rgb(255, 255, 255);display:inline !important">!' is not needed.</span></span></font></div> <div style=""><font color="#201f1e"><span style="font-size: 14.6667px;"><br> </span></font></div> <div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)"> <span style="color: rgb(32, 31, 30); font-family: "segoe ui", "segoe ui web (west european)", "segoe ui", -apple-system, blinkmacsystemfont, roboto, "helvetica neue", sans-serif; font-size: 11pt; background-color: rgba(0, 0, 0, 0); display: inline !important;">Best Regards,</span></div> <div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)"> <span style="color: rgb(32, 31, 30); font-family: "segoe ui", "segoe ui web (west european)", "segoe ui", -apple-system, blinkmacsystemfont, roboto, "helvetica neue", sans-serif; font-size: 11pt; background-color: rgba(0, 0, 0, 0); display: inline !important;">Kevin</span></div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> dri-devel <dri-devel-bounces@lists.freedesktop.org> on behalf of Jiapeng Chong <jiapeng.chong@linux.alibaba.com><br> <b>Sent:</b> Friday, February 19, 2021 6:23 PM<br> <b>To:</b> Deucher, Alexander <Alexander.Deucher@amd.com><br> <b>Cc:</b> Jiapeng Chong <jiapeng.chong@linux.alibaba.com>; airlied@linux.ie <airlied@linux.ie>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>; dri-devel@lists.freedesktop.org <dri-devel@lists.freedesktop.org>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>; Koenig, Christian <Christian.Koenig@amd.com><br> <b>Subject:</b> [PATCH] drm/amdgpu/swsmu/navi1x: Remove unnecessary conversion to bool</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt"> <div class="PlainText">Fix the following coccicheck warnings:<br> <br> ./drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c:900:47-52: WARNING:<br> conversion to bool not needed here.<br> <br> Reported-by: Abaci Robot <abaci@linux.alibaba.com><br> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com><br> ---<br> drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c | 2 +-<br> 1 file changed, 1 insertion(+), 1 deletion(-)<br> <br> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c<br> index cd7efa9..dc9ce86 100644<br> --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c<br> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c<br> @@ -897,7 +897,7 @@ static bool navi10_is_support_fine_grained_dpm(struct smu_context *smu, enum smu<br> dpm_desc = &pptable->DpmDescriptor[clk_index];<br> <br> /* 0 - Fine grained DPM, 1 - Discrete DPM */<br> - return dpm_desc->SnapToDiscrete == 0 ? true : false;<br> + return !(dpm_desc->SnapToDiscrete == 0);<br> }<br> <br> static inline bool navi10_od_feature_is_supported(struct smu_11_0_overdrive_table *od_table, enum SMU_11_0_ODFEATURE_CAP cap)<br> -- <br> 1.8.3.1<br> <br> _______________________________________________<br> dri-devel mailing list<br> dri-devel@lists.freedesktop.org<br> <a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&data=04%7C01%7CKevin1.Wang%40amd.com%7C1709e8c3e5c44eb4d06b08d8d4c067d9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637493270133033509%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=tX8xq%2B31iYrBp3lLN7KKOBP3k8lMpecaX0ZSZf7c6y4%3D&reserved=0">https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&data=04%7C01%7CKevin1.Wang%40amd.com%7C1709e8c3e5c44eb4d06b08d8d4c067d9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637493270133033509%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=tX8xq%2B31iYrBp3lLN7KKOBP3k8lMpecaX0ZSZf7c6y4%3D&reserved=0</a><br> </div> </span></font></div> </div> </body> </html>