<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#317100;margin:15pt;" align="Left">
[AMD Public Use]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
yes, I have the same idea and agree with you.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
but patch is merged, I will add a new patch to refine it.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Best Regards,<br>
Kevin</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Zhang, Hawking <Hawking.Zhang@amd.com><br>
<b>Sent:</b> Monday, March 1, 2021 1:23 PM<br>
<b>To:</b> Wang, Kevin(Yang) <Kevin1.Wang@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Cc:</b> Li, Candice <Candice.Li@amd.com>; Wang, Kevin(Yang) <Kevin1.Wang@amd.com><br>
<b>Subject:</b> RE: [PATCH] drm/amdgpu: correct TA RAP firmware information print error</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="PlainText">[AMD Public Use]<br>
<br>
Instead of hard code the number of TA, it would be better to leverage enum ta_fw_type definition, explicitly call out TA_TYPE for each case in both amdgpu_firmware_info and amdgpu_debugfs_firmware_info_show.
<br>
<br>
Regards,<br>
Hawking<br>
-----Original Message-----<br>
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Kevin Wang<br>
Sent: Monday, March 1, 2021 10:52<br>
To: amd-gfx@lists.freedesktop.org<br>
Cc: Li, Candice <Candice.Li@amd.com>; Wang, Kevin(Yang) <Kevin1.Wang@amd.com><br>
Subject: [PATCH] drm/amdgpu: correct TA RAP firmware information print error<br>
<br>
miss RAP TA in loop ( when i == 4)<br>
<br>
Fix:<br>
drm/amdgpu: add RAP TA version print in amdgpu_firmware_info<br>
<br>
Signed-off-by: Kevin Wang <kevin1.wang@amd.com><br>
Reported-by: Candice Li <candice.li@amd.com><br>
---<br>
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c<br>
index a5ed9530f542..6c8ea9d26320 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c<br>
@@ -1472,7 +1472,7 @@ static int amdgpu_debugfs_firmware_info_show(struct seq_file *m, void *unused)<br>
fw_info.feature, fw_info.ver);<br>
<br>
query_fw.fw_type = AMDGPU_INFO_FW_TA;<br>
- for (i = 0; i < 4; i++) {<br>
+ for (i = 0; i < 5; i++) {<br>
query_fw.index = i;<br>
ret = amdgpu_firmware_info(&fw_info, &query_fw, adev);<br>
if (ret)<br>
-- <br>
2.17.1<br>
<br>
_______________________________________________<br>
amd-gfx mailing list<br>
amd-gfx@lists.freedesktop.org<br>
<a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7Chawking.zhang%40amd.com%7C76e6934844e14fd942ec08d8dc5d042d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637501639364874702%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=ouIjHlz93nX%2Fj3gZ9tdhHxYX501bJmQm3UzqpDwSJGw%3D&reserved=0">https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7Chawking.zhang%40amd.com%7C76e6934844e14fd942ec08d8dc5d042d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637501639364874702%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=ouIjHlz93nX%2Fj3gZ9tdhHxYX501bJmQm3UzqpDwSJGw%3D&reserved=0</a><br>
</div>
</span></font></div>
</div>
</body>
</html>