<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style> </head> <body dir="ltr"> <p style="font-family:Arial;font-size:11pt;color:#0078D7;margin:5pt;" align="Left"> [AMD Official Use Only - Internal Distribution Only]<br> </p> <br> <div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> + Leo<br> </div> <div id="appendonsend"></div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Christian König <ckoenig.leichtzumerken@gmail.com><br> <b>Sent:</b> Friday, March 19, 2021 10:08 AM<br> <b>To:</b> Liu, Leo <Leo.Liu@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>; dri-devel@lists.freedesktop.org <dri-devel@lists.freedesktop.org><br> <b>Subject:</b> [PATCH] drm/ttm: stop warning on TT shrinker failure</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText">Don't print a warning when we fail to allocate a page for swapping things out.<br> <br> Also rely on memalloc_nofs_save/memalloc_nofs_restore instead of GFP_NOFS.<br> <br> Signed-off-by: Christian König <christian.koenig@amd.com><br> ---<br> drivers/gpu/drm/ttm/ttm_tt.c | 5 ++++-<br> 1 file changed, 4 insertions(+), 1 deletion(-)<br> <br> diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c<br> index 2f0833c98d2c..86fa3e82dacc 100644<br> --- a/drivers/gpu/drm/ttm/ttm_tt.c<br> +++ b/drivers/gpu/drm/ttm/ttm_tt.c<br> @@ -369,7 +369,7 @@ static unsigned long ttm_tt_shrinker_scan(struct shrinker *shrink,<br> };<br> int ret;<br> <br> - ret = ttm_bo_swapout(&ctx, GFP_NOFS);<br> + ret = ttm_bo_swapout(&ctx, GFP_KERNEL | __GFP_NOWARN);<br> return ret < 0 ? SHRINK_EMPTY : ret;<br> }<br> <br> @@ -389,10 +389,13 @@ static unsigned long ttm_tt_shrinker_count(struct shrinker *shrink,<br> static int ttm_tt_debugfs_shrink_show(struct seq_file *m, void *data)<br> {<br> struct shrink_control sc = { .gfp_mask = GFP_KERNEL };<br> + unsigned int flags;<br> <br> fs_reclaim_acquire(GFP_KERNEL);<br> + flags = memalloc_nofs_save();<br> seq_printf(m, "%lu/%lu\n", ttm_tt_shrinker_count(&mm_shrinker, &sc),<br> ttm_tt_shrinker_scan(&mm_shrinker, &sc));<br> + memalloc_nofs_restore(flags);<br> fs_reclaim_release(GFP_KERNEL);<br> <br> return 0;<br> -- <br> 2.25.1<br> <br> _______________________________________________<br> amd-gfx mailing list<br> amd-gfx@lists.freedesktop.org<br> <a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7Calexander.deucher%40amd.com%7C70aef4974dfe465a06a308d8eae08eb3%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637517597539809703%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=kvyinv9FPakf76dvXF0pzfeCpclxAo3L4Ufkf6%2B6%2FCc%3D&reserved=0">https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7Calexander.deucher%40amd.com%7C70aef4974dfe465a06a308d8eae08eb3%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637517597539809703%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=kvyinv9FPakf76dvXF0pzfeCpclxAo3L4Ufkf6%2B6%2FCc%3D&reserved=0</a><br> </div> </span></font></div> </div> </body> </html>