<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:11pt;color:#0078D7;margin:5pt;" align="Left">
[AMD Official Use Only - Internal Distribution Only]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Can someone double check this on RN/CZN with S3 and S0ix?</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Alex</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Liu, Zhan <Zhan.Liu@amd.com><br>
<b>Sent:</b> Friday, March 26, 2021 1:46 AM<br>
<b>To:</b> Deucher, Alexander <Alexander.Deucher@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Cc:</b> Deucher, Alexander <Alexander.Deucher@amd.com><br>
<b>Subject:</b> RE: [PATCH] drm/amdgpu/swsmu: don't bail early on hw_setup on resume</font>
<div> </div>
</div>
<div class="BodyFragment"><font face="Times New Roman" size="3"><span style="font-size:12pt;"><a name="BM_BEGIN"></a>
<div><font size="2"><span style="font-size:11pt;">[AMD Official Use Only - Internal Distribution Only]<br>
<br>
> -----Original Message-----<br>
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Alex<br>
> Deucher<br>
> Sent: 2021/March/26, Friday 12:38 AM<br>
> To: amd-gfx@lists.freedesktop.org<br>
> Cc: Deucher, Alexander <Alexander.Deucher@amd.com><br>
> Subject: [PATCH] drm/amdgpu/swsmu: don't bail early on hw_setup on<br>
> resume<br>
><br>
> The SMU comes back up with DPM enabled by the sbios, but the driver still<br>
> has to set up the SMU/driver mailbox, etc.<br>
><br>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com><br>
<br>
Reviewed-by: Zhan Liu <zhan.liu@amd.com><br>
<br>
> ---<br>
> drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 2 +-<br>
> 1 file changed, 1 insertion(+), 1 deletion(-)<br>
><br>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c<br>
> b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c<br>
> index d4b804c7b986..462917d4d5e2 100644<br>
> --- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c<br>
> +++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c<br>
> @@ -1102,7 +1102,7 @@ static int smu_smc_hw_setup(struct smu_context<br>
> *smu)<br>
> uint32_t pcie_gen = 0, pcie_width = 0;<br>
> int ret = 0;<br>
><br>
> -if (adev->in_suspend && smu_is_dpm_running(smu)) {<br>
> +if (!smu->is_apu && adev->in_suspend &&<br>
> smu_is_dpm_running(smu)) {<br>
> dev_info(adev->dev, "dpm has been enabled\n");<br>
> /* this is needed specifically */<br>
> if ((adev->asic_type >= CHIP_SIENNA_CICHLID) &&<br>
> --<br>
> 2.30.2<br>
><br>
> _______________________________________________<br>
> amd-gfx mailing list<br>
> amd-gfx@lists.freedesktop.org<br>
> <a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists">
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists</a>.<br>
> freedesktop.org%2Fmailman%2Flistinfo%2Famd-<br>
> gfx&data=04%7C01%7Czhan.liu%40amd.com%7C500744d08f7946b2c5d<br>
> e08d8f010ec49%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C6375<br>
> 23302768646367%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiL<br>
> CJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=vN<br>
> JawxwfojJrxNOG5L8Y2BAWpGRRN6valpk6y00XIQw%3D&reserved=0<br>
</span></font></div>
</span></font></div>
</div>
</body>
</html>