<div dir="ltr">Reviewed-by: Bas Nieuwenhuizen <<a href="mailto:bas@basnieuwenhuizen.nl">bas@basnieuwenhuizen.nl</a>> </div> <div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Apr 9, 2021 at 3:19 PM Simon Ser <<a href="mailto:contact@emersion.fr">contact@emersion.fr</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi, Can you have a look at this patch? Thanks, Simon On Friday, March 26th, 2021 at 5:59 PM, Simon Ser <<a href="mailto:contact@emersion.fr" target="_blank">contact@emersion.fr</a>> wrote: > Accept non-linear buffers which use a multi-planar format, as long > as they don't use DCC. > > Tested on GFX9 with NV12. > > Signed-off-by: Simon Ser <<a href="mailto:contact@emersion.fr" target="_blank">contact@emersion.fr</a>> > Cc: Alex Deucher <<a href="mailto:alexander.deucher@amd.com" target="_blank">alexander.deucher@amd.com</a>> > Cc: Harry Wentland <<a href="mailto:hwentlan@amd.com" target="_blank">hwentlan@amd.com</a>> > Cc: Nicholas Kazlauskas <<a href="mailto:nicholas.kazlauskas@amd.com" target="_blank">nicholas.kazlauskas@amd.com</a>> > Cc: Bas Nieuwenhuizen <<a href="mailto:bas@basnieuwenhuizen.nl" target="_blank">bas@basnieuwenhuizen.nl</a>> > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > index 36ee52104007..66e3ecf123d1 100644 > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > @@ -4216,13 +4216,6 @@ static bool dm_plane_format_mod_supported(struct drm_plane *plane, > if (modifier == DRM_FORMAT_MOD_LINEAR) > return true; > > - /* > - * The arbitrary tiling support for multiplane formats has not been hooked > - * up. > - */ > - if (info->num_planes > 1) > - return false; > - > /* > * For D swizzle the canonical modifier depends on the bpp, so check > * it here. > @@ -4241,6 +4234,10 @@ static bool dm_plane_format_mod_supported(struct drm_plane *plane, > /* Per radeonsi comments 16/64 bpp are more complicated. */ > if (info->cpp[0] != 4) > return false; > + /* We support multi-planar formats, but not when combined with > + * additional DCC metadata planes. */ > + if (info->num_planes > 1) > + return false; > } > > return true; </blockquote></div>