<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=windows-1252"> </head> <body> And BTW <span style="color: rgb(0, 0, 0); font-family: "Segoe UI", "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; font-size: 14.6667px; background-color: rgb(255, 255, 255); display: inline !important;">amdgpu_ctx_fence_time() should probably be static. Christian. <div class="moz-cite-prefix">Am 12.05.21 um 08:55 schrieb Christian König: </div> <blockquote type="cite" cite="mid:9b373f49-51ad-089c-2494-032b13a9a39c@gmail.com"> <meta http-equiv="Content-Type" content="text/html; charset=windows-1252"> In this case <span style="color: rgb(0, 0, 0); font-family: "Segoe UI", "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; font-size: 14.6667px; background-color: rgb(255, 255, 255); display: inline !important;">amdgpu_ctx_fence_time should probably be changed to initialize the variable itself. That is really bad coding style otherwise. Christian. <div class="moz-cite-prefix">Am 11.05.21 um 20:14 schrieb Nieto, David M: </div> <blockquote type="cite" cite="mid:BYAPR12MB284099C33725C0BB0FDD8D48F4539@BYAPR12MB2840.namprd12.prod.outlook.com"> <meta http-equiv="Content-Type" content="text/html; charset=windows-1252"> <style type="text/css" style="display:none;">P {margin-top:0;margin-bottom:0;}</style> [AMD Official Use Only - Internal Distribution Only] <div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);"> The local variables need to be initialized to zero, since <span style="color: rgb(0, 0, 0); font-family: "Segoe UI", "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; font-size: 14.6667px; background-color: rgb(255, 255, 255); display: inline !important;">amdgpu_ctx_fence_time accumulates and does not initialize</div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);"> <span style="color: rgb(0, 0, 0); font-family: "Segoe UI", "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; font-size: 14.6667px; background-color: rgb(255, 255, 255); display: inline !important;"> </div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);"> <span style="color: rgb(0, 0, 0); font-family: "Segoe UI", "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; font-size: 14.6667px; background-color: rgb(255, 255, 255); display: inline !important;">David</div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr">From: Christian König <a class="moz-txt-link-rfc2396E" href="mailto:ckoenig.leichtzumerken@gmail.com" moz-do-not-send="true"><ckoenig.leichtzumerken@gmail.com></a> Sent: Tuesday, May 11, 2021 12:53 AM To: Nieto, David M <a class="moz-txt-link-rfc2396E" href="mailto:David.Nieto@amd.com" moz-do-not-send="true"><David.Nieto@amd.com></a>; <a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org" moz-do-not-send="true">amd-gfx@lists.freedesktop.org</a> <a class="moz-txt-link-rfc2396E" href="mailto:amd-gfx@lists.freedesktop.org" moz-do-not-send="true"><amd-gfx@lists.freedesktop.org></a> Subject: Re: [PATCH 2/2] drm/amdgpu: fix fence calculation <div> </div> </div> <div class="BodyFragment"> <div class="PlainText">Am 10.05.21 um 22:29 schrieb David M Nieto: > The proper metric for fence utilization over several > contexts is an harmonic mean, but such calculation is > prohibitive in kernel space, so the code approximates it. > > Because the approximation diverges when one context has a > very small ratio compared with the other context, this change > filter out ratios smaller that 0.01% > > Signed-off-by: David M Nieto <a class="moz-txt-link-rfc2396E" href="mailto:david.nieto@amd.com" moz-do-not-send="true"><david.nieto@amd.com></a> > Change-Id: I5b6e0ce5f489a5f55855d35354a6a3653e9d613b > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 13 ++++++++++++- > drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.h | 1 + > 2 files changed, 13 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c > index 9036c93b4a0c..89ee464b9424 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c > @@ -698,16 +698,27 @@ ktime_t amdgpu_ctx_mgr_fence_usage(struct amdgpu_ctx_mgr *mgr, uint32_t hwip, > struct amdgpu_ctx_entity *centity; > ktime_t total = 0, max = 0; > > + Unrelated white space change. > if (idx >= AMDGPU_MAX_ENTITY_NUM) > return 0; > idp = &mgr->ctx_handles; > mutex_lock(&mgr->lock); > idr_for_each_entry(idp, ctx, id) { > + ktime_t ttotal = tmax = ktime_set(0, 0); There should be a blank line between decleration and code and please don't initialize local variables if it isn't necessary. Christian. > if (!ctx->entities[hwip][idx]) > continue; > > centity = ctx->entities[hwip][idx]; > - amdgpu_ctx_fence_time(ctx, centity, &total, &max); > + amdgpu_ctx_fence_time(ctx, centity, &ttotal, &tmax); > + > + /* Harmonic mean approximation diverges for very small > + * values. If ratio < 0.01% ignore > + */ > + if (AMDGPU_CTX_FENCE_USAGE_MIN_RATIO(tmax, ttotal)) > + continue; > + > + total = ktime_add(total, ttotal); > + max = ktime_after(tmax, max) ? tmax : max; > } > > mutex_unlock(&mgr->lock); > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.h > index 10dcf59a5c6b..3541dfb059ec 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.h > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.h > @@ -30,6 +30,7 @@ struct drm_file; > struct amdgpu_fpriv; > > #define AMDGPU_MAX_ENTITY_NUM 4 > +#define AMDGPU_CTX_FENCE_USAGE_MIN_RATIO(max, total) (max > 16384ULL*total) > > struct amdgpu_ctx_entity { > uint64_t sequence; </div> </div> </div> </blockquote> </blockquote> </body> </html>