<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Hi,</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">doesn't this patch apply the change to VCN1.0 also, which has that bug you mentioned?</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Regards</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">//Ernst<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Den mån 7 juni 2021 kl 22:29 skrev Alex Deucher <<a href="mailto:alexander.deucher@amd.com">alexander.deucher@amd.com</a>>:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Drop disabling of gfxoff during VCN use.  This allows gfxoff<br>
to kick in and potentially save power if the user is not using<br>
gfx for color space conversion or scaling.<br>
<br>
VCN1.0 had a bug which prevented it from working properly with<br>
gfxoff, so we disabled it while using VCN.  That said, most apps<br>
today use gfx for scaling and color space conversion rather than<br>
overlay planes so it was generally in use anyway. This was fixed<br>
on VCN2+, but since we mostly use gfx for color space conversion<br>
and scaling and rapidly powering up/down gfx can negate the<br>
advantages of gfxoff, we left gfxoff disabled. As more<br>
applications use overlay planes for color space conversion<br>
and scaling, this starts to be a win, so go ahead and leave<br>
gfxoff enabled.<br>
<br>
Signed-off-by: Alex Deucher <<a href="mailto:alexander.deucher@amd.com" target="_blank">alexander.deucher@amd.com</a>><br>
---<br>
 drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 2 --<br>
 1 file changed, 2 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c<br>
index 1dc11dbd62b7..647d2c31e8bd 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c<br>
@@ -393,7 +393,6 @@ static void amdgpu_vcn_idle_work_handler(struct work_struct *work)<br>
        }<br>
<br>
        if (!fences && !atomic_read(&adev->vcn.total_submission_cnt)) {<br>
-               amdgpu_gfx_off_ctrl(adev, true);<br>
                amdgpu_device_ip_set_powergating_state(adev, AMD_IP_BLOCK_TYPE_VCN,<br>
                       AMD_PG_STATE_GATE);<br>
                r = amdgpu_dpm_switch_power_profile(adev, PP_SMC_POWER_PROFILE_VIDEO,<br>
@@ -413,7 +412,6 @@ void amdgpu_vcn_ring_begin_use(struct amdgpu_ring *ring)<br>
        atomic_inc(&adev->vcn.total_submission_cnt);<br>
<br>
        if (!cancel_delayed_work_sync(&adev->vcn.idle_work)) {<br>
-               amdgpu_gfx_off_ctrl(adev, false);<br>
                r = amdgpu_dpm_switch_power_profile(adev, PP_SMC_POWER_PROFILE_VIDEO,<br>
                                true);<br>
                if (r)<br>
-- <br>
2.31.1<br>
<br>
_______________________________________________<br>
amd-gfx mailing list<br>
<a href="mailto:amd-gfx@lists.freedesktop.org" target="_blank">amd-gfx@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br>
</blockquote></div>