<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#0000FF;margin:5pt;" align="Left">
[AMD Official Use Only]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div id="appendonsend"></div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Lazar, Lijo <Lijo.Lazar@amd.com><br>
<b>Sent:</b> Monday, August 2, 2021 3:41 PM<br>
<b>To:</b> Wang, Kevin(Yang) <Kevin1.Wang@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Subject:</b> Re: [PATCH] drm/amd/pm: correct aldebaran smu feature mapping FEATURE_DATA_CALCULATIONS</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="PlainText"><br>
<br>
On 8/2/2021 8:23 AM, Kevin Wang wrote:<br>
> correct smu feature mapping: FEATURE_DATA_CALCULATIONS<br>
> <br>
> Signed-off-by: Kevin Wang <kevin1.wang@amd.com><br>
> ---<br>
> drivers/gpu/drm/amd/pm/inc/smu_types.h | 1 +<br>
> drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 3 +--<br>
> 2 files changed, 2 insertions(+), 2 deletions(-)<br>
> <br>
> diff --git a/drivers/gpu/drm/amd/pm/inc/smu_types.h b/drivers/gpu/drm/amd/pm/inc/smu_types.h<br>
> index 1d3765b873df..6239c30fcd5f 100644<br>
> --- a/drivers/gpu/drm/amd/pm/inc/smu_types.h<br>
> +++ b/drivers/gpu/drm/amd/pm/inc/smu_types.h<br>
> @@ -282,6 +282,7 @@ enum smu_clk_type {<br>
> __SMU_DUMMY_MAP(TDC), \<br>
> __SMU_DUMMY_MAP(THERMAL), \<br>
> __SMU_DUMMY_MAP(GFX_PER_CU_CG), \<br>
> + __SMU_DUMMY_MAP(DATA_CALCULATIONS), \<br>
> __SMU_DUMMY_MAP(RM), \<br>
> __SMU_DUMMY_MAP(DS_DCEFCLK), \<br>
> __SMU_DUMMY_MAP(ACDC), \<br>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c<br>
> index 856eeaf293b8..4af602d6ee02 100644<br>
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c<br>
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c<br>
> @@ -64,7 +64,6 @@<br>
> <br>
> #define FEATURE_MASK(feature) (1ULL << feature)<br>
> #define SMC_DPM_FEATURE ( \<br>
> - FEATURE_MASK(FEATURE_DATA_CALCULATIONS) | \<br>
<br>
Data calculations should be enabled for DPM. Undo this change before <br>
submitting.<br>
<br>
Reviewed-by: Lijo Lazar <lijo.lazar@amd.com><br>
<br>
[kevin]:</div>
<div class="PlainText"><br>
</div>
<div class="PlainText">thanks, lijo. I agree with you, and I will correct it before submit.</div>
<div class="PlainText"><br>
</div>
<div class="PlainText">Best Regards,</div>
<div class="PlainText">Kevin<br>
<br>
> FEATURE_MASK(FEATURE_DPM_GFXCLK_BIT) | \<br>
> FEATURE_MASK(FEATURE_DPM_UCLK_BIT) | \<br>
> FEATURE_MASK(FEATURE_DPM_SOCCLK_BIT) | \<br>
> @@ -150,7 +149,7 @@ static const struct cmn2asic_mapping aldebaran_clk_map[SMU_CLK_COUNT] = {<br>
> };<br>
> <br>
> static const struct cmn2asic_mapping aldebaran_feature_mask_map[SMU_FEATURE_COUNT] = {<br>
> - ALDEBARAN_FEA_MAP(SMU_FEATURE_DPM_PREFETCHER_BIT, FEATURE_DATA_CALCULATIONS),<br>
> + ALDEBARAN_FEA_MAP(SMU_FEATURE_DATA_CALCULATIONS_BIT, FEATURE_DATA_CALCULATIONS),<br>
> ALDEBARAN_FEA_MAP(SMU_FEATURE_DPM_GFXCLK_BIT, FEATURE_DPM_GFXCLK_BIT),<br>
> ALDEBARAN_FEA_MAP(SMU_FEATURE_DPM_UCLK_BIT, FEATURE_DPM_UCLK_BIT),<br>
> ALDEBARAN_FEA_MAP(SMU_FEATURE_DPM_SOCCLK_BIT, FEATURE_DPM_SOCCLK_BIT),<br>
> <br>
</div>
</span></font></div>
</div>
</body>
</html>