<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#008000;margin:15pt;" align="Left">
[Public]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);">
Hello Guchun,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);">
In most of those cases you are right it is redundant, the reason i kept them separate for now is to resolve this bug while also keeping those interfaces modular, and not affecting the psp submit sequence yet. We are planning a bigger change to that source to
remove alot of the duplicate code regarding the cmd buffer prepare/submit flow and will probably go back down to one mutex there.<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);">
Thank you,
<div>John Clements</div>
<br>
</div>
<div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font style="font-size: 11pt;" face="Calibri, sans-serif" color="#000000"><b>From:</b> Chen, Guchun <Guchun.Chen@amd.com><br>
<b>Sent:</b> Tuesday, August 3, 2021 9:58 PM<br>
<b>To:</b> Clements, John <John.Clements@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Cc:</b> Zhang, Hawking <Hawking.Zhang@amd.com>; Li, Candice <Candice.Li@amd.com>; Lazar, Lijo <Lijo.Lazar@amd.com><br>
<b>Subject:</b> RE: [PATCH] drm/amdgpu: added synchronization for psp cmd buf access</font>
<div> </div>
</div>
<div style="word-wrap:break-word" lang="EN-US">
<div class="x_WordSection1">
<p class="x_msipheader23c54b6f" style="margin-right: 0in; margin-left: 0in; font-size: 11pt; font-family: "Calibri", sans-serif;margin:0in">
<span style="font-size: 10pt; font-family: "Arial", sans-serif; color: green;">[Public]</span></p>
<p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: "Calibri", sans-serif;">
</p>
<p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: "Calibri", sans-serif;">
Before calling into psp_cmd_submit_buf, a mutex psp->cmd_buf_mutex is there, and after entering psp_cmd_submit_buf, there is another mutex psp->mutex, is it a bit redundant?</p>
<div>
<p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: "Calibri", sans-serif;">
</p>
<p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: "Calibri", sans-serif;">
Regards,</p>
<p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: "Calibri", sans-serif;">
Guchun</p>
</div>
<p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: "Calibri", sans-serif;">
</p>
<div>
<div style="border:none; border-top:solid #E1E1E1 1.0pt; padding:3.0pt 0in 0in 0in">
<p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: "Calibri", sans-serif;">
<b>From:</b> Clements, John <John.Clements@amd.com> <br>
<b>Sent:</b> Tuesday, August 3, 2021 5:50 PM<br>
<b>To:</b> amd-gfx@lists.freedesktop.org<br>
<b>Cc:</b> Zhang, Hawking <Hawking.Zhang@amd.com>; Li, Candice <Candice.Li@amd.com>; Lazar, Lijo <Lijo.Lazar@amd.com>; Chen, Guchun <Guchun.Chen@amd.com><br>
<b>Subject:</b> [PATCH] drm/amdgpu: added synchronization for psp cmd buf access</p>
</div>
</div>
<p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: "Calibri", sans-serif;">
</p>
<p class="x_msipheadera4477989" style="margin-right: 0in; margin-left: 0in; font-size: 11pt; font-family: "Calibri", sans-serif;margin:0in">
<span style="font-size: 10pt; font-family: "Arial", sans-serif; color: blue;">[AMD Official Use Only]</span></p>
<p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: "Calibri", sans-serif;">
</p>
<p class="x_MsoNormal" style="margin: 0in; font-size: 11pt; font-family: "Calibri", sans-serif;">
Submitting patch to synchronize access to psp cmd submission memory to resolve potential race conditions.</p>
</div>
</div>
</div>
</div>
</body>
</html>