<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple" style="word-wrap:break-word"> <div class="WordSection1"> <p class="msipheader23c54b6f" style="margin:0in"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:green">[Public]</span><o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">Thanks Alex for your reply.<o:p></o:p></p> <p class="MsoNormal">The patch is not fixing our issue. <o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">Thanks<o:p></o:p></p> <p class="MsoNormal">-Rajib<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal"><b>From:</b> Deucher, Alexander <Alexander.Deucher@amd.com> <br> <b>Sent:</b> Thursday, August 26, 2021 11:48 PM<br> <b>To:</b> Mahapatra, Rajib <Rajib.Mahapatra@amd.com>; Wentland, Harry <Harry.Wentland@amd.com>; Kazlauskas, Nicholas <Nicholas.Kazlauskas@amd.com>; Wu, Hersen <hersenxs.wu@amd.com><br> <b>Cc:</b> amd-gfx@lists.freedesktop.org<br> <b>Subject:</b> Re: [PATCH] drm/amd/display: Set the domain as GTT when VRAM size <= 32 MB<o:p></o:p></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <p style="margin:15.0pt"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:green">[Public]<o:p></o:p></span></p> <p class="MsoNormal"><o:p> </o:p></p> <div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;color:black">I think this may have already been fixed with this patch:<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;color:black"><a href="https://gitlab.freedesktop.org/agd5f/linux/-/commit/2a7b9a8437130fd328001f4edfac8eec98dfe298">https://gitlab.freedesktop.org/agd5f/linux/-/commit/2a7b9a8437130fd328001f4edfac8eec98dfe298</a><o:p></o:p></span></p> </div> <p class="MsoNormal"><o:p> </o:p></p> <div> <p class="MsoNormal"><span style="font-size:12.0pt;color:black">Alex<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;color:black"><o:p> </o:p></span></p> </div> <div class="MsoNormal" align="center" style="text-align:center"> <hr size="2" width="98%" align="center"> </div> <div id="divRplyFwdMsg"> <p class="MsoNormal"><b><span style="color:black">From:</span></b><span style="color:black"> Mahapatra, Rajib <<a href="mailto:Rajib.Mahapatra@amd.com">Rajib.Mahapatra@amd.com</a>><br> <b>Sent:</b> Thursday, August 26, 2021 2:07 PM<br> <b>To:</b> Wentland, Harry <<a href="mailto:Harry.Wentland@amd.com">Harry.Wentland@amd.com</a>>; Kazlauskas, Nicholas <<a href="mailto:Nicholas.Kazlauskas@amd.com">Nicholas.Kazlauskas@amd.com</a>>; Deucher, Alexander <<a href="mailto:Alexander.Deucher@amd.com">Alexander.Deucher@amd.com</a>>; Wu, Hersen <<a href="mailto:hersenxs.wu@amd.com">hersenxs.wu@amd.com</a>><br> <b>Cc:</b> <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <<a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>>; Mahapatra, Rajib <<a href="mailto:Rajib.Mahapatra@amd.com">Rajib.Mahapatra@amd.com</a>><br> <b>Subject:</b> [PATCH] drm/amd/display: Set the domain as GTT when VRAM size <= 32 MB</span> <o:p></o:p></p> <div> <p class="MsoNormal"> <o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal" style="margin-bottom:12.0pt">[Why]<br> In lower carve out (<= 32 MB) devices, it was unable to pin framebuffer in<br> VRAM domain for some BO allocations. The device shows below error logs and<br> sometimes it reboots too.<br> <br> amdgpu 0000:02:00.0: amdgpu: 00000000d721431c pin failed<br> [drm:dm_plane_helper_prepare_fb] *ERROR* Failed to pin framebuffer with error -12<br> <br> [How]<br> Place the domain as GTT when VRAM size <= 32 MB.<br> <br> Signed-off-by: Rajib Mahapatra <<a href="mailto:rajib.mahapatra@amd.com">rajib.mahapatra@amd.com</a>><br> ---<br> drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +<br> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 10 +++++++++-<br> 2 files changed, 10 insertions(+), 1 deletion(-)<br> <br> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h<br> index dc3c6b3a00e5..d719be448eec 100644<br> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h<br> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h<br> @@ -236,6 +236,7 @@ extern int amdgpu_num_kcq;<br> <br> #define AMDGPU_VM_MAX_NUM_CTX 4096<br> #define AMDGPU_SG_THRESHOLD (256*1024*1024)<br> +#define AMDGPU_VRAM_MIN_THRESHOLD (32*1024*1024)<br> #define AMDGPU_DEFAULT_GTT_SIZE_MB 3072ULL /* 3GB by default */<br> #define AMDGPU_WAIT_IDLE_TIMEOUT_IN_MS 3000<br> #define AMDGPU_MAX_USEC_TIMEOUT 100000 /* 100 ms */<br> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c<br> index e1e57e7465a7..f71391599be1 100644<br> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c<br> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c<br> @@ -7106,8 +7106,16 @@ static int dm_plane_helper_prepare_fb(struct drm_plane *plane,<br> return r;<br> }<br> <br> - if (plane->type != DRM_PLANE_TYPE_CURSOR)<br> + if (plane->type != DRM_PLANE_TYPE_CURSOR) {<br> domain = amdgpu_display_supported_domains(adev, rbo->flags);<br> + /*<br> + * Handle devices with lower carve out.<br> + */<br> + if (adev->gmc.real_vram_size <= AMDGPU_VRAM_MIN_THRESHOLD) {<br> + domain |= (domain & AMDGPU_GEM_DOMAIN_GTT) ? domain :<br> + AMDGPU_GEM_DOMAIN_GTT;<br> + }<br> + }<br> else<br> domain = AMDGPU_GEM_DOMAIN_VRAM;<br> <br> -- <br> 2.25.1<o:p></o:p></p> </div> </div> </div> </div> </body> </html>