<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body>
Ok, good to know. That's probably the reason why we didn't push that
stuff into the IB in the first place.<br>
<br>
And yes, using fixed 256kiB sounds like a plan to me then, but
please also double check the AMDGPU_IB_POOL_SIZE define.<br>
<br>
I also won't mind if you just open code the two initialization since
there probably will never be any more than that. <br>
<br>
Thanks,<br>
Christian.<br>
<br>
<div class="moz-cite-prefix">Am 09.09.21 um 09:57 schrieb Pan,
Xinhui:<br>
</div>
<blockquote type="cite"
cite="mid:DM4PR12MB51653E83408F2CA3F3D5029687D59@DM4PR12MB5165.namprd12.prod.outlook.com">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<p
style="font-family:Arial;font-size:10pt;color:#0000FF;margin:5pt;"
align="Left">
[AMD Official Use Only]<br>
</p>
<br>
<div>
<div dir="auto" style="direction: ltr; margin: 0px; padding:
0px; font-family: sans-serif; font-size: 11pt; color: black;
text-align: left;">
yep, vcn need 128kb extra memory. I will make the pool size
constant as 256kb. </div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt"
face="Calibri, sans-serif" color="#000000"><b>From:</b>
Koenig, Christian <a class="moz-txt-link-rfc2396E" href="mailto:Christian.Koenig@amd.com"><Christian.Koenig@amd.com></a><br>
<b>Sent:</b> Thursday, September 9, 2021 3:14:15 PM<br>
<b>To:</b> Pan, Xinhui <a class="moz-txt-link-rfc2396E" href="mailto:Xinhui.Pan@amd.com"><Xinhui.Pan@amd.com></a>;
<a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>
<a class="moz-txt-link-rfc2396E" href="mailto:amd-gfx@lists.freedesktop.org"><amd-gfx@lists.freedesktop.org></a><br>
<b>Cc:</b> Deucher, Alexander
<a class="moz-txt-link-rfc2396E" href="mailto:Alexander.Deucher@amd.com"><Alexander.Deucher@amd.com></a><br>
<b>Subject:</b> Re: [PATCH 1/2] drm/amdgpu: Increase direct
IB pool size</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span
style="font-size:11pt;">
<div class="PlainText">Am 09.09.21 um 07:54 schrieb Pan,
Xinhui:<br>
> [AMD Official Use Only]<br>
><br>
> Direct IB pool is used for vce/uvd/vcn IB extra msg
too. Increase its<br>
> size to 64 pages.<br>
<br>
Do you really run into issues with that? 64 pages are
256kiB on x86 and <br>
the extra msg are maybe 2kiB.<br>
<br>
Additional to that we should probably make this a
constant independent <br>
of the CPU page size.<br>
<br>
Christian.<br>
<br>
><br>
> Signed-off-by: xinhui pan
<a class="moz-txt-link-rfc2396E" href="mailto:xinhui.pan@amd.com"><xinhui.pan@amd.com></a><br>
> ---<br>
> drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 2 +-<br>
> 1 file changed, 1 insertion(+), 1 deletion(-)<br>
><br>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c<br>
> index c076a6b9a5a2..cd2c7073fdd9 100644<br>
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c<br>
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c<br>
> @@ -308,7 +308,7 @@ int amdgpu_ib_pool_init(struct
amdgpu_device *adev)<br>
><br>
> for (i = 0; i < AMDGPU_IB_POOL_MAX;
i++) {<br>
> if (i == AMDGPU_IB_POOL_DIRECT)<br>
> - size = PAGE_SIZE * 6;<br>
> + size = PAGE_SIZE * 64;<br>
> else<br>
> size =
AMDGPU_IB_POOL_SIZE;<br>
><br>
> --<br>
> 2.25.1<br>
><br>
<br>
</div>
</span></font></div>
</div>
</blockquote>
<br>
</body>
</html>