<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="#0563C1" vlink="#954F72" style="word-wrap:break-word"> <div class="WordSection1"> <p class="msipheader9f8d35bc" style="margin:0in"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:blue">[AMD Official Use Only]</span><o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">Hi Felix,<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">After sync w/ James, we agree that this patch series could fix both our problems, and he verified this patch series will not cause regression of his previous issue. Do you have more comments regarding this patch series ? Thanks.<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">BRs,<o:p></o:p></p> <p class="MsoNormal">Yifan<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal"><b>From:</b> Zhu, James <James.Zhu@amd.com> <br> <b>Sent:</b> Wednesday, September 29, 2021 9:19 PM<br> <b>To:</b> Kuehling, Felix <Felix.Kuehling@amd.com>; Zhang, Yifan <Yifan1.Zhang@amd.com>; amd-gfx@lists.freedesktop.org<br> <b>Subject:</b> Re: [PATCH 2/2] drm/amdgpu: init iommu after amdkfd device init<o:p></o:p></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <p style="margin:5.0pt"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:blue">[AMD Official Use Only]<o:p></o:p></span></p> <p class="MsoNormal"><o:p> </o:p></p> <div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;color:black">H Felix,<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;color:black"><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;color:black">Since the previous patch can help on PCO suspend/resume hung issue. Let me work with YiFan to see if<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;color:black">there is proper way to cover both cases.<o:p></o:p></span></p> </div> <div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;color:black"><o:p> </o:p></span></p> </div> <div id="Signature"> <div> <div id="divtagdefaultwrapper"> <p><span style="font-size:12.0pt;color:black">Thanks & Best Regards!<o:p></o:p></span></p> <p><span style="font-size:12.0pt;color:black"><o:p> </o:p></span></p> <p><span style="font-size:12.0pt;color:black">James Zhu<o:p></o:p></span></p> </div> </div> </div> </div> <div class="MsoNormal" align="center" style="text-align:center"> <hr size="2" width="98%" align="center"> </div> <div id="divRplyFwdMsg"> <p class="MsoNormal"><b><span style="color:black">From:</span></b><span style="color:black"> Kuehling, Felix <<a href="mailto:Felix.Kuehling@amd.com">Felix.Kuehling@amd.com</a>><br> <b>Sent:</b> Tuesday, September 28, 2021 11:41 AM<br> <b>To:</b> Zhang, Yifan <<a href="mailto:Yifan1.Zhang@amd.com">Yifan1.Zhang@amd.com</a>>; <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <<a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>>; Zhu, James <<a href="mailto:James.Zhu@amd.com">James.Zhu@amd.com</a>><br> <b>Subject:</b> Re: [PATCH 2/2] drm/amdgpu: init iommu after amdkfd device init</span> <o:p></o:p></p> <div> <p class="MsoNormal"> <o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal">[+James]<br> <br> This basically undoes James's change "drm/amdgpu: move iommu_resume<br> before ip init/resume". I assume James made his change for a reason. Can<br> you please discuss the issue with him and determine a solution that<br> solves both your problem and his?<br> <br> If James' patch series was a mistake, I'd prefer to revert his patches,<br> because his patches complicated the initialization sequence and exposed<br> the iommu init sequence in amdgpu.<br> <br> Thanks,<br> Felix<br> <br> <br> Am 2021-09-28 um 4:28 a.m. schrieb Yifan Zhang:<br> > This patch is to fix clinfo failure in Raven/Picasso:<br> ><br> > Number of platforms: 1<br> > Platform Profile: FULL_PROFILE<br> > Platform Version: OpenCL 2.2 AMD-APP (3364.0)<br> > Platform Name: AMD Accelerated Parallel Processing<br> > Platform Vendor: Advanced Micro Devices, Inc.<br> > Platform Extensions: cl_khr_icd cl_amd_event_callback<br> ><br> > Platform Name: AMD Accelerated Parallel Processing Number of devices: 0<br> ><br> > Signed-off-by: Yifan Zhang <<a href="mailto:yifan1.zhang@amd.com">yifan1.zhang@amd.com</a>><br> > ---<br> > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 ++++----<br> > 1 file changed, 4 insertions(+), 4 deletions(-)<br> ><br> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<br> > index 4c8f2f4647c0..89ed9b091386 100644<br> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<br> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<br> > @@ -2393,10 +2393,6 @@ static int amdgpu_device_ip_init(struct amdgpu_device *adev)<br> > if (r)<br> > goto init_failed;<br> > <br> > - r = amdgpu_amdkfd_resume_iommu(adev);<br> > - if (r)<br> > - goto init_failed;<br> > -<br> > r = amdgpu_device_ip_hw_init_phase1(adev);<br> > if (r)<br> > goto init_failed;<br> > @@ -2435,6 +2431,10 @@ static int amdgpu_device_ip_init(struct amdgpu_device *adev)<br> > if (!adev->gmc.xgmi.pending_reset)<br> > amdgpu_amdkfd_device_init(adev);<br> > <br> > + r = amdgpu_amdkfd_resume_iommu(adev);<br> > + if (r)<br> > + goto init_failed;<br> > +<br> > amdgpu_fru_get_product_info(adev);<br> > <br> > init_failed:<o:p></o:p></p> </div> </div> </div> </div> </body> </html>