<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p><br>
</p>
<div class="moz-cite-prefix">On 10/13/2021 12:42 PM, Das, Nirmoy
wrote:<br>
</div>
<blockquote type="cite" cite="mid:80ecf91a-1ae3-50e8-df46-01c013a1eeb9@amd.com">
<p><br>
</p>
<div class="moz-cite-prefix">On 10/13/2021 3:22 AM, zhang wrote:<br>
</div>
<blockquote type="cite" cite="mid:2be293df-2656-c551-682e-b08955307c0b@163.com">
<p>Hi . Nirmoy</p>
<p><br>
</p>
<p>If you let continue to unpin. this will allways test a same
va for gtt </p>
<p>I think we should rafresh <span style="color: rgb(0, 0, 0);
font-family: Tahoma, Verdana, 'Lucida Sans Unicode',
sans-serif; font-size: 13px; font-style: normal;
font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; orphans: auto; text-align: start;
text-indent: 0px; text-transform: none; white-space: normal;
widows: auto; word-spacing: 0px;
-webkit-tap-highlight-color: rgba(0, 0, 0, 0.4);
-webkit-text-stroke-width: 0px; background-color: rgb(254,
253, 235); display: inline !important; float: none;"></span>calculate
the value n <br>
</p>
</blockquote>
<p><br>
</p>
<p>Right, I guess then the test should only run till gart size.</p>
</blockquote>
<p><br>
</p>
<p>Actually the test size calculation was fine, it is just that we
wouldn't release BO after a successful test as the cleanup code is
inside the test for loop.</p>
<p><br>
</p>
<p>Regards,</p>
<p>Nirmoy<br>
</p>
<blockquote type="cite" cite="mid:80ecf91a-1ae3-50e8-df46-01c013a1eeb9@amd.com">
<p><br>
</p>
<p>Regards,</p>
<p>Nirmoy<br>
</p>
<blockquote type="cite" cite="mid:2be293df-2656-c551-682e-b08955307c0b@163.com">
<p> </p>
<p><br>
</p>
<div class="moz-cite-prefix">On 2021/10/12 20:10, Nirmoy Das
wrote:<br>
</div>
<blockquote type="cite" cite="mid:20211012121018.81693-1-nirmoy.das@amd.com">
<pre class="moz-quote-pre" wrap="">When gart size is < gtt size this test will fail with
-ENOMEM as we are not freeing gtt bo after each move test.
This is generally not an issue when gart size >= gtt size.
Reported-by: zhang <a class="moz-txt-link-rfc2396E" href="mailto:botton_zhang@163.com" moz-do-not-send="true"><botton_zhang@163.com></a>
Signed-off-by: Nirmoy Das <a class="moz-txt-link-rfc2396E" href="mailto:nirmoy.das@amd.com" moz-do-not-send="true"><nirmoy.das@amd.com></a>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_test.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_test.c
index 909d830b513e..0cf2a560d673 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_test.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_test.c
@@ -212,7 +212,6 @@ static void amdgpu_do_test_moves(struct amdgpu_device *adev)
DRM_INFO("Tested GTT->VRAM and VRAM->GTT copy for GTT offset 0x%llx\n",
gart_addr - adev->gmc.gart_start);
- continue;
out_lclean_unpin:
amdgpu_bo_unpin(gtt_obj[i]);
@@ -220,6 +219,7 @@ static void amdgpu_do_test_moves(struct amdgpu_device *adev)
amdgpu_bo_unreserve(gtt_obj[i]);
out_lclean_unref:
amdgpu_bo_unref(>t_obj[i]);
+ continue;
out_lclean:
for (--i; i >= 0; --i) {
amdgpu_bo_unpin(gtt_obj[i]);
</pre>
</blockquote>
</blockquote>
</blockquote>
</body>
</html>