<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="ProgId" content="Word.Document"> <meta name="Generator" content="Microsoft Word 15"> <meta name="Originator" content="Microsoft Word 15"> <link rel="File-List" href="cid:filelist.xml@01D7C463.FB79F840"><link rel="Edit-Time-Data" href="cid:editdata.mso"><style></style> </head> <body lang="EN-US" link="#0563C1" vlink="purple" style="tab-interval:.5in;word-wrap:break-word"> <div class="WordSection1"> <p class="msipheader9f8d35bc" style="margin:0in"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:blue">[AMD Official Use Only]</span><o:p></o:p></p> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""><o:p> </o:p></span></p> <p class="MsoNormal"><span style="mso-bidi-font-family:"Times New Roman"">The * is required for the rocm-smi’s functionality for showing what the current clocks are. We had a bug before where the * was removed, then the SMI died fantastically. Work could be done to try to handle that type of situation, but the SMI has a “show current clocks” and uses the * to determine which one is active<o:p></o:p></span></p> <p class="MsoNormal"><span style="mso-bidi-font-family:"Times New Roman""><o:p> </o:p></span></p> <p class="MsoNormal"><span style="mso-bidi-font-family:"Times New Roman"">Kent<o:p></o:p></span></p> <p class="MsoNormal"><span style="mso-bidi-font-family:"Times New Roman""><o:p> </o:p></span></p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal"><b><span style="mso-fareast-font-family:"Times New Roman"">From:</span></b><span style="mso-fareast-font-family:"Times New Roman""> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> <b>On Behalf Of </b>Russell, Kent<br> <b>Sent:</b> Monday, October 18, 2021 9:05 PM<br> <b>To:</b> Tuikov, Luben <Luben.Tuikov@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Quan, Evan <Evan.Quan@amd.com>; Lazar, Lijo <Lijo.Lazar@amd.com>; amd-gfx@lists.freedesktop.org<br> <b>Cc:</b> Kasiviswanathan, Harish <Harish.Kasiviswanathan@amd.com><br> <b>Subject:</b> RE: [PATCH 0/5] 0 MHz is not a valid current frequency<o:p></o:p></span></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <p class="msipheader9f8d35bc" style="margin:0in"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:blue">[AMD Official Use Only]</span><o:p></o:p></p> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""><o:p> </o:p></span></p> <p class="MsoNormal"><span style="mso-bidi-font-family:"Times New Roman"">+Harish, rocm-smi falls under his purview now.<o:p></o:p></span></p> <p class="MsoNormal"><span style="mso-bidi-font-family:"Times New Roman""><o:p> </o:p></span></p> <p class="MsoNormal"><span style="mso-bidi-font-family:"Times New Roman"">Kent<o:p></o:p></span></p> <p class="MsoNormal"><span style="mso-bidi-font-family:"Times New Roman""><o:p> </o:p></span></p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal" style="mso-outline-level:1"><b><span style="mso-fareast-font-family:"Times New Roman"">From:</span></b><span style="mso-fareast-font-family:"Times New Roman""> Tuikov, Luben <<a href="mailto:Luben.Tuikov@amd.com">Luben.Tuikov@amd.com</a>> <br> <b>Sent:</b> Monday, October 18, 2021 4:30 PM<br> <b>To:</b> Deucher, Alexander <<a href="mailto:Alexander.Deucher@amd.com">Alexander.Deucher@amd.com</a>>; Quan, Evan <<a href="mailto:Evan.Quan@amd.com">Evan.Quan@amd.com</a>>; Lazar, Lijo <<a href="mailto:Lijo.Lazar@amd.com">Lijo.Lazar@amd.com</a>>; <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>; Russell, Kent <<a href="mailto:Kent.Russell@amd.com">Kent.Russell@amd.com</a>><br> <b>Subject:</b> Re: [PATCH 0/5] 0 MHz is not a valid current frequency<o:p></o:p></span></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman"">I think Kent is already seen these patches as he did comment on 1/5 patch.<br> <br> The v3 version of the patch, posted last week, removes the asterisk to report the lowest frequency as the current frequency, when the current frequency is 0, i.e. when the block is in low power state. Does the tool rely on the asterisk? If this information is necessary could it not use amdgpu_pm_info?<br> <br> Regards,<br> Luben<br> <br> On 2021-10-18 16:19, Deucher, Alexander wrote:<o:p></o:p></span></p> </div> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <p style="margin:15.0pt"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:green">[Public]<o:p></o:p></span></p> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""><o:p> </o:p></span></p> <div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;mso-fareast-font-family:"Times New Roman";color:black">We the current behavior (0 for clock) already crashes the tool, so I don't think we can really make things worse.<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;mso-fareast-font-family:"Times New Roman";color:black"><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;mso-fareast-font-family:"Times New Roman";color:black">Alex<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;mso-fareast-font-family:"Times New Roman";color:black"><o:p> </o:p></span></p> </div> <div class="MsoNormal" align="center" style="text-align:center"><span style="mso-fareast-font-family:"Times New Roman""> <hr size="1" width="98%" align="center"> </span></div> <div id="divRplyFwdMsg"> <p class="MsoNormal" style="mso-outline-level:1"><b><span style="mso-fareast-font-family:"Times New Roman";color:black">From:</span></b><span style="mso-fareast-font-family:"Times New Roman";color:black"> Quan, Evan <a href="mailto:Evan.Quan@amd.com"><Evan.Quan@amd.com></a><br> <b>Sent:</b> Thursday, October 14, 2021 10:25 PM<br> <b>To:</b> Lazar, Lijo <a href="mailto:Lijo.Lazar@amd.com"><Lijo.Lazar@amd.com></a>; Tuikov, Luben <a href="mailto:Luben.Tuikov@amd.com"><Luben.Tuikov@amd.com></a>; <a href="mailto:amd-gfx@lists.freedesktop.org"> amd-gfx@lists.freedesktop.org</a> <a href="mailto:amd-gfx@lists.freedesktop.org"> <amd-gfx@lists.freedesktop.org></a>; Russell, Kent <a href="mailto:Kent.Russell@amd.com"> <Kent.Russell@amd.com></a><br> <b>Cc:</b> Deucher, Alexander <a href="mailto:Alexander.Deucher@amd.com"><Alexander.Deucher@amd.com></a><br> <b>Subject:</b> RE: [PATCH 0/5] 0 MHz is not a valid current frequency</span><span style="mso-fareast-font-family:"Times New Roman""> <o:p></o:p></span></p> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> <o:p></o:p></span></p> </div> </div> <div> <div> <p class="xmsipheadera4477989" style="margin:0in"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:blue">[AMD Official Use Only]</span><o:p></o:p></p> <p class="xmsonormal"> <o:p></o:p></p> <p class="xmsonormal">+Kent who maintains the Rocm tool<o:p></o:p></p> <p class="xmsonormal"> <o:p></o:p></p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="xmsonormal" style="mso-outline-level:1"><b>From:</b> amd-gfx <a href="mailto:amd-gfx-bounces@lists.freedesktop.org"> <amd-gfx-bounces@lists.freedesktop.org></a> <b>On Behalf Of </b>Lazar, Lijo<br> <b>Sent:</b> Thursday, October 14, 2021 1:07 AM<br> <b>To:</b> Tuikov, Luben <a href="mailto:Luben.Tuikov@amd.com"><Luben.Tuikov@amd.com></a>; <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br> <b>Cc:</b> Deucher, Alexander <a href="mailto:Alexander.Deucher@amd.com"><Alexander.Deucher@amd.com></a><br> <b>Subject:</b> Re: [PATCH 0/5] 0 MHz is not a valid current frequency<o:p></o:p></p> </div> </div> <p class="xmsonormal"> <o:p></o:p></p> <p style="margin:5.0pt"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:blue">[AMD Official Use Only]</span><o:p></o:p></p> <p class="xmsonormal"> <o:p></o:p></p> <div> <p style="margin:5.0pt"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:blue">[AMD Official Use Only]</span><o:p></o:p></p> <p class="xmsonormal"> <o:p></o:p></p> <div> <div> <p class="xmsonormal" style="background:white"><span style="color:#212121">>Or maybe just a list without default hint, i.e. no asterisk?</span><o:p></o:p></p> </div> <div> <p class="xmsonormal" style="background:white"><span style="color:#212121"> </span><o:p></o:p></p> </div> <div> <p class="xmsonormal" style="background:white"><span style="color:#212121">I think this is also fine meaning we are having trouble in determining the current frequency or DPM level. Evan/Alex? Don't know if this will crash the tools.</span><o:p></o:p></p> </div> <div id="x_ms-outlook-mobile-signature"> <div> <p class="xmsonormal"> <o:p></o:p></p> </div> <p class="xmsonormal">Thanks,<br> Lijo<o:p></o:p></p> </div> <div class="MsoNormal" align="center" style="text-align:center"><span style="mso-fareast-font-family:"Times New Roman""> <hr size="1" width="98%" align="center"> </span></div> <div id="x_divRplyFwdMsg"> <p class="xmsonormal" style="mso-outline-level:1"><b><span style="color:black">From:</span></b><span style="color:black"> Tuikov, Luben <<a href="mailto:Luben.Tuikov@amd.com">Luben.Tuikov@amd.com</a>><br> <b>Sent:</b> Wednesday, October 13, 2021 9:52:09 PM<br> <b>To:</b> Lazar, Lijo <<a href="mailto:Lijo.Lazar@amd.com">Lijo.Lazar@amd.com</a>>; <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <<a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>><br> <b>Cc:</b> Deucher, Alexander <<a href="mailto:Alexander.Deucher@amd.com">Alexander.Deucher@amd.com</a>><br> <b>Subject:</b> Re: [PATCH 0/5] 0 MHz is not a valid current frequency</span> <o:p> </o:p></p> <div> <p class="xmsonormal"> <o:p></o:p></p> </div> </div> <div> <div> <p class="xmsonormal" style="margin-bottom:12.0pt">On 2021-10-13 00:14, Lazar, Lijo wrote:<br> ><br> > On 10/13/2021 8:40 AM, Luben Tuikov wrote:<br> >> Some ASIC support low-power functionality for the whole ASIC or just<br> >> an IP block. When in such low-power mode, some sysfs interfaces would<br> >> report a frequency of 0, e.g.,<br> >><br> >> $cat /sys/class/drm/card0/device/pp_dpm_sclk<br> >> 0: 500Mhz<br> >> 1: 0Mhz *<br> >> 2: 2200Mhz<br> >> $_<br> >><br> >> An operating frequency of 0 MHz doesn't make sense, and this interface<br> >> is designed to report only operating clock frequencies, i.e. non-zero,<br> >> and possibly the current one.<br> >><br> >> When in this low-power state, round to the smallest<br> >> operating frequency, for this interface, as follows,<br> >><br> > Would rather avoid this -<br> ><br> > 1) It is manipulating FW reported value. If at all there is an uncaught <br> > issue in FW reporting of frequency values, that is masked here.<br> > 2) Otherwise, if 0MHz is described as GFX power gated case, this <br> > provides a convenient interface to check if GFX is power gated.<br> ><br> > If seeing a '0' is not pleasing, consider changing to something like<br> > "NA" - not available (frequency cannot be fetched at the moment).<br> <br> There's a ROCm tool which literally asserts if the values are not ordered in increasing order. Now since 0 < 550, but 0 is listed as the second entry, the tool simply asserts and crashes.<br> <br> It is not clear what you'd rather see here:<br> <br> $cat /sys/class/drm/card0/device/pp_dpm_sclk<br> 0: 550Mhz<br> 1: N/A *<br> 2: 2200MHz<br> $_<br> <br> Is this what you want to see? (That'll crash other tools which expect %uMhz.)<br> <br> Or maybe just a list without default hint, i.e. no asterisk?<br> <br> $cat /sys/class/drm/card0/device/pp_dpm_sclk<br> 0: 550Mhz<br> 1: 2200MHz<br> $_<br> <br> What should the output be?<br> <br> We want to avoid showing 0, but still show numbers.<br> <br> Regards,<br> Luben<br> <br> ><br> > Thanks,<br> > Lijo<br> ><br> >> $cat /sys/class/drm/card0/device/pp_dpm_sclk<br> >> 0: 500Mhz *<br> >> 1: 2200Mhz<br> >> $_<br> >><br> >> Luben Tuikov (5):<br> >> drm/amd/pm: Slight function rename<br> >> drm/amd/pm: Rename cur_value to curr_value<br> >> drm/amd/pm: Rename freq_values --> freq_value<br> >> dpm/amd/pm: Sienna: 0 MHz is not a current clock frequency<br> >> dpm/amd/pm: Navi10: 0 MHz is not a current clock frequency<br> >><br> >> .../gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c | 60 +++++++++------<br> >> .../amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 73 ++++++++++++-------<br> >> 2 files changed, 86 insertions(+), 47 deletions(-)<br> >><o:p></o:p></p> </div> </div> </div> </div> </div> </div> </div> </div> </blockquote> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""><o:p> </o:p></span></p> </div> </div> </div> </body> </html>