<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body>
<p style="font-family:Arial;font-size:10pt;color:#008000;margin:15pt;" align="Left">
[Public]<br>
</p>
<br>
<div>
<div style="color: rgb(33, 33, 33); background-color: rgb(255, 255, 255);" dir="auto">
Nit pick - suggest to use dev_warn for easy identification of the device.</div>
<div id="ms-outlook-mobile-signature">
<div><br>
</div>
Thanks,<br>
Lijo</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Kent Russell <kent.russell@amd.com><br>
<b>Sent:</b> Thursday, October 21, 2021 9:27:10 PM<br>
<b>To:</b> amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Cc:</b> Russell, Kent <Kent.Russell@amd.com>; Tuikov, Luben <Luben.Tuikov@amd.com>; Joshi, Mukul <Mukul.Joshi@amd.com><br>
<b>Subject:</b> [PATCH 1/2] drm/amdgpu: Warn when bad pages approaches 90% threshold</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">dmesg doesn't warn when the number of bad pages approaches the<br>
threshold for page retirement. WARN when the number of bad pages<br>
is at 90% or greater for easier checks and planning, instead of waiting<br>
until the GPU is full of bad pages.<br>
<br>
Cc: Luben Tuikov <luben.tuikov@amd.com><br>
Cc: Mukul Joshi <Mukul.Joshi@amd.com><br>
Signed-off-by: Kent Russell <kent.russell@amd.com><br>
---<br>
drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c | 6 ++++++<br>
1 file changed, 6 insertions(+)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c<br>
index f4c05ff4b26c..ce5089216474 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c<br>
@@ -1077,6 +1077,12 @@ int amdgpu_ras_eeprom_init(struct amdgpu_ras_eeprom_control *control,<br>
if (res)<br>
DRM_ERROR("RAS table incorrect checksum or error:%d\n",<br>
res);<br>
+<br>
+ /* Warn if we are at 90% of the threshold or above */<br>
+ if ((10 * control->ras_num_recs) >= (ras->bad_page_cnt_threshold * 9))<br>
+ DRM_WARN("RAS records:%u exceeds 90%% of threshold:%d",<br>
+ control->ras_num_recs,<br>
+ ras->bad_page_cnt_threshold);<br>
} else if (hdr->header == RAS_TABLE_HDR_BAD &&<br>
amdgpu_bad_page_threshold != 0) {<br>
res = __verify_ras_table_checksum(control);<br>
-- <br>
2.25.1<br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>