<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="ProgId" content="Word.Document"> <meta name="Generator" content="Microsoft Word 15"> <meta name="Originator" content="Microsoft Word 15"> <link rel="File-List" href="cid:filelist.xml@01D7C678.2E93EAE0"><link rel="Edit-Time-Data" href="cid:editdata.mso"><style></style> </head> <body lang="EN-US" link="#0563C1" vlink="#954F72" style="tab-interval:.5in;word-wrap:break-word"> <div class="WordSection1"> [Public]<o:p></o:p> <o:p> </o:p> I had noticed that all of these RAS messages use DRM instead of dev_warn. I wasn’t sure if there was a reason for that or not. It’s definitely inconsistent.<o:p></o:p> <o:p> </o:p> DRM_ERROR("Partial read for checksum, res:%d\n", res);<o:p></o:p> DRM_DEBUG_DRIVER("Found existing EEPROM table with %d records",<o:p></o:p> DRM_ERROR("RAS table incorrect checksum or error:%d\n",<o:p></o:p> DRM_WARN("RAS records:%u exceeds 90%% of threshold:%d",<o:p></o:p> DRM_ERROR("RAS Table incorrect checksum or error:%d\n",<o:p></o:p> dev_info(adev->dev, "records:%d threshold:%d, resetting RAS table header signature",<o:p></o:p> dev_err(adev->dev, "RAS records:%d exceed threshold:%d",<o:p></o:p> dev_warn(adev->dev, "GPU will be initialized due to bad_page_threshold = -2.");<o:p></o:p> DRM_INFO("Creating a new EEPROM table");<o:p></o:p> <o:p> </o:p> Might be worth making a separate patch to handle those inconsistencies. I agree that device is useful for this kind of error/warning/info<o:p></o:p> <o:p> </o:p> Kent<o:p></o:p> <o:p> </o:p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: Lazar, Lijo <Lijo.Lazar@amd.com> Sent: Thursday, October 21, 2021 12:31 PM To: Russell, Kent <Kent.Russell@amd.com>; amd-gfx@lists.freedesktop.org Cc: Russell, Kent <Kent.Russell@amd.com>; Tuikov, Luben <Luben.Tuikov@amd.com>; Joshi, Mukul <Mukul.Joshi@amd.com> Subject: Re: [PATCH 1/2] drm/amdgpu: Warn when bad pages approaches 90% threshold<o:p></o:p> </div> </div> <o:p> </o:p> [Public]<o:p></o:p> <o:p> </o:p> <div> <div> Nit pick - suggest to use dev_warn for easy identification of the device.<o:p></o:p> </div> <div id="ms-outlook-mobile-signature"> <div> <o:p> </o:p> </div> Thanks, Lijo<o:p></o:p> </div> <div class="MsoNormal" align="center" style="text-align:center"> <hr size="1" width="98%" align="center"> </div> <div id="divRplyFwdMsg"> From: amd-gfx <<a href="mailto:amd-gfx-bounces@lists.freedesktop.org">amd-gfx-bounces@lists.freedesktop.org</a>> on behalf of Kent Russell <<a href="mailto:kent.russell@amd.com">kent.russell@amd.com</a>> Sent: Thursday, October 21, 2021 9:27:10 PM To: <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <<a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>> Cc: Russell, Kent <<a href="mailto:Kent.Russell@amd.com">Kent.Russell@amd.com</a>>; Tuikov, Luben <<a href="mailto:Luben.Tuikov@amd.com">Luben.Tuikov@amd.com</a>>; Joshi, Mukul <<a href="mailto:Mukul.Joshi@amd.com">Mukul.Joshi@amd.com</a>> Subject: [PATCH 1/2] drm/amdgpu: Warn when bad pages approaches 90% threshold <o:p></o:p> <div> <o:p></o:p> </div> </div> <div> <div> dmesg doesn't warn when the number of bad pages approaches the threshold for page retirement. WARN when the number of bad pages is at 90% or greater for easier checks and planning, instead of waiting until the GPU is full of bad pages. Cc: Luben Tuikov <<a href="mailto:luben.tuikov@amd.com">luben.tuikov@amd.com</a>> Cc: Mukul Joshi <<a href="mailto:Mukul.Joshi@amd.com">Mukul.Joshi@amd.com</a>> Signed-off-by: Kent Russell <<a href="mailto:kent.russell@amd.com">kent.russell@amd.com</a>> --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c index f4c05ff4b26c..ce5089216474 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c @@ -1077,6 +1077,12 @@ int amdgpu_ras_eeprom_init(struct amdgpu_ras_eeprom_control *control, if (res) DRM_ERROR("RAS table incorrect checksum or error:%d\n", res); + + /* Warn if we are at 90% of the threshold or above */ + if ((10 * control->ras_num_recs) >= (ras->bad_page_cnt_threshold * 9)) + DRM_WARN("RAS records:%u exceeds 90%% of threshold:%d", + control->ras_num_recs, + ras->bad_page_cnt_threshold); } else if (hdr->header == RAS_TABLE_HDR_BAD && amdgpu_bad_page_threshold != 0) { res = __verify_ras_table_checksum(control); -- 2.25.1<o:p></o:p> </div> </div> </div> </div> </div> </body> </html>