<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#0000FF;margin:5pt;" align="Left">
[AMD Official Use Only]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Thanks, will and comment as you suggested.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Regards,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Tao<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Zhang, Hawking <Hawking.Zhang@amd.com><br>
<b>Sent:</b> Monday, October 25, 2021 5:29 PM<br>
<b>To:</b> Zhou1, Tao <Tao.Zhou1@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Subject:</b> RE: [PATCH] drm/amdgpu: skip GPRs init for some CU settings on ALDEBARAN</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">[AMD Official Use Only]<br>
<br>
Please add inline comment to remind us remove this workaround later. Other than the patch is<br>
<br>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com><br>
<br>
Regards,<br>
Hawking<br>
<br>
-----Original Message-----<br>
From: Zhou1, Tao <Tao.Zhou1@amd.com> <br>
Sent: Monday, October 25, 2021 16:56<br>
To: amd-gfx@lists.freedesktop.org; Zhang, Hawking <Hawking.Zhang@amd.com><br>
Cc: Zhou1, Tao <Tao.Zhou1@amd.com><br>
Subject: [PATCH] drm/amdgpu: skip GPRs init for some CU settings on ALDEBARAN<br>
<br>
Skip GPRs init in specific condition since current GPRs init algorithm only works for some CU settings.<br>
<br>
Signed-off-by: Tao Zhou <tao.zhou1@amd.com><br>
---<br>
drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c | 4 ++++<br>
1 file changed, 4 insertions(+)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c<br>
index 00a2b36a24b3..a1f424e2ff5f 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c<br>
@@ -706,6 +706,10 @@ int gfx_v9_4_2_do_edc_gpr_workarounds(struct amdgpu_device *adev)<br>
if (!amdgpu_ras_is_supported(adev, AMDGPU_RAS_BLOCK__GFX))<br>
return 0;<br>
<br>
+ /* workaround for some CU settings, skip GPRs init */<br>
+ if (adev->gfx.cu_info.bitmap[1][1] == 0x3f7f)<br>
+ return 0;<br>
+<br>
gfx_v9_4_2_do_sgprs_init(adev);<br>
<br>
gfx_v9_4_2_do_vgprs_init(adev);<br>
-- <br>
2.17.1<br>
</div>
</span></font></div>
</div>
</body>
</html>