<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
</head>
<body>
<div style="color: rgb(33, 33, 33); background-color: rgb(255, 255, 255);" dir="auto">
There are two subsystems - powerplay and swsmu. The subsystem implementation details are hidden from amdgpu_pm funcs. I thought Alex is talking about that.</div>
<div id="ms-outlook-mobile-signature">
<div><br>
</div>
Thanks,<br>
Lijo</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Limonciello, Mario <Mario.Limonciello@amd.com><br>
<b>Sent:</b> Monday, November 1, 2021 8:16:27 AM<br>
<b>To:</b> Lazar, Lijo <Lijo.Lazar@amd.com>; Alex Deucher <alexdeucher@gmail.com><br>
<b>Cc:</b> amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>; Deucher, Alexander <Alexander.Deucher@amd.com><br>
<b>Subject:</b> RE: [PATCH] drm/amdgpu/pm: Don't show pp_power_profile_mode for YC and later APUs</font>
<div> </div>
</div>
<style>
<!--
@font-face
{font-family:"Cambria Math"}
@font-face
{font-family:Calibri}
@font-face
{font-family:"Fira Code"}
p.x_MsoNormal, li.x_MsoNormal, div.x_MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif}
span.x_EmailStyle18
{font-family:"Calibri",sans-serif;
color:windowtext}
p.x_msipheaderc10f11a2, li.x_msipheaderc10f11a2, div.x_msipheaderc10f11a2
{margin-right:0in;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif}
.x_MsoChpDefault
{font-size:10.0pt}
@page WordSection1
{margin:1.0in 1.0in 1.0in 1.0in}
div.x_WordSection1
{}
-->
</style>
<div lang="EN-US" link="#0563C1" vlink="#954F72" style="word-wrap:break-word">
<div class="x_WordSection1">
<p class="x_msipheaderc10f11a2" style="margin:0in"><span style="font-size:10.0pt; font-family:"Arial",sans-serif; color:green">[Public]</span></p>
<p class="x_MsoNormal"> </p>
<p class="x_MsoNormal">smu_get_power_profile_mode actually calls smu->ppt_funcs->get_power_profile_mode</p>
<p class="x_MsoNormal"> </p>
<p class="x_MsoNormal">So shouldn’t it be sufficient to do this?</p>
<p class="x_MsoNormal"> </p>
<p class="x_MsoNormal" style="line-height:14.25pt; background:#1E1E1E"><span style="font-size:10.5pt; font-family:"Fira Code"; color:#D4D4D4"> }
</span><span style="font-size:10.5pt; font-family:"Fira Code"; color:#C586C0">else</span><span style="font-size:10.5pt; font-family:"Fira Code"; color:#D4D4D4">
</span><span style="font-size:10.5pt; font-family:"Fira Code"; color:#C586C0">if</span><span style="font-size:10.5pt; font-family:"Fira Code"; color:#D4D4D4"> (</span><span style="font-size:10.5pt; font-family:"Fira Code"; color:#569CD6">DEVICE_ATTR_IS</span><span style="font-size:10.5pt; font-family:"Fira Code"; color:#D4D4D4">(pp_power_profile_mode))
{</span></p>
<p class="x_MsoNormal" style="line-height:14.25pt; background:#1E1E1E"><span style="font-size:10.5pt; font-family:"Fira Code"; color:#D4D4D4">
</span><span style="font-size:10.5pt; font-family:"Fira Code"; color:#C586C0">if</span><span style="font-size:10.5pt; font-family:"Fira Code"; color:#D4D4D4"> (!</span><span style="font-size:10.5pt; font-family:"Fira Code"; color:#9CDCFE">adev</span><span style="font-size:10.5pt; font-family:"Fira Code"; color:#D4D4D4">-></span><span style="font-size:10.5pt; font-family:"Fira Code"; color:#9CDCFE">smu</span><span style="font-size:10.5pt; font-family:"Fira Code"; color:#D4D4D4">.</span><span style="font-size:10.5pt; font-family:"Fira Code"; color:#9CDCFE">ppt_funcs</span><span style="font-size:10.5pt; font-family:"Fira Code"; color:#D4D4D4">-></span><span style="font-size:10.5pt; font-family:"Fira Code"; color:#9CDCFE">get_power_profile_mode</span><span style="font-size:10.5pt; font-family:"Fira Code"; color:#D4D4D4">)</span></p>
<p class="x_MsoNormal" style="line-height:14.25pt; background:#1E1E1E"><span style="font-size:10.5pt; font-family:"Fira Code"; color:#D4D4D4"> *</span><span style="font-size:10.5pt; font-family:"Fira Code"; color:#9CDCFE">states</span><span style="font-size:10.5pt; font-family:"Fira Code"; color:#D4D4D4">
= </span><span style="font-size:10.5pt; font-family:"Fira Code"; color:#4FC1FF">ATTR_STATE_UNSUPPORTED</span><span style="font-size:10.5pt; font-family:"Fira Code"; color:#D4D4D4">;</span></p>
<p class="x_MsoNormal" style="line-height:14.25pt; background:#1E1E1E"><span style="font-size:10.5pt; font-family:"Fira Code"; color:#D4D4D4"> }</span></p>
<p class="x_MsoNormal"> </p>
<p class="x_MsoNormal"> </p>
<div style="border:none; border-left:solid blue 1.5pt; padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none; border-top:solid #E1E1E1 1.0pt; padding:3.0pt 0in 0in 0in">
<p class="x_MsoNormal"><b>From:</b> Lazar, Lijo <Lijo.Lazar@amd.com> <br>
<b>Sent:</b> Saturday, October 30, 2021 10:06<br>
<b>To:</b> Alex Deucher <alexdeucher@gmail.com><br>
<b>Cc:</b> Limonciello, Mario <Mario.Limonciello@amd.com>; amd-gfx@lists.freedesktop.org; Deucher, Alexander <Alexander.Deucher@amd.com><br>
<b>Subject:</b> Re: [PATCH] drm/amdgpu/pm: Don't show pp_power_profile_mode for YC and later APUs</p>
</div>
</div>
<p class="x_MsoNormal"> </p>
<p style="margin:15.0pt"><span style="font-size:10.0pt; font-family:"Arial",sans-serif; color:green">[Public]</span></p>
<p class="x_MsoNormal"> </p>
<div>
<div>
<p class="x_MsoNormal" style="background:white"><span style="color:#212121">For swsmu, we could add a helper macro like smu_is_supported(x) that checks if ppt func is not NULL.</span></p>
</div>
<div id="x_ms-outlook-mobile-signature">
<div>
<p class="x_MsoNormal"> </p>
</div>
<p class="x_MsoNormal">Thanks,<br>
Lijo</p>
</div>
</div>
</div>
</div>
</div>
</body>
</html>