<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#0000FF;margin:5pt;" align="Left">
[AMD Official Use Only]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<span style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0); background-color: rgba(0, 0, 0, 0);">although this module parameter can be modified during driver probe, but it also can be modified at runtime.</span></div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<span style="color: rgb(0, 0, 0); font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; background-color: rgba(0, 0, 0, 0);">(via /sys/module/amdgpu/parameter/gpu_recovery).</span><br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<span style="color: rgb(0, 0, 0); font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; background-color: rgba(0, 0, 0, 0);">This may result in a mismatch with the expected results.</span><br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<span style="background-color: rgba(0, 0, 0, 0); color: rgb(0, 0, 0); font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt;">You'd better to check SRIOV in the right place.</span><br>
</div>
<span></span>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Best Regards,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Kevin</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Bokun Zhang <Bokun.Zhang@amd.com><br>
<b>Sent:</b> Saturday, November 27, 2021 8:57 AM<br>
<b>To:</b> amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Cc:</b> Zhang, Bokun <Bokun.Zhang@amd.com><br>
<b>Subject:</b> [PATCH] drm/amd/amdgpu: use advanced TDR mode by default</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="PlainText">From: Bokun Zhang <bokun.zhang@amd.com><br>
<br>
In the patch about advanced TDR mode, we force to always set<br>
amdgpu_gpu_recovery=2 under SRIOV. This is not ideal, since we<br>
may want to revert back to use the legacy TDR routine.<br>
<br>
Therefore, we only set amdgpu_gpu_recovery=2 when it is<br>
configured as AUTO, which is the default value (gpu_recovery=-1)<br>
<br>
Signed-off-by: Bokun Zhang <bokun.zhang@amd.com><br>
Change-Id: Ifae78854b53f124d2ea53f401919ab5e403ef822<br>
---<br>
drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 4 ++--<br>
1 file changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c<br>
index 93af2cd2a065..62ec484a35aa 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c<br>
@@ -64,8 +64,8 @@ void amdgpu_virt_init_setting(struct amdgpu_device *adev)<br>
adev->cg_flags = 0;<br>
adev->pg_flags = 0;<br>
<br>
- /*use advance recovery mode for SRIOV*/<br>
- if (amdgpu_gpu_recovery)<br>
+ /* use advance recovery mode for SRIOV by default */<br>
+ if (amdgpu_gpu_recovery == -1)<br>
amdgpu_gpu_recovery = 2;<br>
}<br>
<br>
-- <br>
2.25.1<br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>