<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#0000FF;margin:5pt;" align="Left">
[AMD Official Use Only]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);">
Hi Siqueira,<br>
</div>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Thanks for the heads up, lets apply Isabella's patch instead.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div id="Signature">
<div>
<div></div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
--</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Regards,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Jay<br>
</div>
</div>
</div>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com><br>
<b>Sent:</b> Wednesday, December 8, 2021 10:17 AM<br>
<b>To:</b> Pillai, Aurabindo <Aurabindo.Pillai@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>; Isabella Basso <isabbasso@riseup.net><br>
<b>Cc:</b> Wentland, Harry <Harry.Wentland@amd.com>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>; kernel test robot <lkp@intel.com><br>
<b>Subject:</b> Re: [PATCH] drm/amd/display: fix a missing prototype warning in DCN303</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText"><br>
<br>
On 2021-12-07 2:18 p.m., Aurabindo Pillai wrote:<br>
> [Why&How]<br>
> A missing include statement triggered a warning when running<br>
> a build with W=1:<br>
> <br>
>>> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn303/dcn303_init.c:30:6: warning: no previous prototype for 'dcn303_hw_sequencer_construct' [-Wmissing-prototypes]<br>
> 30 | void dcn303_hw_sequencer_construct(struct dc *dc)<br>
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br>
> <br>
> Fixes: cd6d421e3d1a (drm/amd/display: Initial DC support for Beige Goby)<br>
> Reported-by: kernel test robot <lkp@intel.com><br>
> Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com><br>
> ---<br>
> drivers/gpu/drm/amd/display/dc/dcn303/dcn303_init.c | 1 +<br>
> 1 file changed, 1 insertion(+)<br>
> <br>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn303/dcn303_init.c b/drivers/gpu/drm/amd/display/dc/dcn303/dcn303_init.c<br>
> index aa5dbbade2bd..d59b24a972bc 100644<br>
> --- a/drivers/gpu/drm/amd/display/dc/dcn303/dcn303_init.c<br>
> +++ b/drivers/gpu/drm/amd/display/dc/dcn303/dcn303_init.c<br>
> @@ -7,6 +7,7 @@<br>
> <br>
> #include "dcn303_hwseq.h"<br>
> #include "dcn30/dcn30_init.h"<br>
> +#include "dcn303_init.h"<br>
> #include "dc.h"<br>
> <br>
> void dcn303_hw_sequencer_construct(struct dc *dc)<br>
> <br>
<br>
Hi Jay,<br>
<br>
Isabella made the below patch that fixes this issue in multiple files:<br>
<br>
<a href="https://patchwork.freedesktop.org/patch/465821/?series=97701&rev=1">https://patchwork.freedesktop.org/patch/465821/?series=97701&rev=1</a><br>
<br>
Maybe we can go ahead with Isabella's patch?<br>
<br>
Thanks<br>
Siqueira<br>
</div>
</span></font></div>
</div>
</body>
</html>