<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#0000FF;margin:5pt;" align="Left">
[AMD Official Use Only]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
OK, I miss this call path.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Reviewed-by: Kevin Wang <kevinyang.wang@amd.com></div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Best Regards,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Kevin</div>
<div id="appendonsend"></div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Yu, Lang <Lang.Yu@amd.com><br>
<b>Sent:</b> Wednesday, December 8, 2021 6:58 PM<br>
<b>To:</b> Wang, Yang(Kevin) <KevinYang.Wang@amd.com><br>
<b>Cc:</b> amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>; Deucher, Alexander <Alexander.Deucher@amd.com>; Lazar, Lijo <Lijo.Lazar@amd.com>; Huang, Ray <Ray.Huang@amd.com><br>
<b>Subject:</b> Re: [PATCH 1/2] drm/amdgpu: remove power on/off SDMA in SMU hw_init/fini()</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="PlainText">On 12/08/ , Wang, Yang(Kevin) wrote:<br>
> [AMD Official Use Only]<br>
> <br>
> Hi Lang,<br>
> the function of smu_powergate_sdma() is only valid on renoir chip.<br>
> if you want to remove it, please also remove following callback pointer<br>
> in struct pptable_funcs{}.<br>
> related macro definitions also need to be cleaned up.<br>
> int (*powergate_sdma)(struct smu_context *smu, bool gate);<br>
<br>
It will be still called by amdgpu_dpm_set_powergating_by_smu()<br>
in sdma_v4_0_hw_init/fini().<br>
<br>
Regards,<br>
Lang<br>
<br>
> Best Regards,<br>
> Kevin<br>
> __________________________________________________________________<br>
> <br>
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Lang<br>
> Yu <lang.yu@amd.com><br>
> Sent: Wednesday, December 8, 2021 5:26 PM<br>
> To: amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Yu, Lang<br>
> <Lang.Yu@amd.com>; Lazar, Lijo <Lijo.Lazar@amd.com>; Huang, Ray<br>
> <Ray.Huang@amd.com><br>
> Subject: [PATCH 1/2] drm/amdgpu: remove power on/off SDMA in SMU<br>
> hw_init/fini()<br>
> <br>
> Currently, we don't find some neccesities to power on/off<br>
> SDMA in SMU hw_init/fini(). It makes more sense in SDMA<br>
> hw_init/fini().<br>
> Signed-off-by: Lang Yu <lang.yu@amd.com><br>
> ---<br>
> drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 5 -----<br>
> 1 file changed, 5 deletions(-)<br>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c<br>
> b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c<br>
> index 5839918cb574..2d718c30c8eb 100644<br>
> --- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c<br>
> +++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c<br>
> @@ -1350,7 +1350,6 @@ static int smu_hw_init(void *handle)<br>
> }<br>
> <br>
> if (smu->is_apu) {<br>
> - smu_powergate_sdma(&adev->smu, false);<br>
> smu_dpm_set_vcn_enable(smu, true);<br>
> smu_dpm_set_jpeg_enable(smu, true);<br>
> smu_set_gfx_cgpg(&adev->smu, true);<br>
> @@ -1512,10 +1511,6 @@ static int smu_hw_fini(void *handle)<br>
> if (amdgpu_sriov_vf(adev)&& !amdgpu_sriov_is_pp_one_vf(adev))<br>
> return 0;<br>
> <br>
> - if (smu->is_apu) {<br>
> - smu_powergate_sdma(&adev->smu, true);<br>
> - }<br>
> -<br>
> smu_dpm_set_vcn_enable(smu, false);<br>
> smu_dpm_set_jpeg_enable(smu, false);<br>
> <br>
> --<br>
> 2.25.1<br>
</div>
</span></font></div>
</div>
</body>
</html>