<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#008000;margin:15pt;" align="Left">
[Public]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Series is:</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Reviewed-by: Alex Deucher <alexander.deucher@amd.com><br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Mario Limonciello <mario.limonciello@amd.com><br>
<b>Sent:</b> Monday, December 13, 2021 10:08 AM<br>
<b>To:</b> amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Cc:</b> Limonciello, Mario <Mario.Limonciello@amd.com><br>
<b>Subject:</b> [PATCH v2 1/2] drm/amd/pm: fix reading SMU FW version from amdgpu_firmware_info on YC</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">This value does not get cached into adev->pm.fw_version during<br>
startup for smu13 like it does for other SMU like smu12.<br>
<br>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com><br>
---<br>
v1->v2:<br>
* Run on all v13 APU to match v12 behavior<br>
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 3 +++<br>
1 file changed, 3 insertions(+)<br>
<br>
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c<br>
index 55421ea622fb..7fdb63da1316 100644<br>
--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c<br>
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c<br>
@@ -196,6 +196,7 @@ int smu_v13_0_check_fw_status(struct smu_context *smu)<br>
<br>
int smu_v13_0_check_fw_version(struct smu_context *smu)<br>
{<br>
+ struct amdgpu_device *adev = smu->adev;<br>
uint32_t if_version = 0xff, smu_version = 0xff;<br>
uint16_t smu_major;<br>
uint8_t smu_minor, smu_debug;<br>
@@ -208,6 +209,8 @@ int smu_v13_0_check_fw_version(struct smu_context *smu)<br>
smu_major = (smu_version >> 16) & 0xffff;<br>
smu_minor = (smu_version >> 8) & 0xff;<br>
smu_debug = (smu_version >> 0) & 0xff;<br>
+ if (smu->is_apu)<br>
+ adev->pm.fw_version = smu_version;<br>
<br>
switch (smu->adev->ip_versions[MP1_HWIP][0]) {<br>
case IP_VERSION(13, 0, 2):<br>
-- <br>
2.25.1<br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>