<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#0000FF;margin:5pt;" align="Left">
[AMD Official Use Only]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
>From 06359f3be0c0b889519d6dd954fb11f31e9a15e0 Mon Sep 17 00:00:00 2001
<div>From: Marina Nikolic <Marina.Nikolic@amd.com></div>
<div>Date: Tue, 14 Dec 2021 20:57:53 +0800</div>
<div>Subject: [PATCH] amdgpu/pm: Modify sysfs pp_dpm_sclk to have only read</div>
<div> permission in ONEVF mode</div>
<div><br>
</div>
<div>== Description ==</div>
<div>Setting through sysfs should not be allowed in SRIOV mode.</div>
<div>These calls will not be processed by FW anyway,</div>
<div>but error handling on sysfs level should be improved.</div>
<div><br>
</div>
<div>== Changes ==</div>
<div>This patch prohibits performing of all set commands</div>
<div>in SRIOV mode on sysfs level.</div>
<div>It offers better error handling as calls that are</div>
<div>not allowed will not be propagated further.</div>
<div><br>
</div>
<div>== Test ==</div>
<div>Writing to any sysfs file in passthrough mode will succeed.</div>
<div>Writing to any sysfs file in ONEVF mode will yield error:</div>
<div>"calling process does not have sufficient permission to execute a command".</div>
<div><br>
</div>
<div>Signed-off-by: Marina Nikolic <Marina.Nikolic@amd.com></div>
<div>---</div>
<div> drivers/gpu/drm/amd/pm/amdgpu_pm.c | 6 ++++++</div>
<div> 1 file changed, 6 insertions(+)</div>
<div><br>
</div>
<div>diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c</div>
<div>index 082539c70fd4..c43818cd02aa 100644</div>
<div>--- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c</div>
<div>+++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c</div>
<div>@@ -2133,6 +2133,12 @@ static int default_attr_update(struct amdgpu_device *adev, struct amdgpu_device_</div>
<div> }</div>
<div> }</div>
<div><br>
</div>
<div>+ /* setting should not be allowed from VF */</div>
<div>+ if (amdgpu_sriov_vf(adev)) {</div>
<div>+ dev_attr->attr.mode &= ~S_IWUGO;</div>
<div>+ dev_attr->store = NULL;</div>
<div>+ }</div>
<div>+</div>
<div> #undef DEVICE_ATTR_IS</div>
<div><br>
</div>
<div> return 0;</div>
<div>--</div>
<div>2.20.1</div>
<span></span><br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Nikolic, Marina <Marina.Nikolic@amd.com><br>
<b>Sent:</b> Tuesday, December 21, 2021 3:15 PM<br>
<b>To:</b> Russell, Kent <Kent.Russell@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Cc:</b> Mitrovic, Milan <Milan.Mitrovic@amd.com>; Kitchen, Greg <Greg.Kitchen@amd.com><br>
<b>Subject:</b> Re: [PATCH] amdgpu/pm: Modify sysfs pp_dpm_sclk to have only read premission in ONEVF mode</font>
<div> </div>
</div>
<style type="text/css" style="display:none">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
Hi Kent, </div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
Thank you for the review. Yes, I can confirm I am trying to set this for every single file for SRIOV mode.</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<a id="OWAAM749892" class="x_J9Y1oNF3ZpoR5LC3M2PHm x_mention x_ms-bgc-nlr x_ms-fcl-b" href="mailto:Greg.Kitchen@amd.com">@Kitchen, Greg</a> required this for ROCM-SMI 5.0 release. In case you need it, he can provide more details.</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
I'm going to clarify commit message more and send a new patch.</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
BR,<br>
Marina</div>
<div id="x_appendonsend"></div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Russell, Kent <Kent.Russell@amd.com><br>
<b>Sent:</b> Monday, December 20, 2021 8:01 PM<br>
<b>To:</b> Nikolic, Marina <Marina.Nikolic@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Cc:</b> Mitrovic, Milan <Milan.Mitrovic@amd.com>; Nikolic, Marina <Marina.Nikolic@amd.com>; Kitchen, Greg <Greg.Kitchen@amd.com><br>
<b>Subject:</b> RE: [PATCH] amdgpu/pm: Modify sysfs pp_dpm_sclk to have only read premission in ONEVF mode</font>
<div> </div>
</div>
<div class="x_BodyFragment"><font face="Times New Roman" size="3"><span style="font-size:12pt"><a name="x_BM_BEGIN"></a>
<div><font size="2"><span style="font-size:11pt">[AMD Official Use Only]<br>
<br>
> -----Original Message-----<br>
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Marina Nikolic<br>
> Sent: Monday, December 20, 2021 11:09 AM<br>
> To: amd-gfx@lists.freedesktop.org<br>
> Cc: Mitrovic, Milan <Milan.Mitrovic@amd.com>; Nikolic, Marina<br>
> <Marina.Nikolic@amd.com>; Kitchen, Greg <Greg.Kitchen@amd.com><br>
> Subject: [PATCH] amdgpu/pm: Modify sysfs pp_dpm_sclk to have only read premission in<br>
> ONEVF mode<br>
><br>
> == Description ==<br>
> Due to security reasons setting through sysfs<br>
> should only be allowed in passthrough mode.<br>
> Options that are not mapped as SMU messages<br>
> do not have any mechanizm to distinguish between<br>
> passthorugh, onevf and mutivf usecase.<br>
> A unified approach is needed.<br>
><br>
> == Changes ==<br>
> This patch introduces a new mechanizm to distinguish<br>
> ONEVF and PASSTHROUGH use case on sysfs level<br>
> and prohibit setting (writting to sysfs).<br>
> It also applies the new mechanizm on pp_dpm_sclk sysfs file.<br>
><br>
> == Test ==<br>
> Writing to pp_dpm_sclk sysfs file in passthrough mode will succeed.<br>
> Writing to pp_dpm_sclk sysfs file in ONEVF mode will yield error:<br>
> "calling process does not have sufficient permission to execute a command".<br>
> Sysfs pp_dpm_sclk will not be created in MULTIVF mode.<br>
><br>
> Signed-off-by: Marina Nikolic <Marina.Nikolic@amd.com><br>
> ---<br>
> drivers/gpu/drm/amd/pm/amdgpu_pm.c | 6 ++++++<br>
> 1 file changed, 6 insertions(+)<br>
><br>
> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c<br>
> b/drivers/gpu/drm/amd/pm/amdgpu_pm.c<br>
> index 082539c70fd4..d2b168babc7d 100644<br>
> --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c<br>
> +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c<br>
> @@ -2133,6 +2133,12 @@ static int default_attr_update(struct amdgpu_device *adev,<br>
> struct amdgpu_device_<br>
> }<br>
> }<br>
><br>
> + /* security: setting should not be allowed from VF */<br>
> + if (amdgpu_sriov_vf(adev)) {<br>
<br>
You should be checking for pp_dpm_sclk here, for example:<br>
if (DEVICE_ATTR_IS(pp_dpm_sclk) {<br>
<br>
Otherwise I am pretty sure you're setting this for every single file. And is it only sclk? Or does it also need to affect mclk/fclk/etc? If it's only sclk, the line above should help. If it's for more, then the commit should try to clarify that as it's not
100% clear.<br>
<br>
Kent<br>
<br>
> + dev_attr->attr.mode &= ~S_IWUGO;<br>
> + dev_attr->store = NULL;<br>
> + }<br>
> +<br>
> #undef DEVICE_ATTR_IS<br>
><br>
> return 0;<br>
> --<br>
> 2.20.1<br>
<br>
</span></font></div>
</span></font></div>
</div>
</div>
</body>
</html>