<html><head></head><body><div class="ydp1f3498a4yahoo-style-wrap" style="font-family:Helvetica Neue, Helvetica, Arial, sans-serif;font-size:13px;" dir="ltr" data-setdir="false"><div></div><div dir="ltr" data-setdir="false"><span>Hi Hsin-Yi,</span></div><div dir="ltr" data-setdir="false"><span><br></span></div><div dir="ltr" data-setdir="false"><span>The issue still exists. </span>I reverted <span>a19f75de73c220b4496d2aefb7a605dd032f7c01 (the commit that reverted <span>5a7b95fb993ec399c8a685552aa6a8fc995c40bd</span>)</span> and manually applied the patch (tags/v5.16).<span> journalctl attached.<br></span></div><div dir="ltr" data-setdir="false"><span><br></span></div><div dir="ltr" data-setdir="false"><span>Regards,</span></div><div dir="ltr" data-setdir="false"><span><br></span></div><div dir="ltr" data-setdir="false"><span>Tareque<br></span></div><div><br></div> </div><div id="yahoo_quoted_2817576657" class="yahoo_quoted"> <div style="font-family:'Helvetica Neue', Helvetica, Arial, sans-serif;font-size:13px;color:#26282a;"> <div> On Saturday, January 15, 2022, 11:27:07 PM GMT+6, Hsin-Yi Wang <hsinyi@chromium.org> wrote: </div> <div><br></div> <div><br></div> <div><div dir="ltr">hi Tareque,<br clear="none"><br clear="none"><div class="yqt7209235154" id="yqtfd88008"><br clear="none">On Fri, Jan 14, 2022 at 6:09 PM Tareque Md Hanif<br clear="none"><<a shape="rect" ymailto="mailto:tarequemd.hanif@yahoo.com" href="mailto:tarequemd.hanif@yahoo.com">tarequemd.hanif@yahoo.com</a>> wrote:<br clear="none">><br clear="none">> Hi Hsin-Yi,<br clear="none">><br clear="none">> On 1/12/22 16:58, Hsin-Yi Wang wrote:<br clear="none">><br clear="none">> Can you help provide logs if we apply<br clear="none">> 5a7b95fb993ec399c8a685552aa6a8fc995c40bd but revert<br clear="none">> 8d35a2596164c1c9d34d4656fd42b445cd1e247f?<br clear="none">><br clear="none">> Issue still exists. journalctl log attached in revert_8d.txt<br clear="none">><br clear="none">><br clear="none">> > after apply 5a7b95fb993ec399c8a685552aa6a8fc995c40bd<br clear="none">> > 1. delete SET_LATE_SYSTEM_SLEEP_PM_OPS(i2c_suspend_late,<br clear="none">> > i2c_resume_early) and function i2c_suspend_late() and<br clear="none">> > i2c_resume_early().<br clear="none">><br clear="none">> No issues. journalctl log attached in test1.txt<br clear="none">><br clear="none">><br clear="none">> > 2. delete SET_RUNTIME_PM_OPS(i2c_runtime_suspend, i2c_runtime_resume,<br clear="none">> > NULL) and function i2c_runtime_suspend() and i2c_runtime_resume().<br clear="none">><br clear="none">> Issue exists. journalctl log attached in test2.txt</div><br clear="none"><br clear="none">Thanks for the testing.<br clear="none">Can you help us test if applying the following patch on top of<br clear="none">5a7b95fb993ec399c8a685552aa6a8fc995c40bd works? Thanks<br clear="none"><br clear="none">diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c<br clear="none">index 9eb4009cb250..6b046012aa08 100644<br clear="none">--- a/drivers/i2c/i2c-core-base.c<br clear="none">+++ b/drivers/i2c/i2c-core-base.c<br clear="none">@@ -484,7 +484,7 @@ static int i2c_resume_early(struct device *dev)<br clear="none"> struct i2c_client *client = i2c_verify_client(dev);<br clear="none"> int err;<br clear="none"><br clear="none">- if (!client)<br clear="none">+ if (!client || dev_pm_skip_resume(dev))<br clear="none"> return 0;<br clear="none"><br clear="none"> if (pm_runtime_status_suspended(&client->dev) &&<br clear="none">@@ -502,7 +502,7 @@ static int i2c_suspend_late(struct device *dev)<br clear="none"> struct i2c_client *client = i2c_verify_client(dev);<br clear="none"> int err;<br clear="none"><br clear="none">- if (!client)<br clear="none">+ if (!client || dev_pm_skip_suspend(dev))<br clear="none"> return 0;<br clear="none"><br clear="none"> err = pm_generic_suspend_late(&client->dev);<div class="yqt7209235154" id="yqtfd94730"><br clear="none"></div></div></div> </div> </div></body></html>