<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p>:)))))</p>
<p>I am like - I must be crazy because no way this works but you
insist that it is and I know u are usually right.</p>
<p>Andrey<br>
</p>
<div class="moz-cite-prefix">On 2022-03-07 10:59, Christian König
wrote:<br>
</div>
<blockquote type="cite" cite="mid:dd6839eb-da19-30fd-1422-6b0aba326e7f@amd.com">
<blockquote type="cite" cite="mid:6174d4b6-7a02-ffef-ce68-ca2f13dae337@amd.com">
<blockquote type="cite" cite="mid:5c573f4d-0fa8-5c01-67fe-c33a79a6f89c@gmail.com"> <br>
If we don't check for NULL here we would just crash. <br>
</blockquote>
<p><br>
</p>
<p>But you go into the 'if clause' if job->gang_submit is
equal to NULL, i would expect to see here<br>
if (!fence &&<b> job->gang_submit</b>) because you
want to switch to an actual new gang (not to NULL)<br>
</p>
</blockquote>
<br>
WTF? I'm like 100% that I've fixed that before sending it out.<br>
<br>
Thanks for point it out, but yeah I've already stumbled over that
typo as well.<br>
<br>
Christian.<br>
<br>
<blockquote type="cite" cite="mid:6174d4b6-7a02-ffef-ce68-ca2f13dae337@amd.com">
<p> </p>
<p>Andrey</p>
<p><br>
</p>
<blockquote type="cite" cite="mid:5c573f4d-0fa8-5c01-67fe-c33a79a6f89c@gmail.com"> <br>
Christian. <br>
</blockquote>
<blockquote type="cite" cite="mid:5c573f4d-0fa8-5c01-67fe-c33a79a6f89c@gmail.com"> </blockquote>
</blockquote>
</blockquote>
</body>
</html>