<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#0000FF;margin:5pt;" align="Left">
[AMD Official Use Only]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Thank you very much Alex!</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Regards,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Rico</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Alex Deucher <alexdeucher@gmail.com><br>
<b>Sent:</b> Friday, March 11, 2022 0:52<br>
<b>To:</b> Yin, Tianci (Rico) <Tianci.Yin@amd.com><br>
<b>Cc:</b> amd-gfx list <amd-gfx@lists.freedesktop.org>; Chen, Guchun <Guchun.Chen@amd.com>; Zhuo, Qingqing (Lillian) <Qingqing.Zhuo@amd.com>; Liu, Wenjing <Wenjing.Liu@amd.com>; Wang, Yu (Charlie) <Yu.Wang4@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com>;
Quan, Evan <Evan.Quan@amd.com><br>
<b>Subject:</b> Re: [PATCH] drm/amd: fix gfx hang on renoir in IGT reload test</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">On Thu, Mar 10, 2022 at 9:04 AM Tianci Yin <tianci.yin@amd.com> wrote:<br>
><br>
> From: "Tianci.Yin" <tianci.yin@amd.com><br>
><br>
> [why]<br>
> CP hangs in igt reloading test on renoir, more precisely, hangs on the<br>
> second time insmod.<br>
><br>
> [how]<br>
> mode2 reset can make it recover, and mode2 reset only effects gfx core,<br>
> dcn and the screen will not be impacted.<br>
><br>
> Signed-off-by: Tianci.Yin <tianci.yin@amd.com><br>
> ---<br>
> drivers/gpu/drm/amd/amdgpu/soc15.c | 5 +++++<br>
> 1 file changed, 5 insertions(+)<br>
><br>
> diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c b/drivers/gpu/drm/amd/amdgpu/soc15.c<br>
> index 496c4a6e23ac..f0713c027ed5 100644<br>
> --- a/drivers/gpu/drm/amd/amdgpu/soc15.c<br>
> +++ b/drivers/gpu/drm/amd/amdgpu/soc15.c<br>
> @@ -853,6 +853,11 @@ static bool soc15_need_reset_on_init(struct amdgpu_device *adev)<br>
> {<br>
> u32 sol_reg;<br>
><br>
> + /* CP hangs in IGT reloading test on RN, reset to WA */<br>
> + if(adev->asic_type == CHIP_RENOIR) {<br>
<br>
Space between if and (. Also, you can drop the { }. With that fixed:<br>
Acked-by: Alex Deucher <alexander.deucher@amd.com><br>
<br>
Alex<br>
<br>
<br>
> + return true;<br>
> + }<br>
> +<br>
> /* Just return false for soc15 GPUs. Reset does not seem to<br>
> * be necessary.<br>
> */<br>
> --<br>
> 2.25.1<br>
><br>
</div>
</span></font></div>
</div>
</body>
</html>