<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="ProgId" content="Word.Document"> <meta name="Generator" content="Microsoft Word 15"> <meta name="Originator" content="Microsoft Word 15"> <link rel="File-List" href="cid:filelist.xml@01D8428D.B28F7E40"><link rel="Edit-Time-Data" href="cid:editdata.mso"><style></style> </head> <body lang="EN-US" link="#0563C1" vlink="#954F72" style="tab-interval:.5in;word-wrap:break-word"> <p style="font-family:Arial;font-size:10pt;color:#008000;margin:15pt;" align="Left"> [Public]<br> </p> <br> <div> <div class="WordSection1"> <p class="MsoNormal"><span style="mso-ascii-font-family:Calibri;mso-hansi-font-family:Calibri;mso-bidi-font-family:"Times New Roman"">Thanks Alex. Sending out a 3<sup>rd</sup> version shortly with a couple style fixes due to rebasing onto <span class="SpellE">Lijo’s</span> work.<o:p></o:p></span></p> <p class="MsoNormal"><span style="mso-ascii-font-family:Calibri;mso-hansi-font-family:Calibri;mso-bidi-font-family:"Times New Roman""><o:p> </o:p></span></p> <p class="MsoNormal"><span style="mso-ascii-font-family:Calibri;mso-hansi-font-family:Calibri;mso-bidi-font-family:"Times New Roman"">Kent<o:p></o:p></span></p> <p class="MsoNormal"><span style="mso-ascii-font-family:Calibri;mso-hansi-font-family:Calibri;mso-bidi-font-family:"Times New Roman""><o:p> </o:p></span></p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal"><b><span style="mso-fareast-font-family:"Times New Roman"">From:</span></b><span style="mso-fareast-font-family:"Times New Roman""> Deucher, Alexander <Alexander.Deucher@amd.com> <br> <b>Sent:</b> Monday, March 28, 2022 9:45 AM<br> <b>To:</b> Russell, Kent <Kent.Russell@amd.com>; amd-gfx@lists.freedesktop.org<br> <b>Subject:</b> Re: [PATCH 1/2] drm/amdgpu: Change unique_id to use IP_VERSION<o:p></o:p></span></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <p style="margin:15.0pt"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:green">[Public]<o:p></o:p></span></p> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""><o:p> </o:p></span></p> <div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;mso-fareast-font-family:"Times New Roman";color:black">Series is:<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;mso-fareast-font-family:"Times New Roman";color:black">Reviewed-by: Alex Deucher <<a href="mailto:alexander.deucher@amd.com">alexander.deucher@amd.com</a>><o:p></o:p></span></p> </div> <div class="MsoNormal" align="center" style="text-align:center"><span style="mso-fareast-font-family:"Times New Roman""> <hr size="2" width="98%" align="center"> </span></div> <div id="divRplyFwdMsg"> <p class="MsoNormal" style="mso-outline-level:1"><b><span style="mso-fareast-font-family:"Times New Roman";color:black">From:</span></b><span style="mso-fareast-font-family:"Times New Roman";color:black"> amd-gfx <<a href="mailto:amd-gfx-bounces@lists.freedesktop.org">amd-gfx-bounces@lists.freedesktop.org</a>> on behalf of Kent Russell <<a href="mailto:kent.russell@amd.com">kent.russell@amd.com</a>><br> <b>Sent:</b> Monday, March 28, 2022 9:06 AM<br> <b>To:</b> <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <<a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>><br> <b>Cc:</b> Russell, Kent <<a href="mailto:Kent.Russell@amd.com">Kent.Russell@amd.com</a>><br> <b>Subject:</b> [PATCH 1/2] drm/amdgpu: Change unique_id to use IP_VERSION</span><span style="mso-fareast-font-family:"Times New Roman""> <o:p></o:p></span></p> <div> <p class="MsoNormal"><span style="mso-fareast-font-family:"Times New Roman""> <o:p></o:p></span></p> </div> </div> <div> <div> <p class="MsoNormal" style="margin-bottom:12.0pt"><span style="mso-fareast-font-family:"Times New Roman"">This is transitioning throughout amdgpu, so we may as well get it<br> started now. This also cleans up the logic on what IP_VERSIONs do or<br> don't support unique_id.<br> <br> Signed-off-by: Kent Russell <<a href="mailto:kent.russell@amd.com">kent.russell@amd.com</a>><br> ---<br> drivers/gpu/drm/amd/pm/amdgpu_pm.c | 12 ++++++++----<br> 1 file changed, 8 insertions(+), 4 deletions(-)<br> <br> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c<br> index 5cd67ddf8495..a5216c0f5c2b 100644<br> --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c<br> +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c<br> @@ -1987,11 +1987,15 @@ static int default_attr_update(struct amdgpu_device *adev, struct amdgpu_device_<br> if (adev->flags & AMD_IS_APU)<br> *states = ATTR_STATE_UNSUPPORTED;<br> } else if (DEVICE_ATTR_IS(unique_id)) {<br> - if (asic_type != CHIP_VEGA10 &&<br> - asic_type != CHIP_VEGA20 &&<br> - asic_type != CHIP_ARCTURUS &&<br> - asic_type != CHIP_ALDEBARAN)<br> + switch (adev->ip_versions[GC_HWIP][0]) {<br> + case IP_VERSION(9, 0, 1):<br> + case IP_VERSION(9, 4, 0):<br> + case IP_VERSION(9, 4, 1):<br> + case IP_VERSION(9, 4, 2):<br> + *states = ATTR_STATE_SUPPORTED;<br> + default:<br> *states = ATTR_STATE_UNSUPPORTED;<br> + }<br> } else if (DEVICE_ATTR_IS(pp_features)) {<br> if (adev->flags & AMD_IS_APU || asic_type < CHIP_VEGA10)<br> *states = ATTR_STATE_UNSUPPORTED;<br> -- <br> 2.25.1<o:p></o:p></span></p> </div> </div> </div> </div> </div> </div> </body> </html>