<html><head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> </head> <body> <div class="moz-cite-prefix">On 2022-04-04 15:46, Tomasz Moń wrote: </div> <blockquote type="cite" cite="mid:b90412bbea1439a614badede2450316099dd08e6.camel@gmail.com"> <pre class="moz-quote-pre" wrap="">On Mon, 2022-04-04 at 15:18 -0400, Alex Deucher wrote: </pre> <blockquote type="cite"> <pre class="moz-quote-pre" wrap="">On Mon, Apr 4, 2022 at 3:03 PM Tomasz Moń <a class="moz-txt-link-rfc2396E" href="mailto:desowin@gmail.com"><desowin@gmail.com></a> wrote: </pre> <blockquote type="cite"> <pre class="moz-quote-pre" wrap="">On top of what commit does this work? It does not apply at top of v5.18-rc1. </pre> </blockquote> <pre class="moz-quote-pre" wrap=""> This is stuff for drm-next (<a class="moz-txt-link-freetext" href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2Fagd5f%2Flinux%2F-%2Fcommits%2Fdrm-next&data=04%7C01%7CPhilip.Yang%40amd.com%7C7ecebd09a0af4734337608da1673c38d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637846984292244281%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=uNP0Qmv%2BI25FAY0UVMIJ5BM9CiPSMwbmylEMCXkTJac%3D&reserved=0">https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2Fagd5f%2Flinux%2F-%2Fcommits%2Fdrm-next&data=04%7C01%7CPhilip.Yang%40amd.com%7C7ecebd09a0af4734337608da1673c38d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637846984292244281%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=uNP0Qmv%2BI25FAY0UVMIJ5BM9CiPSMwbmylEMCXkTJac%3D&reserved=0</a>). E.g., 5.19. </pre> </blockquote> <pre class="moz-quote-pre" wrap=""> This does not compile on current drm-next, just like I noted in the next paragraph of my email. </pre> <blockquote type="cite"> <blockquote type="cite"> <pre class="moz-quote-pre" wrap="">It does apply, but fails to compile, on top of "drm/amdkfd: Create file descriptor after client is added to smi_clients list" that is commit: * cbe879c87245ce6272afe6456dbc8ce2c8f38d64 in amd-staging-drm- next * e45422695c196dbc665a95526c85ff4b8752aff2 in drm-next fetched from <a class="moz-txt-link-freetext" href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2Fagd5f%2Flinux.git&data=04%7C01%7CPhilip.Yang%40amd.com%7C7ecebd09a0af4734337608da1673c38d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637846984292244281%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=XoXSbmW4oME2qfbBR%2F%2ByTfyoRpL6Ro6C%2BRYekQcQaHk%3D&reserved=0">https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2Fagd5f%2Flinux.git&data=04%7C01%7CPhilip.Yang%40amd.com%7C7ecebd09a0af4734337608da1673c38d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637846984292244281%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=XoXSbmW4oME2qfbBR%2F%2ByTfyoRpL6Ro6C%2BRYekQcQaHk%3D&reserved=0</a> The compile error is due to flush_tlb being undeclared. </pre> </blockquote> </blockquote> <pre class="moz-quote-pre" wrap=""> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c: In function ‘amdgpu_vm_bo_update_mapping’: drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:845:9: error: ‘flush_tlb’ undeclared (first use in this function); did you mean ‘kfd_flush_tlb’? 845 | flush_tlb |= (adev->gmc.xgmi.num_physical_nodes && | ^~~~~~~~~ | kfd_flush_tlb drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:845:9: note: each undeclared identifier is reported only once for each function it appears in </pre> </blockquote> This must be applied after patch "drm/amdgpu: fix TLB flushing during eviction", which adds local variable flush_tlb. Regards, Philip <blockquote type="cite" cite="mid:b90412bbea1439a614badede2450316099dd08e6.camel@gmail.com"> <pre class="moz-quote-pre" wrap=""> Best Regards, Tomasz Mon </pre> </blockquote> </body> </html>