<div dir="ltr"><div>A better name would be:</div><div>AMDGPU_VM_PAGE_BYPASS_MALL</div><div><br></div><div>Marek<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, May 6, 2022 at 7:23 AM Christian König <<a href="mailto:ckoenig.leichtzumerken@gmail.com">ckoenig.leichtzumerken@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Add the AMDGPU_VM_NOALLOC flag to let userspace control MALL allocation.<br>
<br>
Only compile tested!<br>
<br>
Signed-off-by: Christian König <<a href="mailto:christian.koenig@amd.com" target="_blank">christian.koenig@amd.com</a>><br>
---<br>
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 2 ++<br>
drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 3 +++<br>
drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c | 3 +++<br>
include/uapi/drm/amdgpu_drm.h | 2 ++<br>
4 files changed, 10 insertions(+)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c<br>
index bf97d8f07f57..d8129626581f 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c<br>
@@ -650,6 +650,8 @@ uint64_t amdgpu_gem_va_map_flags(struct amdgpu_device *adev, uint32_t flags)<br>
pte_flag |= AMDGPU_PTE_WRITEABLE;<br>
if (flags & AMDGPU_VM_PAGE_PRT)<br>
pte_flag |= AMDGPU_PTE_PRT;<br>
+ if (flags & AMDGPU_VM_PAGE_NOALLOC)<br>
+ pte_flag |= AMDGPU_PTE_NOALLOC;<br>
<br>
if (adev->gmc.gmc_funcs->map_mtype)<br>
pte_flag |= amdgpu_gmc_map_mtype(adev,<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c<br>
index b8c79789e1e4..9077dfccaf3c 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c<br>
@@ -613,6 +613,9 @@ static void gmc_v10_0_get_vm_pte(struct amdgpu_device *adev,<br>
*flags &= ~AMDGPU_PTE_MTYPE_NV10_MASK;<br>
*flags |= (mapping->flags & AMDGPU_PTE_MTYPE_NV10_MASK);<br>
<br>
+ *flags &= ~AMDGPU_PTE_NOALLOC;<br>
+ *flags |= (mapping->flags & AMDGPU_PTE_NOALLOC);<br>
+<br>
if (mapping->flags & AMDGPU_PTE_PRT) {<br>
*flags |= AMDGPU_PTE_PRT;<br>
*flags |= AMDGPU_PTE_SNOOPED;<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c<br>
index 8d733eeac556..32ee56adb602 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c<br>
@@ -508,6 +508,9 @@ static void gmc_v11_0_get_vm_pte(struct amdgpu_device *adev,<br>
*flags &= ~AMDGPU_PTE_MTYPE_NV10_MASK;<br>
*flags |= (mapping->flags & AMDGPU_PTE_MTYPE_NV10_MASK);<br>
<br>
+ *flags &= ~AMDGPU_PTE_NOALLOC;<br>
+ *flags |= (mapping->flags & AMDGPU_PTE_NOALLOC);<br>
+<br>
if (mapping->flags & AMDGPU_PTE_PRT) {<br>
*flags |= AMDGPU_PTE_PRT;<br>
*flags |= AMDGPU_PTE_SNOOPED;<br>
diff --git a/include/uapi/drm/amdgpu_drm.h b/include/uapi/drm/amdgpu_drm.h<br>
index 57b9d8f0133a..9d71d6330687 100644<br>
--- a/include/uapi/drm/amdgpu_drm.h<br>
+++ b/include/uapi/drm/amdgpu_drm.h<br>
@@ -533,6 +533,8 @@ struct drm_amdgpu_gem_op {<br>
#define AMDGPU_VM_MTYPE_UC (4 << 5)<br>
/* Use Read Write MTYPE instead of default MTYPE */<br>
#define AMDGPU_VM_MTYPE_RW (5 << 5)<br>
+/* don't allocate MALL */<br>
+#define AMDGPU_VM_PAGE_NOALLOC (1 << 9)<br>
<br>
struct drm_amdgpu_gem_va {<br>
/** GEM object handle */<br>
-- <br>
2.25.1<br>
<br>
</blockquote></div>