<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=Windows-1252"> </head> <body> <p style="font-family:Arial;font-size:10pt;color:#008000;margin:15pt;" align="Left"> [Public]<br> </p> <br> <div> <div style="color: rgb(33, 33, 33); background-color: rgb(255, 255, 255);" dir="auto"> Ya, second is too lengthy. Better to leave it as it is.</div> <div style="color: rgb(33, 33, 33); background-color: rgb(255, 255, 255);" dir="auto"> <br> </div> <div style="color: rgb(33, 33, 33); background-color: rgb(255, 255, 255);" dir="auto"> BTW, is this specific to reset by BACO? BACO entry/exit may take longer (better chance of suspend entry abort by some wake-up source).</div> <div id="ms-outlook-mobile-signature" dir="auto"> <div><br> </div> Thanks,<br> Lijo</div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Limonciello, Mario <Mario.Limonciello@amd.com><br> <b>Sent:</b> Tuesday, May 17, 2022 10:00:16 PM<br> <b>To:</b> Lazar, Lijo <Lijo.Lazar@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br> <b>Subject:</b> RE: [PATCH] drm/amd: Don't reset dGPUs if the system is going to s2idle</font> <div> </div> </div> <style>  </style> <div lang="EN-US" link="#0563C1" vlink="#954F72" style="word-wrap:break-word"> <div class="x_WordSection1"> <p class="x_msipheaderc10f11a2" style="margin:0in"><span style="font-size:10.0pt; font-family:"Arial",sans-serif; color:green">[Public]</span></p> <p class="x_MsoNormal"> </p> <p class="x_MsoNormal" style="background:white"><span style="color:black">></span><span style="color:#212121"> PM_SUSPEND_TO_IDLE should be under a compile guard</span></p> <p class="x_MsoNormal"> </p> <p class="x_MsoNormal">It is actually. All of the amdgpu_acpi_* are. It’s not obvious though looking at the patch, you need to apply it to notice it.</p> <p class="x_MsoNormal"> </p> <p class="x_MsoNormal" style="background:white"><span style="color:black">></span><span style="color:#212121"> It makes sense to rename to something like amdgpu_need_reset_on_suspend() as it decides on reset only for a suspend situation.</span></p> <p class="x_MsoNormal"> </p> <p class="x_MsoNormal">Remember it’s in amdgpu_acpi.c. So it would be amdgpu_acpi_need_reset_on_suspend()? It’s a bit lengthy.</p> <p class="x_MsoNormal"> </p> <div style="border:none; border-left:solid blue 1.5pt; padding:0in 0in 0in 4.0pt"> <div> <div style="border:none; border-top:solid #E1E1E1 1.0pt; padding:3.0pt 0in 0in 0in"> <p class="x_MsoNormal"><b>From:</b> Lazar, Lijo <Lijo.Lazar@amd.com> <br> <b>Sent:</b> Tuesday, May 17, 2022 11:25<br> <b>To:</b> Limonciello, Mario <Mario.Limonciello@amd.com>; amd-gfx@lists.freedesktop.org<br> <b>Cc:</b> Limonciello, Mario <Mario.Limonciello@amd.com><br> <b>Subject:</b> Re: [PATCH] drm/amd: Don't reset dGPUs if the system is going to s2idle</p> </div> </div> <p class="x_MsoNormal"> </p> <p style="margin:15.0pt"><span style="font-size:10.0pt; font-family:"Arial",sans-serif; color:green">[Public]</span></p> <p class="x_MsoNormal"> </p> <div> <div> <p class="x_MsoNormal" style="background:white"><span style="color:#212121">A couple of things -</span></p> </div> <div> <p class="x_MsoNormal" style="background:white"><span style="color:#212121"> </span></p> </div> <div> <p class="x_MsoNormal" style="background:white"><span style="color:#212121">PM_SUSPEND_TO_IDLE should be under a compile guard</span></p> </div> <div> <p class="x_MsoNormal" style="background:white"><span style="color:#212121"> </span></p> </div> <div> <p class="x_MsoNormal" style="background:white"><span style="color:#212121">It makes sense to rename to something like amdgpu_need_reset_on_suspend() as it decides on reset only for a suspend situation.</span></p> </div> <div id="x_ms-outlook-mobile-signature"> <div> <p class="x_MsoNormal"> </p> </div> <p class="x_MsoNormal">Thanks,<br> Lijo</p> </div> </div> </div> </div> </div> </div> </body> </html>