<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#008000;margin:15pt;" align="Left">
[Public]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
Series is:</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
Reviewed-by: Alex Deucher <alexander.deucher@amd.com><br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Quan, Evan <Evan.Quan@amd.com><br>
<b>Sent:</b> Tuesday, August 9, 2022 11:21 PM<br>
<b>To:</b> amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Cc:</b> Zhang, Hawking <Hawking.Zhang@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Quan, Evan <Evan.Quan@amd.com><br>
<b>Subject:</b> [PATCH 3/3] drm/amd/pm: add missing ->fini_xxxx interfaces for some SMU13 asics</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Without these, potential memory leak may be induced.<br>
<br>
Signed-off-by: Evan Quan <evan.quan@amd.com><br>
Change-Id: Ied7cd204d44d739dece11774c9d29e7a192fd341<br>
---<br>
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 2 ++<br>
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 2 ++<br>
2 files changed, 4 insertions(+)<br>
<br>
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c<br>
index 1bbeceeb9e3c..df4a47acd724 100644<br>
--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c<br>
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c<br>
@@ -1792,7 +1792,9 @@ static const struct pptable_funcs smu_v13_0_0_ppt_funcs = {<br>
.dump_pptable = smu_v13_0_0_dump_pptable,<br>
.init_microcode = smu_v13_0_init_microcode,<br>
.load_microcode = smu_v13_0_load_microcode,<br>
+ .fini_microcode = smu_v13_0_fini_microcode,<br>
.init_smc_tables = smu_v13_0_0_init_smc_tables,<br>
+ .fini_smc_tables = smu_v13_0_fini_smc_tables,<br>
.init_power = smu_v13_0_init_power,<br>
.fini_power = smu_v13_0_fini_power,<br>
.check_fw_status = smu_v13_0_check_fw_status,<br>
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c<br>
index 9dd56e73218b..d78375d9a141 100644<br>
--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c<br>
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c<br>
@@ -1574,7 +1574,9 @@ static const struct pptable_funcs smu_v13_0_7_ppt_funcs = {<br>
.dump_pptable = smu_v13_0_7_dump_pptable,<br>
.init_microcode = smu_v13_0_init_microcode,<br>
.load_microcode = smu_v13_0_load_microcode,<br>
+ .fini_microcode = smu_v13_0_fini_microcode,<br>
.init_smc_tables = smu_v13_0_7_init_smc_tables,<br>
+ .fini_smc_tables = smu_v13_0_fini_smc_tables,<br>
.init_power = smu_v13_0_init_power,<br>
.fini_power = smu_v13_0_fini_power,<br>
.check_fw_status = smu_v13_0_7_check_fw_status,<br>
-- <br>
2.29.0<br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>