<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#008000;margin:15pt;" align="Left">
[Public]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
Acked-by: Alex Deucher <alexander.deucher@amd.com><br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Mahfooz, Hamza <Hamza.Mahfooz@amd.com><br>
<b>Sent:</b> Thursday, September 1, 2022 10:15 AM<br>
<b>To:</b> linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org><br>
<b>Cc:</b> Mahfooz, Hamza <Hamza.Mahfooz@amd.com>; Wentland, Harry <Harry.Wentland@amd.com>; Li, Sun peng (Leo) <Sunpeng.Li@amd.com>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>;
Pan, Xinhui <Xinhui.Pan@amd.com>; David Airlie <airlied@linux.ie>; Daniel Vetter <daniel@ffwll.ch>; Kazlauskas, Nicholas <Nicholas.Kazlauskas@amd.com>; Lei, Jun <Jun.Lei@amd.com>; Somasundaram, Meenakshikumar <Meenakshikumar.Somasundaram@amd.com>; Lee, Alvin
<Alvin.Lee2@amd.com>; Leung, Martin <Martin.Leung@amd.com>; Tam, Samson <Samson.Tam@amd.com>; Hung, Alex <Alex.Hung@amd.com>; Liu, Wenjing <Wenjing.Liu@amd.com>; Aberback, Joshua <Joshua.Aberback@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>;
dri-devel@lists.freedesktop.org <dri-devel@lists.freedesktop.org><br>
<b>Subject:</b> [PATCH v2] drm/amd/display: fix indentation in commit_planes_for_stream()</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Address the following warning:<br>
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3508:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]<br>
3508 | if (update_type != UPDATE_TYPE_FAST)<br>
| ^~<br>
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3510:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’<br>
3510 | if (update_type != UPDATE_TYPE_FAST)<br>
| ^~<br>
<br>
Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com><br>
---<br>
v2: implement feedback from Alvin<br>
---<br>
drivers/gpu/drm/amd/display/dc/core/dc.c | 7 ++++---<br>
1 file changed, 4 insertions(+), 3 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c<br>
index b49237390cce..9860bf38c547 100644<br>
--- a/drivers/gpu/drm/amd/display/dc/core/dc.c<br>
+++ b/drivers/gpu/drm/amd/display/dc/core/dc.c<br>
@@ -3507,9 +3507,10 @@ static void commit_planes_for_stream(struct dc *dc,<br>
<br>
if (update_type != UPDATE_TYPE_FAST)<br>
dc->hwss.post_unlock_program_front_end(dc, context);<br>
- if (update_type != UPDATE_TYPE_FAST)<br>
- if (dc->hwss.commit_subvp_config)<br>
- dc->hwss.commit_subvp_config(dc, context);<br>
+<br>
+ if (update_type != UPDATE_TYPE_FAST)<br>
+ if (dc->hwss.commit_subvp_config)<br>
+ dc->hwss.commit_subvp_config(dc, context);<br>
<br>
/* Since phantom pipe programming is moved to post_unlock_program_front_end,<br>
* move the SubVP lock to after the phantom pipes have been setup<br>
-- <br>
2.37.2<br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>