<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#008000;margin:15pt;" align="Left">
[Public]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
Yeah, seems to be a mix. I don't have a strong opinion as long as it has MIT.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
Alex</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Kuehling, Felix <Felix.Kuehling@amd.com><br>
<b>Sent:</b> Tuesday, September 6, 2022 9:46 AM<br>
<b>To:</b> Jingyu Wang <jingyuwang_vip@163.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; Pan, Xinhui <Xinhui.Pan@amd.com>; airlied@linux.ie <airlied@linux.ie>; daniel@ffwll.ch <daniel@ffwll.ch><br>
<b>Cc:</b> amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>; dri-devel@lists.freedesktop.org <dri-devel@lists.freedesktop.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org><br>
<b>Subject:</b> Re: [PATCH] drm/amdgpu: cleanup coding style in amdgpu_amdkfd_gpuvm.c</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText"><br>
Am 2022-09-05 um 04:38 schrieb Jingyu Wang:<br>
> Fix everything checkpatch.pl complained about in amdgpu_amdkfd_gpuvm.c<br>
><br>
> Signed-off-by: Jingyu Wang <jingyuwang_vip@163.com><br>
> ---<br>
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 4 +++-<br>
> 1 file changed, 3 insertions(+), 1 deletion(-)<br>
><br>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c<br>
> index cbd593f7d553..eff596c60c89 100644<br>
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c<br>
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c<br>
> @@ -1,3 +1,4 @@<br>
> +// SPDX-License-Identifier: MIT<br>
<br>
I'm not sure if this is correct. We've used "GPL-2.0 OR MIT" in KFD. In <br>
amdgpu there is currently a mix of licenses. Alex, do you want to make a <br>
call on a consistent one to use in amdgpu?<br>
<br>
Other than that, this patch is<br>
<br>
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com><br>
<br>
<br>
> /*<br>
> * Copyright 2014-2018 Advanced Micro Devices, Inc.<br>
> *<br>
> @@ -1612,6 +1613,7 @@ size_t amdgpu_amdkfd_get_available_memory(struct amdgpu_device *adev)<br>
> uint64_t reserved_for_pt =<br>
> ESTIMATE_PT_SIZE(amdgpu_amdkfd_total_mem_size);<br>
> size_t available;<br>
> +<br>
> spin_lock(&kfd_mem_limit.mem_limit_lock);<br>
> available = adev->gmc.real_vram_size<br>
> - adev->kfd.vram_used_aligned<br>
> @@ -2216,7 +2218,7 @@ int amdgpu_amdkfd_gpuvm_get_vm_fault_info(struct amdgpu_device *adev,<br>
> {<br>
> if (atomic_read(&adev->gmc.vm_fault_info_updated) == 1) {<br>
> *mem = *adev->gmc.vm_fault_info;<br>
> - mb();<br>
> + mb(); /* make sure read happened */<br>
> atomic_set(&adev->gmc.vm_fault_info_updated, 0);<br>
> }<br>
> return 0;<br>
><br>
> base-commit: e47eb90a0a9ae20b82635b9b99a8d0979b757ad8<br>
</div>
</span></font></div>
</div>
</body>
</html>