<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple" style="word-wrap:break-word"> <div class="WordSection1"> <p class="msipheaderc10f11a2" style="margin:0in"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:green">[Public]</span><o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">Thanks Alex and Yury.<o:p></o:p></p> <p class="MsoNormal">The changes seem reasonable to me. Feel free to add my RB: Reviewed-by: Evan Quan <evan.quan@amd.com><o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">BR<o:p></o:p></p> <p class="MsoNormal">Evan<o:p></o:p></p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal"><b>From:</b> Deucher, Alexander <Alexander.Deucher@amd.com> <br> <b>Sent:</b> Tuesday, September 6, 2022 11:05 PM<br> <b>To:</b> Yury Zhuravlev <stalkerg@gmail.com>; amd-gfx@lists.freedesktop.org; Quan, Evan <Evan.Quan@amd.com>; Feng, Kenneth <Kenneth.Feng@amd.com><br> <b>Subject:</b> Re: [PATCH] drm/amdgpu: getting fan speed pwm for vega10 properly<o:p></o:p></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <p style="margin:15.0pt"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:green">[Public]<o:p></o:p></span></p> <p class="MsoNormal"><o:p> </o:p></p> <div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;color:black"><a id="OWAAM804280" href="mailto:Evan.Quan@amd.com"><span style="font-family:"Calibri",sans-serif;text-decoration:none">@Quan, Evan</span></a>, <a id="OWAAM423795" href="mailto:Kenneth.Feng@amd.com"><span style="font-family:"Calibri",sans-serif;text-decoration:none">@Feng, Kenneth</span></a> can you take a look?<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;color:black"><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;color:black">Thanks,<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;color:black"><o:p> </o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;color:black">Alex<o:p></o:p></span></p> </div> <div class="MsoNormal" align="center" style="text-align:center"> <hr size="2" width="98%" align="center"> </div> <div id="divRplyFwdMsg"> <p class="MsoNormal"><b><span style="color:black">From:</span></b><span style="color:black"> amd-gfx <<a href="mailto:amd-gfx-bounces@lists.freedesktop.org">amd-gfx-bounces@lists.freedesktop.org</a>> on behalf of Yury Zhuravlev <<a href="mailto:stalkerg@gmail.com">stalkerg@gmail.com</a>><br> <b>Sent:</b> Friday, September 2, 2022 1:24 PM<br> <b>To:</b> <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <<a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>><br> <b>Subject:</b> [PATCH] drm/amdgpu: getting fan speed pwm for vega10 properly</span> <o:p></o:p></p> <div> <p class="MsoNormal"> <o:p></o:p></p> </div> </div> <div> <div> <div> <p class="MsoNormal">Hello,<br> <br> During the setup, the fan manager <a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmarkusressel%2Ffan2go&data=05%7C01%7Calexander.deucher%40amd.com%7C0903d6788f924045996108da8d086ecb%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637977365572428876%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=IOJR10xHaW9cUZ%2Fv0Q%2BZDFFQJ1pbv2dUKP0zpxK4s8M%3D&reserved=0" target="_blank"> https://github.com/markusressel/fan2go</a> I found that my Vega56 was not working correctly. This fan manager expects what read PWM value should be the same as you wrote before, but it's not the case. PWM value was volatile, and what is more critical, if I wrote 200, after reading I saw ~70-100, which is very confusing. <br> After that, I started reading the amdgpu driver, and how fan speed works, and I found what PWM value was calculated from RPM speed and not correct for my case (different BIOS or fan configuration?).<br> Because it looked wrong, I started looking into different implementations and found that Vega20 used mmCG_FDO_CTRL1 and mmCG_THERMAL_STATUS registers to calculate the PWM value.<br> I also checked how we set PWM for Vega10 and found the same registers. After that, I copy-pasted the function from Vega20 to Vega10, and it started working much better. It still has some fluctuation, but as I understand, this behavior is expected. <br> <br> I have no in-depth information about amdgpu, and the original function may have been for some reason (maybe for some broken BIOS?), but I suppose somebody forgot to backport this code after prototype implementation. <br> <br> It would be my first patch here. Sorry if I skipped some procedures, will be appreciated it if you help me. <o:p></o:p></p> </div> <p class="MsoNormal">Also, sorry for the patch in the attachment, I have not been using any mail programs for the last six years, only web clients, and it's strange to do it nowadays (PRs much more common...). <o:p></o:p></p> <div> <p class="MsoNormal"><br> Regards,<o:p></o:p></p> </div> </div> </div> </div> </div> </div> </body> </html>