<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#008000;margin:15pt;" align="Left">
[Public]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
Acked-by: Alex Deucher <alexander.deucher@amd.com><br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Yifan Zhang <yifan1.zhang@amd.com><br>
<b>Sent:</b> Friday, September 16, 2022 12:38 AM<br>
<b>To:</b> amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Cc:</b> Deucher, Alexander <Alexander.Deucher@amd.com>; Huang, Tim <Tim.Huang@amd.com>; Du, Xiaojian <Xiaojian.Du@amd.com>; Zhang, Yifan <Yifan1.Zhang@amd.com><br>
<b>Subject:</b> [PATCH] drm/amdgpu: add MES and MES-KIQ version in debugfs</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">This patch addes MES and MES-KIQ version in debugfs.<br>
<br>
Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com><br>
---<br>
 drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 24 ++++++++++++++++++++++++<br>
 include/uapi/drm/amdgpu_drm.h           |  4 ++++<br>
 2 files changed, 28 insertions(+)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c<br>
index 1369c25448dc..bb0ed358909f 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c<br>
@@ -328,6 +328,14 @@ static int amdgpu_firmware_info(struct drm_amdgpu_info_firmware *fw_info,<br>
                 fw_info->ver = adev->psp.cap_fw_version;<br>
                 fw_info->feature = adev->psp.cap_feature_version;<br>
                 break;<br>
+       case AMDGPU_INFO_FW_MES_KIQ:<br>
+               fw_info->ver = adev->mes.ucode_fw_version[0];<br>
+               fw_info->feature = 0;<br>
+               break;<br>
+       case AMDGPU_INFO_FW_MES:<br>
+               fw_info->ver = adev->mes.ucode_fw_version[1];<br>
+               fw_info->feature = 0;<br>
+               break;<br>
         default:<br>
                 return -EINVAL;<br>
         }<br>
@@ -1581,6 +1589,22 @@ static int amdgpu_debugfs_firmware_info_show(struct seq_file *m, void *unused)<br>
                                 fw_info.feature, fw_info.ver);<br>
         }<br>
 <br>
+       /* MES_KIQ */<br>
+       query_fw.fw_type = AMDGPU_INFO_FW_MES_KIQ;<br>
+       ret = amdgpu_firmware_info(&fw_info, &query_fw, adev);<br>
+       if (ret)<br>
+               return ret;<br>
+       seq_printf(m, "MES_KIQ feature version: %u, firmware version: 0x%08x\n",<br>
+                  fw_info.feature, fw_info.ver);<br>
+<br>
+       /* MES */<br>
+       query_fw.fw_type = AMDGPU_INFO_FW_MES;<br>
+       ret = amdgpu_firmware_info(&fw_info, &query_fw, adev);<br>
+       if (ret)<br>
+               return ret;<br>
+       seq_printf(m, "MES feature version: %u, firmware version: 0x%08x\n",<br>
+                  fw_info.feature, fw_info.ver);<br>
+<br>
         seq_printf(m, "VBIOS version: %s\n", ctx->vbios_version);<br>
 <br>
         return 0;<br>
diff --git a/include/uapi/drm/amdgpu_drm.h b/include/uapi/drm/amdgpu_drm.h<br>
index c2c9c674a223..12fdf62730b8 100644<br>
--- a/include/uapi/drm/amdgpu_drm.h<br>
+++ b/include/uapi/drm/amdgpu_drm.h<br>
@@ -755,6 +755,10 @@ struct drm_amdgpu_cs_chunk_data {<br>
         #define AMDGPU_INFO_FW_TOC              0x15<br>
         /* Subquery id: Query CAP firmware version */<br>
         #define AMDGPU_INFO_FW_CAP              0x16<br>
+       /* Subquery id: Query MES_KIQ firmware version */<br>
+       #define AMDGPU_INFO_FW_MES_KIQ          0x17<br>
+       /* Subquery id: Query MES firmware version */<br>
+       #define AMDGPU_INFO_FW_MES              0x18<br>
 <br>
 /* number of bytes moved for TTM migration */<br>
 #define AMDGPU_INFO_NUM_BYTES_MOVED             0x0f<br>
-- <br>
2.37.3<br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>