<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p><br>
</p>
<div class="moz-cite-prefix">On 9/30/2022 6:59 PM, Harry Wentland
wrote:<br>
</div>
<blockquote type="cite" cite="mid:184d25c2-7af5-8a89-94bd-117c71c4c3fc@amd.com">
<pre class="moz-quote-pre" wrap="">+Leo
On 9/30/22 06:27, Shirish S wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">[Why]
psr feature continues to be enabled for non capable links.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Do you have more info on what issues you're seeing with this? </pre>
</blockquote>
<p>Code wise without this change we end up setting "<span style="color: rgb(0, 0, 0); font-family: "Source Code Pro", monospace; font-size: 13.3333px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; white-space: pre; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255); text-decoration-thickness: initial; text-decoration-style: initial; text-decoration-color: initial; display: inline !important; float: none;">vblank_disable_immediate" </span>parameter
to false for the failing links also.</p>
<p>Issue wise there is a remote chance of this leading to
eDP/connected monitor not lighting up.<br>
</p>
<blockquote type="cite" cite="mid:184d25c2-7af5-8a89-94bd-117c71c4c3fc@amd.com">
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">[How]
disable the feature on links that are not capable of the same.
Signed-off-by: Shirish S <a class="moz-txt-link-rfc2396E" href="mailto:shirish.s@amd.com"><shirish.s@amd.com></a>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
index 8ca10ab3dfc1..f73af028f312 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
@@ -60,11 +60,17 @@ static bool link_supports_psrsu(struct dc_link *link)
*/
void amdgpu_dm_set_psr_caps(struct dc_link *link)
{
- if (!(link->connector_signal & SIGNAL_TYPE_EDP))
+ if (!(link->connector_signal & SIGNAL_TYPE_EDP)) {
+ DRM_ERROR("Disabling PSR as connector is not eDP\n")
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
I don't think we should log an error here.</pre>
</blockquote>
<p>My objective of logging an error was to inform user/developer
that this boot PSR enablement had issues.</p>
<p>Am fine with moving it to INFO or remove it, if you insist.</p>
<p>Thanks for your comments.<br>
</p>
<p>Regards,</p>
<p>Shirish S<br>
</p>
<blockquote type="cite" cite="mid:184d25c2-7af5-8a89-94bd-117c71c4c3fc@amd.com">
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">+ link->psr_settings.psr_feature_enabled = false;
return;
+ }
- if (link->type == dc_connection_none)
+ if (link->type == dc_connection_none) {
+ DRM_ERROR("Disabling PSR as eDP connection type is invalid\n")
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Same here, this doesn't warrant an error log.
Harry
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">+ link->psr_settings.psr_feature_enabled = false;
return;
+ }
if (link->dpcd_caps.psr_info.psr_version == 0) {
link->psr_settings.psr_version = DC_PSR_VERSION_UNSUPPORTED;
</pre>
</blockquote>
</blockquote>
</body>
</html>