<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> </head> <body> Am 28.10.22 um 17:09 schrieb Nathan Chancellor: <blockquote type="cite" cite="mid:Y1vwk3J3HPGugBJO@dev-arch.thelio-3990X"> <pre class="moz-quote-pre" wrap="">Additionally, I see the following errors with GCC 12.2.1 from Fedora when building allmodconfig. Seems like some $(dml_rcflags) might be missing. drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c: In function ‘dcn10_resource_construct_fp’: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c:1313:52: error: ‘-mgeneral-regs-only’ is incompatible with the use of floating-point types 1313 | dcn_soc->dram_clock_change_latency = 23; | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c:1317:45: error: ‘-mgeneral-regs-only’ is incompatible with the use of floating-point types 1317 | dc->dcn_soc->urgent_latency = 3; | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c:1319:64: error: ‘-mgeneral-regs-only’ is incompatible with the use of floating-point types 1319 | dc->dcn_soc->fabric_and_dram_bandwidth_vmax0p9 = 41.60f; | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c:1329:64: error: ‘-mgeneral-regs-only’ is incompatible with the use of floating-point types 1329 | dc->dcn_soc->fabric_and_dram_bandwidth_vmax0p9 = 19.2f; | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c:1330:64: error: ‘-mgeneral-regs-only’ is incompatible with the use of floating-point types 1330 | dc->dcn_soc->fabric_and_dram_bandwidth_vnom0p8 = 17.066f; | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c:1331:65: error: ‘-mgeneral-regs-only’ is incompatible with the use of floating-point types 1331 | dc->dcn_soc->fabric_and_dram_bandwidth_vmid0p72 = 14.933f; | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c:1332:65: error: ‘-mgeneral-regs-only’ is incompatible with the use of floating-point types 1332 | dc->dcn_soc->fabric_and_dram_bandwidth_vmin0p65 = 12.8f; | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c:1334:72: error: ‘-mgeneral-regs-only’ is incompatible with the use of floating-point types 1334 | dc->dcn_soc->fabric_and_dram_bandwidth_vmax0p9 = 20.80f; | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~ make[6]: *** [scripts/Makefile.build:250: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.o] Error 1 drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_resource.c: In function ‘dcn32_populate_dml_pipes_from_context’: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_resource.c:1921:70: error: ‘-mgeneral-regs-only’ is incompatible with the use of floating-point types 1921 | pipes[pipe_cnt].pipe.src.dcc_fraction_of_zs_req_luma = 0; | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_resource.c:1922:72: error: ‘-mgeneral-regs-only’ is incompatible with the use of floating-point types 1922 | pipes[pipe_cnt].pipe.src.dcc_fraction_of_zs_req_chroma = 0; | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ make[6]: *** [scripts/Makefile.build:250: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_resource.o] Error 1</pre> </blockquote> Hi Nathan, it seems like you haven't merged my patch to isolate the remaining FPU code. Links: <a class="moz-txt-link-freetext" href="https://patchwork.freedesktop.org/patch/508813/">https://patchwork.freedesktop.org/patch/508813/</a> Links: <a class="moz-txt-link-freetext" href="https://patchwork.freedesktop.org/patch/508816/">https://patchwork.freedesktop.org/patch/508816/</a> Rodrigo says both patches have been applied, but I haven't seen them in the amd-staging-drm-next branch. This error occurs because the remaining FPU code in dcn10_resource.c has not been isolated. Ao </body> </html>