<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
Feel free to add my rb on this and push it to amd-staging-drm-next.<br>
<br>
Christian.<br>
<br>
<div class="moz-cite-prefix">Am 09.03.23 um 17:02 schrieb Marek
Olšák:<br>
</div>
<blockquote type="cite"
cite="mid:CAAxE2A6uh5z0i=g1yFXid509Mo0OkJJ-2N_23wqfn2XTRJAr5g@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">Ping<br>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Thu, Feb 23, 2023 at
1:46 PM Marek Olšák <<a href="mailto:maraeo@gmail.com"
moz-do-not-send="true" class="moz-txt-link-freetext">maraeo@gmail.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div>Updated patch attached.</div>
<div><br>
</div>
<div>Marek<br>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Mon, Feb 6, 2023 at
4:05 AM Christian König <<a
href="mailto:ckoenig.leichtzumerken@gmail.com"
target="_blank" moz-do-not-send="true"
class="moz-txt-link-freetext">ckoenig.leichtzumerken@gmail.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">Just two nit picks:<br>
<br>
+ seq_printf(m, "drm-evicted-visible-vram:\t%llu
KiB\n",<br>
+ stats.evicted_visible_vram/1024UL);<br>
<br>
For the values not standardized for all DRM drivers we
might want to use <br>
amd as prefix here instead of drm.<br>
<br>
+ uint64_t requested_gtt; /* how much userspace
asked for */<br>
<br>
We used to have automated checkers complaining about
comments after members.<br>
<br>
Kerneldoc complicent comments look like this:<br>
<br>
/* @timestamp replaced by @rcu on
dma_fence_release() */<br>
struct rcu_head rcu;<br>
<br>
Apart from that looks good to me.<br>
<br>
Regards,<br>
Christian.<br>
<br>
Am 30.01.23 um 07:56 schrieb Marek Olšák:<br>
> Hi,<br>
><br>
> This will be used for performance investigations. The
patch is attached.<br>
><br>
> Thanks,<br>
> Marek<br>
<br>
</blockquote>
</div>
</blockquote>
</div>
</blockquote>
<br>
</body>
</html>