<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#0000FF;margin:5pt;" align="Left">
[AMD Official Use Only - General]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class="elementToProof ContentPasted0">
Reviewed-by: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com><br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Aurabindo Pillai <aurabindo.pillai@amd.com><br>
<b>Sent:</b> March 10, 2023 12:48 PM<br>
<b>To:</b> amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Cc:</b> Wentland, Harry <Harry.Wentland@amd.com>; Pillai, Aurabindo <Aurabindo.Pillai@amd.com>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>; Mahfooz, Hamza <Hamza.Mahfooz@amd.com><br>
<b>Subject:</b> [PATCH 1/2] drm/amd/display: Add missing description to DMCUB definitions</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">[Why&How]<br>
Provides description for some enums used by DMCUB<br>
<br>
Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com><br>
---<br>
 drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 5 ++++-<br>
 1 file changed, 4 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h<br>
index 734b34902fa7..4f67124d8e68 100644<br>
--- a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h<br>
+++ b/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h<br>
@@ -717,7 +717,7 @@ enum dmub_cmd_type {<br>
          */<br>
         DMUB_CMD__PANEL_CNTL = 74,<br>
         /**<br>
-        * Command type used for <TODO:description><br>
+        * Command type used for all CAB commands.<br>
          */<br>
         DMUB_CMD__CAB_FOR_SS = 75,<br>
 <br>
@@ -997,6 +997,9 @@ struct dmub_rb_cmd_cab_for_ss {<br>
         uint8_t debug_bits;     /* debug bits */<br>
 };<br>
 <br>
+/**<br>
+ * Enum for indicating which MCLK switch mode per pipe<br>
+ */<br>
 enum mclk_switch_mode {<br>
         NONE = 0,<br>
         FPO = 1,<br>
-- <br>
2.39.2<br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>