<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body>
<p style="font-family:Arial;font-size:10pt;color:#0000FF;margin:5pt;" align="Left">
[AMD Official Use Only - General]<br>
</p>
<br>
<div>
<div style="" dir="auto">I recall that there was a previous discussion around this and that time we found that the range is already set earlier during DPM enablement.</div>
<div style="" dir="auto"><br>
</div>
<div style="" dir="auto">The suspected root cause was enable/disable of thermal alert within this call to set range again.</div>
<div id="ms-outlook-mobile-signature" dir="auto">
<div><br>
</div>
Thanks,<br>
Lijo</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Alex Deucher <alexdeucher@gmail.com><br>
<b>Sent:</b> Friday, March 10, 2023 8:51:06 PM<br>
<b>To:</b> Chen, Guchun <Guchun.Chen@amd.com><br>
<b>Cc:</b> David Airlie <airlied@linux.ie>; Pan, Xinhui <Xinhui.Pan@amd.com>; Zhenneng Li <lizhenneng@kylinos.cn>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>; dri-devel@lists.freedesktop.org
<dri-devel@lists.freedesktop.org>; Daniel Vetter <daniel@ffwll.ch>; Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com><br>
<b>Subject:</b> Re: [PATCH] drm/amdgpu: resove reboot exception for si oland</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">On Fri, Mar 10, 2023 at 3:18 AM Chen, Guchun <Guchun.Chen@amd.com> wrote:<br>
><br>
><br>
> > -----Original Message-----<br>
> > From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of<br>
> > Zhenneng Li<br>
> > Sent: Friday, March 10, 2023 3:40 PM<br>
> > To: Deucher, Alexander <Alexander.Deucher@amd.com><br>
> > Cc: David Airlie <airlied@linux.ie>; Pan, Xinhui <Xinhui.Pan@amd.com>;<br>
> > linux-kernel@vger.kernel.org; dri-devel@lists.freedesktop.org; Zhenneng Li<br>
> > <lizhenneng@kylinos.cn>; amd-gfx@lists.freedesktop.org; Daniel Vetter<br>
> > <daniel@ffwll.ch>; Koenig, Christian <Christian.Koenig@amd.com><br>
> > Subject: [PATCH] drm/amdgpu: resove reboot exception for si oland<br>
> ><br>
> > During reboot test on arm64 platform, it may failure on boot.<br>
> ><br>
> > The error message are as follows:<br>
> > [ 6.996395][ 7] [ T295] [drm:amdgpu_device_ip_late_init [amdgpu]]<br>
> > *ERROR*<br>
> > late_init of IP block <si_dpm> failed -22<br>
> > [ 7.006919][ 7] [ T295] amdgpu 0000:04:00.0: amdgpu_device_ip_late_init<br>
> > failed<br>
> > [ 7.014224][ 7] [ T295] amdgpu 0000:04:00.0: Fatal error during GPU init<br>
> > ---<br>
> > drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c | 3 ---<br>
> > 1 file changed, 3 deletions(-)<br>
> ><br>
> > diff --git a/drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c<br>
> > b/drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c<br>
> > index d6d9e3b1b2c0..dee51c757ac0 100644<br>
> > --- a/drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c<br>
> > +++ b/drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c<br>
> > @@ -7632,9 +7632,6 @@ static int si_dpm_late_init(void *handle)<br>
> > if (!adev->pm.dpm_enabled)<br>
> > return 0;<br>
> ><br>
> > - ret = si_set_temperature_range(adev);<br>
> > - if (ret)<br>
> > - return ret;<br>
><br>
> si_set_temperature_range should be platform agnostic. Can you please elaborate more?<br>
><br>
<br>
Yes. Not setting this means we won't get thermal interrupts. We<br>
shouldn't skip this.<br>
<br>
Alex<br>
<br>
<br>
> Regards,<br>
> Guchun<br>
><br>
> > #if 0 //TODO ?<br>
> > si_dpm_powergate_uvd(adev, true);<br>
> > #endif<br>
> > --<br>
> > 2.25.1<br>
><br>
</div>
</span></font></div>
</div>
</body>
</html>