<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-GB" link="blue" vlink="purple" style="word-wrap:break-word"> <div class="WordSection1"> <p class="msipheaderdf3d92d6" style="margin:0cm"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:blue">[AMD Official Use Only - General]</span><o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal"><span style="mso-fareast-language:EN-US">From the exposed workload hints:<o:p></o:p></span></p> <p class="MsoNormal">+#define AMDGPU_CTX_WORKLOAD_HINT_NONE<br> +#define AMDGPU_CTX_WORKLOAD_HINT_3D<br> +#define AMDGPU_CTX_WORKLOAD_HINT_VIDEO <br> +#define AMDGPU_CTX_WORKLOAD_HINT_VR<br> +#define AMDGPU_CTX_WORKLOAD_HINT_COMPUTE <span style="mso-fareast-language:EN-US"><o:p></o:p></span></p> <p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p> <p class="MsoNormal"><span style="mso-fareast-language:EN-US">I guess the only option which we do not know how to use is HINT_VR, everything else is known. I find it a limitation of the stack that we can’t differentiate between a VR workload Vs 3D, coz at some time we might have to give high privilege or special attention to it when VR becomes more demanding, but for now, I can remove this one option from the patch:<o:p></o:p></span></p> <p class="MsoNormal"><span style="mso-fareast-language:EN-US"> <o:p></o:p></span></p> <p class="MsoNormal" style="margin-bottom:12.0pt">+#define AMDGPU_CTX_WORKLOAD_HINT_VR<span style="mso-fareast-language:EN-US"><o:p></o:p></span></p> <p class="MsoNormal"><span style="mso-fareast-language:EN-US">Regards<o:p></o:p></span></p> <p class="MsoNormal"><span style="mso-fareast-language:EN-US">Shashank <o:p></o:p></span></p> <p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm"> <p class="MsoNormal"><b><span lang="EN-US">From:</span></b><span lang="EN-US"> Koenig, Christian <Christian.Koenig@amd.com> <br> <b>Sent:</b> 22 March 2023 15:29<br> <b>To:</b> Marek Olšák <maraeo@gmail.com><br> <b>Cc:</b> Christian König <ckoenig.leichtzumerken@gmail.com>; Sharma, Shashank <Shashank.Sharma@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Somalapuram, Amaranath <Amaranath.Somalapuram@amd.com>; amd-gfx@lists.freedesktop.org<br> <b>Subject:</b> Re: [PATCH v3 1/5] drm/amdgpu: add UAPI for workload hints to ctx ioctl<o:p></o:p></span></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal" style="margin-bottom:12.0pt">Well that sounds like being able to optionally set it after context creation is actually the right approach.<br> <br> VA-API could set it as soon as we know that this is a video codec application.<br> <br> Vulkan can set it depending on what features are used by the application.<br> <br> But yes, Shashank (or whoever requested that) should come up with some code for Mesa to actually use it. Otherwise we don't have the justification to push it into the kernel driver.<br> <br> Christian.<o:p></o:p></p> <div> <p class="MsoNormal">Am 22.03.23 um 15:24 schrieb Marek Olšák:<o:p></o:p></p> </div> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <div> <div> <p class="MsoNormal">The hint is static per API (one of graphics, video, compute, unknown). In the case of Vulkan, which exposes all queues, the hint is unknown, so Vulkan won't use it. (or make it based on the queue being used and not the uapi context state) GL won't use it because the default hint is already 3D. That makes VAAPI the only user that only sets the hint once, and maybe it's not worth even adding this uapi just for VAAPI.<o:p></o:p></p> </div> <div> <p class="MsoNormal"><o:p> </o:p></p> </div> <div> <p class="MsoNormal">Marek<o:p></o:p></p> </div> <p class="MsoNormal"><o:p> </o:p></p> <div> <div> <p class="MsoNormal">On Wed, Mar 22, 2023 at 10:08 AM Christian König <<a href="mailto:christian.koenig@amd.com">christian.koenig@amd.com</a>> wrote:<o:p></o:p></p> </div> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0cm;margin-bottom:5.0pt"> <div> <p class="MsoNormal" style="margin-bottom:12.0pt">Well completely agree that we shouldn't have unused API. That's why I said we should remove the getting the hint from the UAPI.<br> <br> But what's wrong with setting it after creating the context? Don't you know enough about the use case? I need to understand the background a bit better here.<br> <br> Christian.<o:p></o:p></p> <div> <p class="MsoNormal">Am 22.03.23 um 15:05 schrieb Marek Olšák:<o:p></o:p></p> </div> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <div> <div> <p class="MsoNormal">The option to change the hint after context creation and get the hint would be unused uapi, and AFAIK we are not supposed to add unused uapi. What I asked is to change it to a uapi that userspace will actually use.<o:p></o:p></p> </div> <div> <p class="MsoNormal"><o:p> </o:p></p> </div> <div> <p class="MsoNormal">Marek<o:p></o:p></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <div> <div> <p class="MsoNormal">On Tue, Mar 21, 2023 at 9:54 AM Christian König <<a href="mailto:ckoenig.leichtzumerken@gmail.com" target="_blank">ckoenig.leichtzumerken@gmail.com</a>> wrote:<o:p></o:p></p> </div> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0cm;margin-bottom:5.0pt"> <div> <p class="MsoNormal" style="margin-bottom:12.0pt">Yes, I would like to avoid having multiple code paths for context creation.<br> <br> Setting it later on should be equally to specifying it on creation since we only need it during CS.<br> <br> Regards,<br> Christian.<o:p></o:p></p> <div> <p class="MsoNormal">Am 21.03.23 um 14:00 schrieb Sharma, Shashank:<o:p></o:p></p> </div> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <div> <p style="margin:0cm"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:blue">[AMD Official Use Only - General]</span><o:p></o:p></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">When we started this patch series, the workload hint was a part of the ctx_flag only, <o:p></o:p></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">But we changed that after the design review, to make it more like how we are handling PSTATE. <o:p></o:p></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Details: <o:p></o:p></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><a href="https://patchwork.freedesktop.org/patch/496111/" target="_blank">https://patchwork.freedesktop.org/patch/496111/</a> <o:p></o:p></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Regards<o:p></o:p></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Shashank <o:p></o:p></p> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p> <div style="border:none;border-top:solid windowtext 1.0pt;padding:3.0pt 0cm 0cm 0cm;border-color:currentcolor currentcolor"> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><b><span lang="EN-US">From:</span></b><span lang="EN-US"> Marek Olšák <a href="mailto:maraeo@gmail.com" target="_blank"><maraeo@gmail.com></a> <br> <b>Sent:</b> 21 March 2023 04:05<br> <b>To:</b> Sharma, Shashank <a href="mailto:Shashank.Sharma@amd.com" target="_blank"> <Shashank.Sharma@amd.com></a><br> <b>Cc:</b> <a href="mailto:amd-gfx@lists.freedesktop.org" target="_blank">amd-gfx@lists.freedesktop.org</a>; Deucher, Alexander <a href="mailto:Alexander.Deucher@amd.com" target="_blank"><Alexander.Deucher@amd.com></a>; Somalapuram, Amaranath <a href="mailto:Amaranath.Somalapuram@amd.com" target="_blank"><Amaranath.Somalapuram@amd.com></a>; Koenig, Christian <a href="mailto:Christian.Koenig@amd.com" target="_blank"><Christian.Koenig@amd.com></a><br> <b>Subject:</b> Re: [PATCH v3 1/5] drm/amdgpu: add UAPI for workload hints to ctx ioctl</span><o:p></o:p></p> </div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p> <div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">I think we should do it differently because this interface will be mostly unused by open source userspace in its current form.<o:p></o:p></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Let's set the workload hint in drm_amdgpu_ctx_in::flags, and that will be immutable for the lifetime of the context. No other interface is needed.<o:p></o:p></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p> </div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Marek<o:p></o:p></p> </div> </div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p> <div> <div> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">On Mon, Sep 26, 2022 at 5:41 PM Shashank Sharma <<a href="mailto:shashank.sharma@amd.com" target="_blank">shashank.sharma@amd.com</a>> wrote:<o:p></o:p></p> </div> <blockquote style="border:none;border-left:solid windowtext 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0cm;margin-bottom:5.0pt;border-color:currentcolor currentcolor currentcolor rgb(204,204,204)"> <p class="MsoNormal" style="mso-margin-top-alt:auto;margin-bottom:12.0pt">Allow the user to specify a workload hint to the kernel.<br> We can use these to tweak the dpm heuristics to better match<br> the workload for improved performance.<br> <br> V3: Create only set() workload UAPI (Christian)<br> <br> Signed-off-by: Alex Deucher <<a href="mailto:alexander.deucher@amd.com" target="_blank">alexander.deucher@amd.com</a>><br> Signed-off-by: Shashank Sharma <<a href="mailto:shashank.sharma@amd.com" target="_blank">shashank.sharma@amd.com</a>><br> ---<br> include/uapi/drm/amdgpu_drm.h | 17 +++++++++++++++++<br> 1 file changed, 17 insertions(+)<br> <br> diff --git a/include/uapi/drm/amdgpu_drm.h b/include/uapi/drm/amdgpu_drm.h<br> index c2c9c674a223..23d354242699 100644<br> --- a/include/uapi/drm/amdgpu_drm.h<br> +++ b/include/uapi/drm/amdgpu_drm.h<br> @@ -212,6 +212,7 @@ union drm_amdgpu_bo_list {<br> #define AMDGPU_CTX_OP_QUERY_STATE2 4<br> #define AMDGPU_CTX_OP_GET_STABLE_PSTATE 5<br> #define AMDGPU_CTX_OP_SET_STABLE_PSTATE 6<br> +#define AMDGPU_CTX_OP_SET_WORKLOAD_PROFILE 7<br> <br> /* GPU reset status */<br> #define AMDGPU_CTX_NO_RESET 0<br> @@ -252,6 +253,17 @@ union drm_amdgpu_bo_list {<br> #define AMDGPU_CTX_STABLE_PSTATE_MIN_MCLK 3<br> #define AMDGPU_CTX_STABLE_PSTATE_PEAK 4<br> <br> +/* GPU workload hints, flag bits 8-15 */<br> +#define AMDGPU_CTX_WORKLOAD_HINT_SHIFT 8<br> +#define AMDGPU_CTX_WORKLOAD_HINT_MASK (0xff << AMDGPU_CTX_WORKLOAD_HINT_SHIFT)<br> +#define AMDGPU_CTX_WORKLOAD_HINT_NONE (0 << AMDGPU_CTX_WORKLOAD_HINT_SHIFT)<br> +#define AMDGPU_CTX_WORKLOAD_HINT_3D (1 << AMDGPU_CTX_WORKLOAD_HINT_SHIFT)<br> +#define AMDGPU_CTX_WORKLOAD_HINT_VIDEO (2 << AMDGPU_CTX_WORKLOAD_HINT_SHIFT)<br> +#define AMDGPU_CTX_WORKLOAD_HINT_VR (3 << AMDGPU_CTX_WORKLOAD_HINT_SHIFT)<br> +#define AMDGPU_CTX_WORKLOAD_HINT_COMPUTE (4 << AMDGPU_CTX_WORKLOAD_HINT_SHIFT)<br> +#define AMDGPU_CTX_WORKLOAD_HINT_MAX AMDGPU_CTX_WORKLOAD_HINT_COMPUTE<br> +#define AMDGPU_CTX_WORKLOAD_INDEX(n) (n >> AMDGPU_CTX_WORKLOAD_HINT_SHIFT)<br> +<br> struct drm_amdgpu_ctx_in {<br> /** AMDGPU_CTX_OP_* */<br> __u32 op;<br> @@ -281,6 +293,11 @@ union drm_amdgpu_ctx_out {<br> __u32 flags;<br> __u32 _pad;<br> } pstate;<br> +<br> + struct {<br> + __u32 flags;<br> + __u32 _pad;<br> + } workload;<br> };<br> <br> union drm_amdgpu_ctx {<br> -- <br> 2.34.1<o:p></o:p></p> </blockquote> </div> </div> </blockquote> <p class="MsoNormal"><o:p> </o:p></p> </div> </blockquote> </div> </blockquote> <p class="MsoNormal"><o:p> </o:p></p> </div> </blockquote> </div> </div> </blockquote> <p class="MsoNormal"><o:p> </o:p></p> </div> </body> </html>