<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:DengXian;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@DengXian";
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"\@SimSun";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72" style="word-wrap:break-word">
<p style="font-family:Arial;font-size:10pt;color:#008000;margin:15pt;" align="Left">
[Public]<br>
</p>
<br>
<div>
<div class="WordSection1">
<p class="MsoNormal">Hello Alex,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Should not. Almost original codes set sched.ready before amdgpu_ring_test_helper in each ring initialization. The new codes drop that and leave sched.ready set in amdgpu_ring_test_helper.<o:p></o:p></p>
<p class="MsoNormal">I tested it both on gfx10 and gfx11 chip.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Regards,<o:p></o:p></p>
<p class="MsoNormal">Guchun<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b> Deucher, Alexander <Alexander.Deucher@amd.com> <br>
<b>Sent:</b> Thursday, May 18, 2023 10:47 PM<br>
<b>To:</b> Chen, Guchun <Guchun.Chen@amd.com>; amd-gfx@lists.freedesktop.org; Zhang, Hawking <Hawking.Zhang@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; Pan, Xinhui <Xinhui.Pan@amd.com><br>
<b>Subject:</b> Re: [PATCH 0/3] cleanup abuse of sched.ready in each ring init<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p style="margin:5.0pt"><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:blue">[AMD Official Use Only - General]<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;color:black">Threre are a lot of places in the code where we check sched.ready. Will this break any of those?<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;color:black"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;color:black">Alex<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;color:black"><o:p> </o:p></span></p>
</div>
<div class="MsoNormal" align="center" style="text-align:center">
<hr size="2" width="98%" align="center">
</div>
<div id="divRplyFwdMsg">
<p class="MsoNormal"><b><span style="color:black">From:</span></b><span style="color:black"> Chen, Guchun <<a href="mailto:Guchun.Chen@amd.com">Guchun.Chen@amd.com</a>><br>
<b>Sent:</b> Thursday, May 18, 2023 3:02 AM<br>
<b>To:</b> <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <<a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>>; Deucher, Alexander <<a href="mailto:Alexander.Deucher@amd.com">Alexander.Deucher@amd.com</a>>;
Zhang, Hawking <<a href="mailto:Hawking.Zhang@amd.com">Hawking.Zhang@amd.com</a>>; Koenig, Christian <<a href="mailto:Christian.Koenig@amd.com">Christian.Koenig@amd.com</a>>; Pan, Xinhui <<a href="mailto:Xinhui.Pan@amd.com">Xinhui.Pan@amd.com</a>><br>
<b>Cc:</b> Chen, Guchun <<a href="mailto:Guchun.Chen@amd.com">Guchun.Chen@amd.com</a>><br>
<b>Subject:</b> [PATCH 0/3] cleanup abuse of sched.ready in each ring init</span>
<o:p></o:p></p>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt">This series intend to fix the abuse of flag sched.ready in<br>
each ring init process. Its status needs to be updated only after<br>
respective ring/IB test in init/resume.<br>
<br>
Guchun Chen (3):<br>
drm/amdgpu/sdma: set sched.ready status after ring/IB test in sdma<br>
drm/amdgpu/gfx: set sched.ready status after ring/IB test in gfx<br>
drm/amdgpu: switch to unified amdgpu_ring_test_helper<br>
<br>
drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 9 ++-------<br>
drivers/gpu/drm/amd/amdgpu/cik_sdma.c | 2 --<br>
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 24 ++++-------------------<br>
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 25 ++++--------------------<br>
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 2 --<br>
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 --<br>
drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 1 -<br>
drivers/gpu/drm/amd/amdgpu/mes_v10_1.c | 8 +-------<br>
drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 7 +------<br>
drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c | 2 --<br>
drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 2 --<br>
drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 4 ----<br>
drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c | 4 ----<br>
drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c | 2 --<br>
drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 8 ++------<br>
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 6 +-----<br>
drivers/gpu/drm/amd/amdgpu/si_dma.c | 2 --<br>
17 files changed, 15 insertions(+), 95 deletions(-)<br>
<br>
-- <br>
2.25.1<o:p></o:p></p>
</div>
</div>
</div>
</div>
</div>
</div>
</body>
</html>