<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#0000FF;margin:5pt;" align="Left">
[AMD Official Use Only - General]<br>
</p>
<br>
<div>
<div style="font-family: Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
<div style="font-size: 12pt; color: rgb(0, 0, 0);" class="ContentPasted0">(+ Felix)<br class="ContentPasted0">
<br class="ContentPasted0">
Should we do the same for other modules under amd (amdkfd)? I was going to enable full kernel werror in the kconfig used by my CI but this is probably better.</div>
<div style="font-size: 12pt; color: rgb(0, 0, 0);" class="ContentPasted0"><br class="ContentPasted0">
</div>
<span style="font-size: 12pt; color: rgb(0, 0, 0);" class="ContentPasted0">Kenny</span><br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Alex Deucher <alexdeucher@gmail.com><br>
<b>Sent:</b> Wednesday, May 24, 2023 3:22 PM<br>
<b>To:</b> Mahfooz, Hamza <Hamza.Mahfooz@amd.com><br>
<b>Cc:</b> amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>; Li, Sun peng (Leo) <Sunpeng.Li@amd.com>; Ho, Kenny <Kenny.Ho@amd.com>; Pan, Xinhui <Xinhui.Pan@amd.com>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>;
dri-devel@lists.freedesktop.org <dri-devel@lists.freedesktop.org>; Daniel Vetter <daniel@ffwll.ch>; Deucher, Alexander <Alexander.Deucher@amd.com>; David Airlie <airlied@gmail.com>; Wentland, Harry <Harry.Wentland@amd.com>; Koenig, Christian <Christian.Koenig@amd.com><br>
<b>Subject:</b> Re: [PATCH v2] drm/amd/display: enable more strict compile checks</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">On Wed, May 24, 2023 at 3:20 PM Hamza Mahfooz <hamza.mahfooz@amd.com> wrote:<br>
><br>
> Currently, there are quite a number of issues that are quite easy for<br>
> the CI to catch, that slip through the cracks. Among them, there are<br>
> unused variable and indentation issues. Also, we should consider all<br>
> warnings to be compile errors, since the community will eventually end<br>
> up complaining about them. So, enable -Werror, -Wunused and<br>
> -Wmisleading-indentation for all kernel builds.<br>
><br>
> Cc: Alex Deucher <alexander.deucher@amd.com><br>
> Cc: Harry Wentland <harry.wentland@amd.com><br>
> Cc: Kenny Ho <kenny.ho@amd.com><br>
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com><br>
> ---<br>
> v2: fix grammatical error<br>
> ---<br>
> drivers/gpu/drm/amd/display/Makefile | 2 ++<br>
> 1 file changed, 2 insertions(+)<br>
><br>
> diff --git a/drivers/gpu/drm/amd/display/Makefile b/drivers/gpu/drm/amd/display/Makefile<br>
> index 0d610cb376bb..3c44162ebe21 100644<br>
> --- a/drivers/gpu/drm/amd/display/Makefile<br>
> +++ b/drivers/gpu/drm/amd/display/Makefile<br>
> @@ -26,6 +26,8 @@<br>
><br>
> AMDDALPATH = $(RELATIVE_AMD_DISPLAY_PATH)<br>
><br>
> +subdir-ccflags-y += -Werror -Wunused -Wmisleading-indentation<br>
> +<br>
<br>
Care to enable this for the rest of amdgpu as well? Or send out an<br>
additional patch to do that? Either way:<br>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com><br>
<br>
Alex<br>
<br>
> subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/<br>
> subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/hw<br>
> subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/clk_mgr<br>
> --<br>
> 2.40.1<br>
><br>
</div>
</span></font></div>
</div>
</body>
</html>