<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#008000;margin:15pt;font-style:normal;font-weight:normal;text-decoration:none;" align="Left">
[Public]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
Sorry, replied to the wrong rev of the patch. my AB applies to v2 as well.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
Alex<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Deucher, Alexander <Alexander.Deucher@amd.com><br>
<b>Sent:</b> Tuesday, June 13, 2023 9:25 AM<br>
<b>To:</b> Lazar, Lijo <Lijo.Lazar@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Cc:</b> Ma, Le <Le.Ma@amd.com>; Kamal, Asad <Asad.Kamal@amd.com>; Zhang, Hawking <Hawking.Zhang@amd.com><br>
<b>Subject:</b> Re: [PATCH 3/3] drm/amdgpu: Remove unused NBIO interface</font>
<div> </div>
</div>
<style type="text/css" style="display:none">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<p align="Left" style="font-family:Arial; font-size:10pt; color:#008000; margin:15pt; font-style:normal; font-weight:normal; text-decoration:none">
[Public]<br>
</p>
<br>
<div>
<p align="Left" style="font-family:Arial; font-size:10pt; color:#008000; margin:15pt; font-style:normal; font-weight:normal; text-decoration:none">
[Public]<br>
</p>
<br>
<div>
<div class="x_elementToProof" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
Series is:</div>
<div class="x_elementToProof" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
Acked-by: Alex Deucher <alexander.deucher@amd.com><br>
</div>
<div id="x_appendonsend"></div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Lazar, Lijo <Lijo.Lazar@amd.com><br>
<b>Sent:</b> Tuesday, June 13, 2023 6:53 AM<br>
<b>To:</b> amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Cc:</b> Zhang, Hawking <Hawking.Zhang@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Kamal, Asad <Asad.Kamal@amd.com>; Ma, Le <Le.Ma@amd.com><br>
<b>Subject:</b> [PATCH 3/3] drm/amdgpu: Remove unused NBIO interface</font>
<div> </div>
</div>
<div class="x_BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="x_PlainText">Set compute partition mode interface in NBIO is no longer used. Remove<br>
the only implementation from NBIO v7.9<br>
<br>
Signed-off-by: Lijo Lazar <lijo.lazar@amd.com><br>
---<br>
drivers/gpu/drm/amd/amdgpu/amdgpu_nbio.h | 2 --<br>
drivers/gpu/drm/amd/amdgpu/nbio_v7_9.c | 14 --------------<br>
2 files changed, 16 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_nbio.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_nbio.h<br>
index 095aecfb201e..8ab8ae01f87c 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_nbio.h<br>
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_nbio.h<br>
@@ -99,8 +99,6 @@ struct amdgpu_nbio_funcs {<br>
int (*get_compute_partition_mode)(struct amdgpu_device *adev);<br>
u32 (*get_memory_partition_mode)(struct amdgpu_device *adev,<br>
u32 *supp_modes);<br>
- void (*set_compute_partition_mode)(struct amdgpu_device *adev,<br>
- enum amdgpu_gfx_partition mode);<br>
};<br>
<br>
struct amdgpu_nbio {<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/nbio_v7_9.c b/drivers/gpu/drm/amd/amdgpu/nbio_v7_9.c<br>
index b033935d6749..cd1a02d30420 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/nbio_v7_9.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/nbio_v7_9.c<br>
@@ -393,19 +393,6 @@ static int nbio_v7_9_get_compute_partition_mode(struct amdgpu_device *adev)<br>
return px;<br>
}<br>
<br>
-static void nbio_v7_9_set_compute_partition_mode(struct amdgpu_device *adev,<br>
- enum amdgpu_gfx_partition mode)<br>
-{<br>
- u32 tmp;<br>
-<br>
- /* SPX=0, DPX=1, TPX=2, QPX=3, CPX=4 */<br>
- tmp = RREG32_SOC15(NBIO, 0, regBIF_BX_PF0_PARTITION_COMPUTE_STATUS);<br>
- tmp = REG_SET_FIELD(tmp, BIF_BX_PF0_PARTITION_COMPUTE_STATUS,<br>
- PARTITION_MODE, mode);<br>
-<br>
- WREG32_SOC15(NBIO, 0, regBIF_BX_PF0_PARTITION_COMPUTE_STATUS, tmp);<br>
-}<br>
-<br>
static u32 nbio_v7_9_get_memory_partition_mode(struct amdgpu_device *adev,<br>
u32 *supp_modes)<br>
{<br>
@@ -461,7 +448,6 @@ const struct amdgpu_nbio_funcs nbio_v7_9_funcs = {<br>
.ih_control = nbio_v7_9_ih_control,<br>
.remap_hdp_registers = nbio_v7_9_remap_hdp_registers,<br>
.get_compute_partition_mode = nbio_v7_9_get_compute_partition_mode,<br>
- .set_compute_partition_mode = nbio_v7_9_set_compute_partition_mode,<br>
.get_memory_partition_mode = nbio_v7_9_get_memory_partition_mode,<br>
.init_registers = nbio_v7_9_init_registers,<br>
};<br>
-- <br>
2.25.1<br>
<br>
</div>
</span></font></div>
</div>
</div>
</div>
</div>
</body>
</html>