<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#008000;margin:15pt;font-style:normal;font-weight:normal;text-decoration:none;" align="Left">
[Public]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
Hi Michel,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
You confirmed in another thread the monitor specific quirk for disabling FAMS fixed your hang. Fixes references the commit which adds such quirk:<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof ContentPasted0">
de1da2f7fe25 drm/amd/display: Add monitor specific edid quirk</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof ContentPasted0">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof ContentPasted0">
The intention is that these two patches should only be merged into stable trees after applying the monitor specific quirk.
<br>
</div>
<div class="elementToProof">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div id="Signature">
<div>
<div></div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
--</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Regards,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Jay<br>
</div>
</div>
</div>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Michel Dänzer <michel.daenzer@mailbox.org><br>
<b>Sent:</b> Thursday, July 6, 2023 6:05 AM<br>
<b>To:</b> Pillai, Aurabindo <Aurabindo.Pillai@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Cc:</b> Chalmers, Wesley <Wesley.Chalmers@amd.com>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>; Wheeler, Daniel <Daniel.Wheeler@amd.com>; Mahfooz, Hamza <Hamza.Mahfooz@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Wentland, Harry <Harry.Wentland@amd.com><br>
<b>Subject:</b> Re: [PATCH 1/2] drm/amd/display: Do not set drr on pipe commit</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">On 7/5/23 20:07, Aurabindo Pillai wrote:<br>
> From: Wesley Chalmers <Wesley.Chalmers@amd.com><br>
> <br>
> [WHY]<br>
> Writing to DRR registers such as OTG_V_TOTAL_MIN on the same frame as a<br>
> pipe commit can cause underflow.<br>
> <br>
> [HOW]<br>
> Move DMUB p-state delegate into optimze_bandwidth; enabling FAMS sets<br>
> optimized_required.<br>
> <br>
> This change expects that Freesync requests are blocked when<br>
> optimized_required is true.<br>
> <br>
> Fixes: de1da2f7fe25 ("drm/amd/display: Add monitor specific edid quirk")<br>
<br>
Seems like inappropriate use of Fixes:, or how does this commit "fix" the referenced commit?<br>
<br>
(Also a bit surprised to learn about that one only now, and that it landed without my confirming it actually works)<br>
<br>
<br>
-- <br>
Earthling Michel Dänzer | <a href="https://redhat.com">
https://redhat.com</a><br>
Libre software enthusiast | Mesa and Xwayland developer<br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>