<html><head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> </head> <body> <div class="moz-cite-prefix">On 2023-07-20 06:46, Michel Dänzer wrote: </div> <blockquote type="cite" cite="mid:1da36164-7cd9-c2a3-a42f-558942257727@daenzer.net"> <pre class="moz-quote-pre" wrap="">On 7/17/23 15:09, Michel Dänzer wrote: </pre> <blockquote type="cite"> <pre class="moz-quote-pre" wrap="">On 5/10/23 23:23, Alex Deucher wrote: </pre> <blockquote type="cite"> <pre class="moz-quote-pre" wrap="">From: Philip Yang <a class="moz-txt-link-rfc2396E" href="mailto:Philip.Yang@amd.com"><Philip.Yang@amd.com></a> Rename smv_migrate_init to a better name kgd2kfd_init_zone_device because it setup zone devive pgmap for page migration and keep it in kfd_migrate.c to access static functions svm_migrate_pgmap_ops. Call it only once in amdgpu_device_ip_init after adev ip blocks are initialized, but before amdgpu_amdkfd_device_init initialize kfd nodes which enable SVM support based on pgmap. svm_range_set_max_pages is called by kgd2kfd_device_init everytime after switching compute partition mode. Signed-off-by: Philip Yang <a class="moz-txt-link-rfc2396E" href="mailto:Philip.Yang@amd.com"><Philip.Yang@amd.com></a> Reviewed-by: Felix Kuehling <a class="moz-txt-link-rfc2396E" href="mailto:Felix.Kuehling@amd.com"><Felix.Kuehling@amd.com></a> Signed-off-by: Alex Deucher <a class="moz-txt-link-rfc2396E" href="mailto:alexander.deucher@amd.com"><alexander.deucher@amd.com></a> </pre> </blockquote> <pre class="moz-quote-pre" wrap=""> I bisected a regression to this commit, which broke HW acceleration on this ThinkPad E595 with Picasso APU. </pre> </blockquote> <pre class="moz-quote-pre" wrap=""> Actually, it doesn't seem to break HW acceleration completely. GDM eventually comes up with HW acceleration, it takes a long time (~30s or so) to start up though. Later, the same messages as described in <a class="moz-txt-link-freetext" href="https://gitlab.freedesktop.org/drm/amd/-/issues/2659">https://gitlab.freedesktop.org/drm/amd/-/issues/2659</a> appear. Reverting this commit fixes all of the above symptoms. I reproduced all of the above symptoms with amd-staging-drm-next commit 75515acf4b60 ("i2c: nvidia-gpu: Add ACPI property to align with device-tree") as well. For full disclosure, I use these kernel command line arguments: fbcon=font:10x18 drm_kms_helper.drm_fbdev_overalloc=112 amdgpu.noretry=1 amdgpu.mcbp=1</pre> </blockquote> Thanks for the issue report and full disclosure, but I am not able to reproduce this issue, with both drm-next branch and amd-staging-drm-next branch tip on gitlab. The test system has same device id, running Ubuntu 22.04, latest linux-firmware-20230625.tar.gz, and same BIOS version. I attached full dmesg log, could you help check if there is other difference, maybe kernel config, gcc version... it is hard to guess what could cause the basic driver gfx ring IB test timeout. Regards, Philip <blockquote type="cite" cite="mid:1da36164-7cd9-c2a3-a42f-558942257727@daenzer.net"> <pre class="moz-quote-pre" wrap=""> </pre> </blockquote> </body> </html>