<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
Hi all, </div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
Just looking for anyone who could RB or ACK this patch set so I can submit it?</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
Thanks</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
Darren</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Powell, Darren <Darren.Powell@amd.com><br>
<b>Sent:</b> Thursday, April 27, 2023 2:27 AM<br>
<b>To:</b> amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Cc:</b> Lazar, Lijo <Lijo.Lazar@amd.com>; Quan, Evan <Evan.Quan@amd.com>; Yu, Lang <Lang.Yu@amd.com>; Huang, Ray <Ray.Huang@amd.com>; david.nieto@amd.com <david.nieto@amd.com>; Powell, Darren <Darren.Powell@amd.com><br>
<b>Subject:</b> [PATCH 0/8] amdgpu/pm: Implement emit_clock_levels for arcturus,aldebaran</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText"><br>
amdgpu/pm: Implement emit_clock_levels for arcturus,aldebaran<br>
<br>
== Description ==<br>
Scnprintf use within the kernel is not recommended, but simple sysfs_emit replacement has<br>
not been successful due to the page alignment requirement of the function. This patch<br>
set implements a new api "emit_clock_levels" to facilitate passing both the base and<br>
offset to the device rather than just the write pointer.<br>
<br>
This patch set replaces print_clock_levels for arcturus and aldebaran platforms with
<br>
emit_clock_levels, and also optimizes the code to reduce the code duplication for each
<br>
different clock. This was spread into three parts to show more clearly the changes made<br>
to the code, followed by combining the common code into a second switch statement.<br>
It is similar to previous work on vega10 to implement emit_clk_levels<br>
commit a63e6b83 ("amdgpu/pm: Implement emit_clk_levels for vega10")<br>
with the addition of the optimization to reduce code duplication.<br>
<br>
== Patch Summary ==<br>
linux: (git@gitlab.freedesktop.org:agd5f) origin/amd-staging-drm-next @ 2d8c6b82e241<br>
+ 9a269da4c047 amdgpu/pm: Replace print_clock_levels with emit_clock_levels for arcturus<br>
+ 51ce0fcc9599 amdgpu/pm: Optimize emit_clock_levels for arcturus - part 1<br>
+ dcaa5b7551dd amdgpu/pm: Optimize emit_clock_levels for arcturus - part 2<br>
+ 1d16d820e4ee amdgpu/pm: Optimize emit_clock_levels for arcturus - part 3<br>
+ b374fbf6013d amdgpu/pm: Replace print_clock_levels with emit_clock_levels for aldebaran<br>
+ 2ecf48d3e83c amdgpu/pm: Optimize emit_clock_levels for aldebaran - part 1<br>
+ fd8c21e1d1e4 amdgpu/pm: Optimize emit_clock_levels for aldebaran - part 2<br>
+ a67ce808f18c amdgpu/pm: Optimize emit_clock_levels for aldebaran - part 3<br>
<br>
== System Summary ==<br>
* DESKTOP(AMD Ryzen9 7900 + NAVI10(731f/ca), BIOS: 1.11)<br>
+ ISO(Ubuntu 22.04.2 LTS)<br>
+ Kernel(6.1.11-20230412-fdoagd5f-g2d8c6b82e241)<br>
<br>
== Test ==<br>
AMDGPU_PCI_ADDR=`lspci -nn | grep "VGA\|Display" | cut -d " " -f 1`<br>
AMDGPU_HWMON=`ls -la /sys/class/hwmon | grep $AMDGPU_PCI_ADDR | awk '{print $9}'`<br>
HWMON_DIR=/sys/class/hwmon/${AMDGPU_HWMON}<br>
<br>
lspci -nn | grep "VGA\|Display" > $LOGFILE<br>
printf 'OD enabled = %X\n' "$(( `cat /sys/module/amdgpu/parameters/ppfeaturemask` & 0x4000 ))" >> $LOGFILE<br>
FILES="pp_od_clk_voltage<br>
pp_dpm_sclk<br>
pp_dpm_mclk<br>
pp_dpm_pcie<br>
pp_dpm_socclk<br>
pp_dpm_fclk<br>
pp_dpm_dcefclk<br>
pp_dpm_vclk<br>
pp_dpm_dclk "<br>
<br>
for f in $FILES<br>
do<br>
echo === $f === >> $LOGFILE<br>
cat $HWMON_DIR/device/$f >> $LOGFILE<br>
done<br>
cat $LOGFILE<br>
<br>
Darren Powell (8):<br>
amdgpu/pm: Replace print_clock_levels with emit_clock_levels for<br>
arcturus<br>
amdgpu/pm: Optimize emit_clock_levels for arcturus - part 1<br>
amdgpu/pm: Optimize emit_clock_levels for arcturus - part 2<br>
amdgpu/pm: Optimize emit_clock_levels for arcturus - part 3<br>
amdgpu/pm: Replace print_clock_levels with emit_clock_levels for<br>
aldebaran<br>
amdgpu/pm: Optimize emit_clock_levels for aldebaran - part 1<br>
amdgpu/pm: Optimize emit_clock_levels for aldebaran - part 2<br>
amdgpu/pm: Optimize emit_clock_levels for aldebaran - part 3<br>
<br>
.../gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 166 ++++++----------<br>
.../drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 181 +++++++-----------<br>
2 files changed, 132 insertions(+), 215 deletions(-)<br>
<br>
<br>
base-commit: 2d8c6b82e241f2d1a802ae6bbc24c127e689c724<br>
-- <br>
2.34.1<br>
<br>
</div>
</span></font></div>
</body>
</html>