<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="#0563C1" vlink="#954F72" style="word-wrap:break-word"> [AMD Official Use Only - General] <div> <div class="WordSection1"> The series looks good to me. <o:p></o:p> Reviewed-by: Evan Quan <a href="mailto:evan.quan@amd.com">evan.quan@amd.com</a><o:p></o:p> <o:p> </o:p> However better to split the changes of patch1 into two separate patches on your submission.<o:p></o:p> Replace print_clock_levels with emit_clock_levels for arcturus<o:p></o:p> * replace .print_clk_levels with .emit_clk_levels in arcturus_ppt_funcs<o:p></o:p> * added extra parameter int *offset<o:p></o:p> * removed var size, uses arg *offset instead<o:p></o:p> * removed call to smu_cmn_get_sysfs_buf<o:p></o:p> * errors are returned to caller<o:p></o:p> * returns 0 on success<o:p></o:p> Those changes are included in one patch.<o:p></o:p> additional incidental changes<o:p></o:p> * changed type of var i, now to remove comparing mismatch types<o:p></o:p> * renamed var s/now/cur_value/<o:p></o:p> * switch statement default now returns -EINVAL<o:p></o:p> * RAS Recovery returns -EBUSY<o:p></o:p> While those are included in another patch.<o:p></o:p> <o:p> </o:p> Same applied to patch5.<o:p></o:p> <o:p> </o:p> BR,<o:p></o:p> Evan<o:p></o:p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: Powell, Darren <Darren.Powell@amd.com> Sent: Friday, July 28, 2023 3:51 AM To: amd-gfx@lists.freedesktop.org Cc: Lazar, Lijo <Lijo.Lazar@amd.com>; Quan, Evan <Evan.Quan@amd.com>; Yu, Lang <Lang.Yu@amd.com>; Huang, Ray <Ray.Huang@amd.com> Subject: Re: [PATCH 0/8] amdgpu/pm: Implement emit_clock_levels for arcturus,aldebaran<o:p></o:p> </div> </div> <o:p> </o:p> <div> Hi all, <o:p></o:p> </div> <div> Just looking for anyone who could RB or ACK this patch set so I can submit it?<o:p></o:p> </div> <div> Thanks<o:p></o:p> </div> <div> Darren<o:p></o:p> </div> <div class="MsoNormal" align="center" style="text-align:center"> <hr size="2" width="98%" align="center"> </div> <div id="divRplyFwdMsg"> From: Powell, Darren <<a href="mailto:Darren.Powell@amd.com">Darren.Powell@amd.com</a>> Sent: Thursday, April 27, 2023 2:27 AM To: <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <<a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>> Cc: Lazar, Lijo <<a href="mailto:Lijo.Lazar@amd.com">Lijo.Lazar@amd.com</a>>; Quan, Evan <<a href="mailto:Evan.Quan@amd.com">Evan.Quan@amd.com</a>>; Yu, Lang <<a href="mailto:Lang.Yu@amd.com">Lang.Yu@amd.com</a>>; Huang, Ray <<a href="mailto:Ray.Huang@amd.com">Ray.Huang@amd.com</a>>; <a href="mailto:david.nieto@amd.com">david.nieto@amd.com</a> <<a href="mailto:david.nieto@amd.com">david.nieto@amd.com</a>>; Powell, Darren <<a href="mailto:Darren.Powell@amd.com">Darren.Powell@amd.com</a>> Subject: [PATCH 0/8] amdgpu/pm: Implement emit_clock_levels for arcturus,aldebaran <o:p></o:p> <div> <o:p></o:p> </div> </div> <div> <div> amdgpu/pm: Implement emit_clock_levels for arcturus,aldebaran == Description == Scnprintf use within the kernel is not recommended, but simple sysfs_emit replacement has not been successful due to the page alignment requirement of the function. This patch set implements a new api "emit_clock_levels" to facilitate passing both the base and offset to the device rather than just the write pointer. This patch set replaces print_clock_levels for arcturus and aldebaran platforms with emit_clock_levels, and also optimizes the code to reduce the code duplication for each different clock. This was spread into three parts to show more clearly the changes made to the code, followed by combining the common code into a second switch statement. It is similar to previous work on vega10 to implement emit_clk_levels commit a63e6b83 ("amdgpu/pm: Implement emit_clk_levels for vega10") with the addition of the optimization to reduce code duplication. == Patch Summary == linux: (<a href="mailto:git@gitlab.freedesktop.org:agd5f">git@gitlab.freedesktop.org:agd5f</a>) origin/amd-staging-drm-next @ 2d8c6b82e241 + 9a269da4c047 amdgpu/pm: Replace print_clock_levels with emit_clock_levels for arcturus + 51ce0fcc9599 amdgpu/pm: Optimize emit_clock_levels for arcturus - part 1 + dcaa5b7551dd amdgpu/pm: Optimize emit_clock_levels for arcturus - part 2 + 1d16d820e4ee amdgpu/pm: Optimize emit_clock_levels for arcturus - part 3 + b374fbf6013d amdgpu/pm: Replace print_clock_levels with emit_clock_levels for aldebaran + 2ecf48d3e83c amdgpu/pm: Optimize emit_clock_levels for aldebaran - part 1 + fd8c21e1d1e4 amdgpu/pm: Optimize emit_clock_levels for aldebaran - part 2 + a67ce808f18c amdgpu/pm: Optimize emit_clock_levels for aldebaran - part 3 == System Summary == * DESKTOP(AMD Ryzen9 7900 + NAVI10(731f/ca), BIOS: 1.11) + ISO(Ubuntu 22.04.2 LTS) + Kernel(6.1.11-20230412-fdoagd5f-g2d8c6b82e241) == Test == AMDGPU_PCI_ADDR=`lspci -nn | grep "VGA\|Display" | cut -d " " -f 1` AMDGPU_HWMON=`ls -la /sys/class/hwmon | grep $AMDGPU_PCI_ADDR | awk '{print $9}'` HWMON_DIR=/sys/class/hwmon/${AMDGPU_HWMON} lspci -nn | grep "VGA\|Display" > $LOGFILE printf 'OD enabled = %X\n' "$(( `cat /sys/module/amdgpu/parameters/ppfeaturemask` & 0x4000 ))" >> $LOGFILE FILES="pp_od_clk_voltage pp_dpm_sclk pp_dpm_mclk pp_dpm_pcie pp_dpm_socclk pp_dpm_fclk pp_dpm_dcefclk pp_dpm_vclk pp_dpm_dclk " for f in $FILES do echo === $f === >> $LOGFILE cat $HWMON_DIR/device/$f >> $LOGFILE done cat $LOGFILE Darren Powell (8): amdgpu/pm: Replace print_clock_levels with emit_clock_levels for arcturus amdgpu/pm: Optimize emit_clock_levels for arcturus - part 1 amdgpu/pm: Optimize emit_clock_levels for arcturus - part 2 amdgpu/pm: Optimize emit_clock_levels for arcturus - part 3 amdgpu/pm: Replace print_clock_levels with emit_clock_levels for aldebaran amdgpu/pm: Optimize emit_clock_levels for aldebaran - part 1 amdgpu/pm: Optimize emit_clock_levels for aldebaran - part 2 amdgpu/pm: Optimize emit_clock_levels for aldebaran - part 3 .../gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 166 ++++++---------- .../drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 181 +++++++----------- 2 files changed, 132 insertions(+), 215 deletions(-) base-commit: 2d8c6b82e241f2d1a802ae6bbc24c127e689c724 -- 2.34.1<o:p></o:p> </div> </div> </div> </div> </div> </body> </html>